tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
PATCH 1/2 tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
From: Ville Syrjälä <[email protected]>
Asking for the initial vblank count by specifying and absolute vblank count of 0 doesn't make much sense. Switch to a relative query instead.
--- tests/kms_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_setmode.c +1 -1
@@ -431,7 +431,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)memset (&wait,0 ,sizeof (wait)); wait.request.type =kmstest_get_vbl_flag (crtc_idx); - wait.request.type |=DRM_VBLANK_ABSOLUTE |DRM_VBLANK_NEXTONMISS ; + wait.request.type |=DRM_VBLANK_RELATIVE |DRM_VBLANK_NEXTONMISS ;do_or_die (drmWaitVBlank (drm_fd, &wait)); last_seq = wait.reply.sequence;
Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 tests/kms_flip: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
From: Ville Syrjälä <[email protected]>
Asking for the initial vblank count by specifying and absolute vblank count of 0 doesn't make much sense. Switch to a relative query instead.
--- tests/kms_flip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_flip.c +1 -1
@@ -1159,7 +1159,7 @@ static void calibrate_ts(struct test_output *o, int crtc_idx)memset (&wait,0 ,sizeof (wait)); wait.request.type =kmstest_get_vbl_flag (crtc_idx); - wait.request.type |=DRM_VBLANK_ABSOLUTE |DRM_VBLANK_NEXTONMISS ; + wait.request.type |=DRM_VBLANK_RELATIVE |DRM_VBLANK_NEXTONMISS ;do_or_die (drmWaitVBlank (drm_fd, &wait)); last_seq = wait.reply.sequence;
Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [1/2] tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/2] tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
URL : https://patchwork.freedesktop.org/series/31600/
State : failure
== Summary ==
IGT patchset tested on top of latest successful build f1e77e83d620f66f98401854a63b93dc4cead880 tests/kms_draw_crc: Skip tests for unsupported formats
with latest DRM-Tip kernel build CI_DRM_319718b15be401ec drm-tip: 2017y-10m-09d-17h-21m-07s UTC integration manifest
No testlist changes.
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-FAIL (fi-kbl-7560u) fdo#103039
Subgroup basic-s4-devices:
pass -> DMESG-FAIL (fi-kbl-7560u) fdo#102846 +1
Test gem_flink_basic:
Subgroup bad-flink:
pass -> DMESG-WARN (fi-kbl-7560u) fdo#103049 +4
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (fi-kbl-r)fdo#103039 https://bugs.freedesktop.org/show_bug.cgi?id=103039
fdo#102846 https://bugs.freedesktop.org/show_bug.cgi?id=102846
fdo#103049 https://bugs.freedesktop.org/show_bug.cgi?id=103049
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:457s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:474s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:392s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:580s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:288s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:531s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:526s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:538s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:510s fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:556s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:633s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:435s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:601s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:441s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:419s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:467s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:498s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:474s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:511s fi-kbl-7560u total:125 pass:105 dwarn:5 dfail:2 fail:0 skip:12 fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:491s fi-kbl-r total:245 pass:220 dwarn:0 dfail:0 fail:0 skip:24 fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:661s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:482s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:655s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:517s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:472s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:584s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:445s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_307/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 15 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Asking for the initial vblank count by specifying and absolute vblank count of 0 doesn't make much sense. Switch to a relative query instead.
Signed-off-by Ville Syrjälä <[email protected]>--- tests/kms_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_setmode.c +0
-0
tests/kms_setmode.c static void check_timings(int crtc_idx, const drmModeModeInfo *kmode) · line 434
Quoted 5 lines
tests/kms_setmode.c +1
-1@@ -431,7 +431,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)memset (&wait,0 ,sizeof (wait)); wait.request.type =kmstest_get_vbl_flag (crtc_idx); - wait.request.type |=DRM_VBLANK_ABSOLUTE |DRM_VBLANK_NEXTONMISS ; + wait.request.type |=DRM_VBLANK_RELATIVE |DRM_VBLANK_NEXTONMISS ;
Looking at drm_wait_vblank_is_query() in drm_vblank.c you also want to drop NEXTONMISS. With that:
Cheers, Daniel
Quoted 10 lines
tests/kms_setmode.c +0
-0do_or_die (drmWaitVBlank (drm_fd, &wait)); last_seq = wait.reply.sequence;Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Daniel Vetter
Quoted 16 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Asking for the initial vblank count by specifying and absolute vblank count of 0 doesn't make much sense. Switch to a relative query instead.
Signed-off-by Ville Syrjälä <[email protected]>--- tests/kms_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_setmode.c +0
-0@@ -431,7 +431,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
Quoted 7 lines
tests/kms_setmode.c static void check_timings(int crtc_idx, const drmModeModeInfo *kmode) · line 434
Quoted 4 lines
tests/kms_setmode.c +1
-1memset (&wait,0 ,sizeof (wait)); wait.request.type =kmstest_get_vbl_flag (crtc_idx); - wait.request.type |=DRM_VBLANK_ABSOLUTE |DRM_VBLANK_NEXTONMISS ; + wait.request.type |=DRM_VBLANK_RELATIVE |DRM_VBLANK_NEXTONMISS ;Looking at
drm_wait_vblank_is_query()indrm_vblank.cyou also want to drop NEXTONMISS.
Hmm. I think we may want to line things up to a vblank boundary here (but I'd have to re-read the code to confirm that). Without the NEXTONMISS we would just query the current count and continue immediately. Alternative I guess we could drop the NEXTONMISS but instead wait for seq+1.
Quoted 20 lines
With that:
Reviewed-by Daniel Vetter <[email protected]> on both.Cheers, Daniel
Quoted 10 lines
tests/kms_setmode.c +0
-0do_or_die (drmWaitVBlank (drm_fd, &wait)); last_seq = wait.reply.sequence;Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 26 lines · Ville Syrjälä
Quoted 17 lines · Daniel Vetter
Quoted 16 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Asking for the initial vblank count by specifying and absolute vblank count of 0 doesn't make much sense. Switch to a relative query instead.
Signed-off-by Ville Syrjälä <[email protected]>--- tests/kms_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/kms_setmode.c +0
-0@@ -431,7 +431,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)Quoted 7 lines
tests/kms_setmode.c static void check_timings(int crtc_idx, const drmModeModeInfo *kmode) · line 434
Quoted 4 lines
tests/kms_setmode.c +1
-1memset (&wait,0 ,sizeof (wait)); wait.request.type =kmstest_get_vbl_flag (crtc_idx); - wait.request.type |=DRM_VBLANK_ABSOLUTE |DRM_VBLANK_NEXTONMISS ; + wait.request.type |=DRM_VBLANK_RELATIVE |DRM_VBLANK_NEXTONMISS ;Looking at
drm_wait_vblank_is_query()indrm_vblank.cyou also want to drop NEXTONMISS.
Quoted 5 lines
Hmm. I think we may want to line things up to a vblank boundary here (but I'd have to re-read the code to confirm that). Without the NEXTONMISS we would just query the current count and continue immediately. Alternative I guess we could drop the NEXTONMISS but instead wait for seq+1.
NEXTONMISS means you don't actually query, but wait until that vblank happened (as a blocking ioctl, you only get the event when asking for it).
I didn't really look into what the tests wants, just went with your description of what you want to do ...
-Daniel
Quoted 25 lines
Quoted 21 lines
With that:
Reviewed-by Daniel Vetter <[email protected]> on both.Cheers, Daniel
Quoted 10 lines
tests/kms_setmode.c +0
-0do_or_die (drmWaitVBlank (drm_fd, &wait)); last_seq = wait.reply.sequence;Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.chSignature · 2 lines
Ville Syrjälä Intel OTC
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/2] tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/2] tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
URL : https://patchwork.freedesktop.org/series/31600/
State : success
== Summary ==
IGT patchset tested on top of latest successful build d7c88290ab6a8393dc341b30c7fb5e27d2952901 syncobj: Add a test for SYNCOBJ_CREATE_SIGNALED
with latest DRM-Tip kernel build CI_DRM_3207d82f454de90a drm-tip: 2017y-10m-10d-18h-40m-34s UTC integration manifest
No testlist changes.
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-j1900) fdo#101705 +1fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:453s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:471s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:396s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:563s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:287s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:533s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:532s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:537s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:524s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:563s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:629s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:435s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:600s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:442s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:419s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:465s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:476s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:507s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:581s fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:485s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:594s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:668s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:474s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:658s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:534s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:516s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:472s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:576s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:435s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_316/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [1/2] tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/2] tests/kms_setmode: Request the intiial vbl count with RELATIVE instead of ABSOLUTE
URL : https://patchwork.freedesktop.org/series/31600/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-cur-indfb-draw-render:
dmesg-warn -> PASS (shard-hsw) fdo#102886 +3
Test kms_flip:
Subgroup flip-vs-absolute-wf_vblank-interruptible:
fail -> PASS (shard-hsw) fdo#100368
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-hsw total:2552 pass:1432 dwarn:5 dfail:0 fail:12 skip:1103 time:9622s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_316/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx