Skip to contentSkip to conversation

flatbuffers: new package

PATCH New Erik Tideman 2 participants 2 messages Sep 18, 2017 – Oct 10, 2017

lore
Share & tools
lore

Erik Tideman

author
#0 lore raw

PATCH 1/1 flatbuffers: new package

---
 DEVELOPERS                           |  3 +++
 package/Config.in                    |  1 +
 package/flatbuffers/Config.in        | 13 +++++++++++++
 package/flatbuffers/flatbuffers.hash |  2 ++
 package/flatbuffers/flatbuffers.mk   | 23 +++++++++++++++++++++++
 5 files changed, 42 insertions(+)
 create mode 100644 package/flatbuffers/Config.in
 create mode 100644 package/flatbuffers/flatbuffers.hash
 create mode 100644 package/flatbuffers/flatbuffers.mk
DEVELOPERS +3 -0
index 21eafc9..bfac488 100644
@@ -533,6 +533,9 @@ F:	package/xdotool/
 N:	Erik Stromdahl <[email protected]>
 F:	package/mxsldr/
 
+N:	Erik Tideman <[email protected]>
+F:	package/flatbuffers/
+
 N:	Ernesto L. Williams Jr <[email protected]>
 F:	package/szip/
package/Config.in +1 -0
index 48d1381..991a565 100644
@@ -1412,6 +1412,7 @@ menu "Other"
 	source "package/elfutils/Config.in"
 	source "package/fftw/Config.in"
 	source "package/flann/Config.in"
+	source "package/flatbuffers/Config.in"
 	source "package/gflags/Config.in"
 	source "package/glibmm/Config.in"
 	source "package/glm/Config.in"
package/flatbuffers/Config.in new file +13 -0
new file mode 100644
index 0000000..b3a9941
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_FLATBUFFERS
+	bool "flatbuffers"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  FlatBuffers is an efficient cross platform serialization
+	  library for C++, C#, C, Go, Java, JavaScript, PHP, and
+	  Python. It was originally created at Google for game
+	  development and other performance-critical applications.
+	  It is available as Open Source on GitHub under the Apache
+	  license, v2 (see LICENSE.txt).
+
+	  https://google.github.io/flatbuffers/index.html
package/flatbuffers/flatbuffers.hash new file +2 -0
new file mode 100644
index 0000000..15deeb7
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 0f8dcdcfbbaba034756f97e4f9946a3784399b578f1b60c8deee3c85fafa3089  flatbuffers-v1.7.1.tar.gz
package/flatbuffers/flatbuffers.mk new file +23 -0
new file mode 100644
index 0000000..7e3eb36
@@ -0,0 +1,23 @@
+################################################################################
+#
+# flatbuffers
+#
+################################################################################
+
+FLATBUFFERS_VERSION = v1.7.1
+FLATBUFFERS_SITE = $(call github,google,flatbuffers,$(FLATBUFFERS_VERSION))
+FLATBUFFERS_LICENSE = Apache-2.0
+FLATBUFFERS_LICENSE_FILES = COPYING
+FLATBUFFERS_INSTALL_STAGING = YES
+
+ifeq ($(BR2_STATIC_LIBS),y)
+FLATBUFFERS_CONF_OPTS += -DFLATBUFFERS_BUILD_SHAREDLIB=OFF
+else
+FLATBUFFERS_CONF_OPTS += -DFLATBUFFERS_BUILD_SHAREDLIB=TRUE
+endif
+
+FLATBUFFERS_CONF_OPTS += \
+	-DCMAKE_CXX_FLAGS="-std=c++11" \
+	-DFLATBUFFERS_BUILD_TESTS=FALSE
+
+$(eval $(cmake-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 flatbuffers: new package

Hello,

Quoted 10 lines · Erik Tideman
---
 DEVELOPERS                           |  3 +++
 package/Config.in                    |  1 +
 package/flatbuffers/Config.in        | 13 +++++++++++++
 package/flatbuffers/flatbuffers.hash |  2 ++
 package/flatbuffers/flatbuffers.mk   | 23 +++++++++++++++++++++++
 5 files changed, 42 insertions(+)
 create mode 100644 package/flatbuffers/Config.in
 create mode 100644 package/flatbuffers/flatbuffers.hash
 create mode 100644 package/flatbuffers/flatbuffers.mk

Thanks for this contribution! Looks mostly good. However, one important thing that is missing is your Signed-off-by in the commit log. Could you resend with this added ?

Quoted 9 lines
package/flatbuffers/Config.in new file +3 -0
new file mode 100644
index 0000000..b3a9941
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_FLATBUFFERS
+	bool "flatbuffers"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # C++11

package/flatbuffers/Config.in line 13

Quoted 10 lines
package/flatbuffers/Config.in new file +10 -0
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  FlatBuffers is an efficient cross platform serialization
+	  library for C++, C#, C, Go, Java, JavaScript, PHP, and
+	  Python. It was originally created at Google for game
+	  development and other performance-critical applications.
+	  It is available as Open Source on GitHub under the Apache
+	  license, v2 (see LICENSE.txt).
+
+	  https://google.github.io/flatbuffers/index.html

You need a Config.in comment here:

comment "flatbuffers needs a toolchain w/ C++, gcc >= 4.7"

	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
Quoted 13 lines
package/flatbuffers/flatbuffers.mk new file +7 -0
new file mode 100644
index 0000000..7e3eb36
@@ -0,0 +1,23 @@
+################################################################################
+#
+# flatbuffers
+#
+################################################################################
+
+FLATBUFFERS_VERSION = v1.7.1

package/flatbuffers/flatbuffers.mk line 17

Quoted 10 lines
package/flatbuffers/flatbuffers.mk new file +10 -0
+FLATBUFFERS_SITE = $(call github,google,flatbuffers,$(FLATBUFFERS_VERSION))
+FLATBUFFERS_LICENSE = Apache-2.0
+FLATBUFFERS_LICENSE_FILES = COPYING
+FLATBUFFERS_INSTALL_STAGING = YES
+
+ifeq ($(BR2_STATIC_LIBS),y)
+FLATBUFFERS_CONF_OPTS += -DFLATBUFFERS_BUILD_SHAREDLIB=OFF
+else
+FLATBUFFERS_CONF_OPTS += -DFLATBUFFERS_BUILD_SHAREDLIB=TRUE
+endif

Using OFF and TRUE doesn't look very consistent. Can we use OFF/ON instead ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com