Skip to contentSkip to conversation

evemu: fix PATH_MAX related compile failure

PATCH Superseded Peter Seiderer 2 participants 4 messages Oct 11, 2017

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH v2 1/1 evemu: fix PATH_MAX related compile failure

Fixes [1] when building with musl:

find_event_devices.c: In function 'find_event_devices':
find_event_devices.c:60:14: error: 'PATH_MAX' undeclared (first use in this function)

   char fname[PATH_MAX];
              ^~~~~~~~

[1] http://autobuild.buildroot.net/results/607/607bb29231f80a138e1b5423bc01c89e36efe78c/

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 -> v2:
- use limits.h instead of linux/limits.h, change patch commit message, add musl reference (suggested by Arnout Vandecappelle)

---
 .../evemu/0001-Include-limits.h-for-PATH_MAX.patch | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 package/evemu/0001-Include-limits.h-for-PATH_MAX.patch
package/evemu/0001-Include-limits.h-for-PATH_MAX.patch new file +35 -0
new file mode 100644
index 0000000000..04a0cc6b9a
@@ -0,0 +1,35 @@
+From e80a13776e6d6df29fd704cd63e0744200c3df1b Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sun, 1 Oct 2017 19:54:53 +0200
+Subject: [PATCH] Include limits.h for PATH_MAX.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes the following compile failure when building with musl:
+
+  find_event_devices.c: In function ?find_event_devices?:
+  find_event_devices.c:60:14: error: ?PATH_MAX? undeclared (first use in this function)
+     char fname[PATH_MAX];
+                ^~~~~~~~
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ tools/find_event_devices.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tools/find_event_devices.c b/tools/find_event_devices.c
+index 2a43d54..3a74096 100644
+--- a/tools/find_event_devices.c
++++ b/tools/find_event_devices.c
+@@ -24,6 +24,7 @@
+ 
+ #define _GNU_SOURCE
+ #include <linux/input.h>
++#include <limits.h>
+ #include <dirent.h>
+ #include <string.h>
+ #include <stdio.h>
+-- 
+2.14.2
+
Signature · 1 line
2.14.2
Applied
#1 lore raw

PATCH v2 1/1 evemu: fix PATH_MAX related compile failure

Hello,

Quoted 10 lines · Peter Seiderer

Fixes [1] when building with musl:

find_event_devices.c: In function 'find_event_devices':
find_event_devices.c:60:14: error: 'PATH_MAX' undeclared (first use in this function)

   char fname[PATH_MAX];
              ^~~~~~~~

[1] http://autobuild.buildroot.net/results/607/607bb29231f80a138e1b5423bc01c89e36efe78c/

Signed-off-by Peter Seiderer <[email protected]>
Quoted 8 lines

---
Changes v1 -> v2:
- use limits.h instead of linux/limits.h, change patch commit message, add musl reference (suggested by Arnout Vandecappelle)

---
 .../evemu/0001-Include-limits.h-for-PATH_MAX.patch | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 package/evemu/0001-Include-limits.h-for-PATH_MAX.patch

Applied to master, thanks. Please don't forget to submit the patch upstream if not already done. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v2 1/1 evemu: fix PATH_MAX related compile failure

Hello Thomas,

Quoted 22 lines · Thomas Petazzoni

Hello,

Quoted 10 lines · Peter Seiderer

Fixes [1] when building with musl:

find_event_devices.c: In function 'find_event_devices':
find_event_devices.c:60:14: error: 'PATH_MAX' undeclared (first use in this function)

   char fname[PATH_MAX];
              ^~~~~~~~

[1] http://autobuild.buildroot.net/results/607/607bb29231f80a138e1b5423bc01c89e36efe78c/

Signed-off-by Peter Seiderer <[email protected]>
Quoted 8 lines

---
Changes v1 -> v2:
- use limits.h instead of linux/limits.h, change patch commit message, add musl reference (suggested by Arnout Vandecappelle)

---
 .../evemu/0001-Include-limits.h-for-PATH_MAX.patch | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 package/evemu/0001-Include-limits.h-for-PATH_MAX.patch
Quoted 2 lines

Applied to master, thanks. Please don't forget to submit the patch upstream if not already done. Thanks!

Upstream submit done already, see [1]...

Regards,
Peter

[1] https://lists.freedesktop.org/archives/input-tools/2017-October/001434.html

Quoted 2 lines

Thomas

#3 lore raw

PATCH v2 1/1 evemu: fix PATH_MAX related compile failure

Hello,

Quoted 4 lines · Peter Seiderer
Quoted 2 lines

Applied to master, thanks. Please don't forget to submit the patch upstream if not already done. Thanks!

Upstream submit done already, see [1]...

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com