ACPI: mark expected switch fall-throughs

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 12, 2017 ACPI

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-10-12 18:49 UTC #0 lore raw

PATCH 1/1 ACPI: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
This code was tested by compilation only (GCC 7.2.0 was used). Please, verify if the actual intention of the code is to fall through.

 drivers/acpi/ac.c             | 1 +
 drivers/acpi/acpi_processor.c | 1 +
 drivers/acpi/dock.c           | 1 +
 drivers/acpi/resource.c       | 1 +
 4 files changed, 4 insertions(+)

drivers/acpi/ac.c +1 -0

index 8f52483..47a7ed5 100644
@@ -265,6 +265,7 @@ static void acpi_ac_notify(struct acpi_device *device, u32 event)
 	default:
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 				  "Unsupported event [0x%x]\n", event));
+	/* fall through */
 	case ACPI_AC_NOTIFY_STATUS:
 	case ACPI_NOTIFY_BUS_CHECK:
 	case ACPI_NOTIFY_DEVICE_CHECK:

drivers/acpi/acpi_processor.c +1 -0

index 86c1059..449d86d 100644
@@ -82,6 +82,7 @@ static int acpi_processor_errata_piix4(struct pci_dev *dev)
 		 * PIIX4 models.
 		 */
 		errata.piix4.throttle = 1;
+		/* fall through*/
 
 	case 2:		/* PIIX4E */
 	case 3:		/* PIIX4M */

drivers/acpi/dock.c +1 -0

index 2305e1a..e3fc1f0 100644
@@ -482,6 +482,7 @@ int dock_notify(struct acpi_device *adev, u32 event)
 		surprise_removal = 1;
 		event = ACPI_NOTIFY_EJECT_REQUEST;
 		/* Fall back */
+		/* fall through */
 	case ACPI_NOTIFY_EJECT_REQUEST:
 		begin_undock(ds);
 		if ((immediate_undock && !(ds->flags & DOCK_IS_ATA))

drivers/acpi/resource.c +1 -0

index d85e010..316a0fc 100644
@@ -381,6 +381,7 @@ unsigned int acpi_dev_get_irq_type(int triggering, int polarity)
 	case ACPI_ACTIVE_BOTH:
 		if (triggering == ACPI_EDGE_SENSITIVE)
 			return IRQ_TYPE_EDGE_BOTH;
+		/* fall through */
 	default:
 		return IRQ_TYPE_NONE;
 	}

Signature · 1 line

2.7.4