Skip to contentSkip to conversation

gpio-rcar: use devm_ioremap_resource()

PATCH In review Sergei Shtylyov 2 participants 3 messages Oct 12, 2017 – Oct 31, 2017

Subsystems (2)
GPIO Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/1 gpio-rcar: use devm_ioremap_resource()

Using devm_ioremap_resource() has several advantages over devm_ioremap():
- it checks the passed resource's validity;
- it calls devm_request_mem_region() to check for the resource overlap;
- it prints an error message in case of error.

We can call devm_ioremap_resource() instead of devm_ioremap_nocache() as ioremap() and ioremap_nocache() are implemented identically on ARM. Doing this saves 2 LoCs and 80 bytes (AArch64 gcc 4.8.5).

Signed-off-by Sergei Shtylyov <[email protected]>

---
The patch is against the 'devel' branch of Linus Walleij's 'linux-gpio.git' repo.

 drivers/gpio/gpio-rcar.c |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/gpio/gpio-rcar.c +6 -8
Index: linux-gpio/drivers/gpio/gpio-rcar.c
===================================================================
@@ -452,19 +452,17 @@ static int gpio_rcar_probe(struct platfo
 
 	pm_runtime_enable(dev);
 
-	io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-
-	if (!io || !irq) {
-		dev_err(dev, "missing IRQ or IOMEM\n");
+	if (!irq) {
+		dev_err(dev, "missing IRQ\n");
 		ret = -EINVAL;
 		goto err0;
 	}
 
-	p->base = devm_ioremap_nocache(dev, io->start, resource_size(io));
-	if (!p->base) {
-		dev_err(dev, "failed to remap I/O memory\n");
-		ret = -ENXIO;
+	io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	p->base = devm_ioremap_resource(dev, io);
+	if (IS_ERR(p->base)) {
+		ret = PTR_ERR(p->base);
 		goto err0;
 	}
#2 lore raw
In reply to Sergei Shtylyov
Quoted 10 lines · Sergei Shtylyov

Using devm_ioremap_resource() has several advantages over devm_ioremap():
- it checks the passed resource's validity;
- it calls devm_request_mem_region() to check for the resource overlap;
- it prints an error message in case of error.

We can call devm_ioremap_resource() instead of devm_ioremap_nocache() as ioremap() and ioremap_nocache() are implemented identically on ARM. Doing this saves 2 LoCs and 80 bytes (AArch64 gcc 4.8.5).

Signed-off-by Sergei Shtylyov <[email protected]>

Patch applied with Geert's review tag.

Sorry for delay, too busy as always.

Yours,
Linus Walleij