drm: Replace kzalloc with kcalloc
Subsystems (2)
PATCH 1/1 drm: Replace kzalloc with kcalloc
Prefer kcalloc over kzalloc to allocate an array.
This patch fixes checkcpatch issue.
--- drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_crtc_helper.c +2 -2
@@ -562,12 +562,12 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set,* Allocate space for the backup of all (non-pointer) encoder and * connector data. */ - save_encoder_crtcs =kzalloc (dev->mode_config.num_encoder * + save_encoder_crtcs =kcalloc (dev->mode_config.num_encoder *sizeof (struct drm_crtc *),GFP_KERNEL );if (!save_encoder_crtcs)return -ENOMEM ; - save_connector_encoders =kzalloc (dev->mode_config.num_connector * + save_connector_encoders =kcalloc (dev->mode_config.num_connector *sizeof (struct drm_encoder *),GFP_KERNEL );if (!save_connector_encoders) {kfree (save_encoder_crtcs);
drivers/gpu/drm/drm_fb_helper.c +1 -1
@@ -2266,7 +2266,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,if (modes[n] ==NULL )return best_score; - crtcs =kzalloc (fb_helper->connector_count * + crtcs =kcalloc (fb_helper->connector_count *sizeof (struct drm_fb_helper_crtc *),GFP_KERNEL );if (!crtcs)return best_score;
drivers/gpu/drm/drm_plane_helper.c +1 -1
@@ -354,7 +354,7 @@ int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,/* Find current connectors for CRTC */ num_connectors =get_connectors_for_crtc (crtc,NULL ,0 );BUG_ON (num_connectors ==0 ); - connector_list =kzalloc (num_connectors *sizeof (*connector_list), + connector_list =kcalloc (num_connectors *sizeof (*connector_list),GFP_KERNEL );if (!connector_list)return -ENOMEM ;
Signature · 1 line
2.11.0
Quoted 15 lines · Harsha Sharma
Prefer kcalloc over kzalloc to allocate an array.
This patch fixes checkcpatch issue.Signed-off-by Harsha Sharma <[email protected]>--- drivers/gpu/drm/drm_crtc_helper.c | 4 ++-- drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/gpu/drm/drm_plane_helper.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_crtc_helper.c +0
-0
drivers/gpu/drm/drm_crtc_helper.c int drm_crtc_helper_set_config(struct drm_mode_set *set, · line 566
Quoted 6 lines
drivers/gpu/drm/drm_crtc_helper.c +1
-1@@ -562,12 +562,12 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set,* Allocate space for the backup of all (non-pointer) encoder and * connector data. */ - save_encoder_crtcs =kzalloc (dev->mode_config.num_encoder * + save_encoder_crtcs =kcalloc (dev->mode_config.num_encoder *sizeof (struct drm_crtc *),GFP_KERNEL );
Doesn't kcalloc take 3 arguments? You need to compile the code and check that you have obtained a .o file for the file you modified.
julia
Quoted 44 lines
drivers/gpu/drm/drm_crtc_helper.c +1
-1if (!save_encoder_crtcs)return -ENOMEM ; - save_connector_encoders =kzalloc (dev->mode_config.num_connector * + save_connector_encoders =kcalloc (dev->mode_config.num_connector *sizeof (struct drm_encoder *),GFP_KERNEL );if (!save_connector_encoders) {kfree (save_encoder_crtcs);drivers/gpu/drm/drm_fb_helper.c +1
-1@@ -2266,7 +2266,7 @@ static int drm_pick_crtcs(struct drm_fb_helper *fb_helper,if (modes[n] ==NULL )return best_score; - crtcs =kzalloc (fb_helper->connector_count * + crtcs =kcalloc (fb_helper->connector_count *sizeof (struct drm_fb_helper_crtc *),GFP_KERNEL );if (!crtcs)return best_score;drivers/gpu/drm/drm_plane_helper.c +1
-2@@ -354,7 +354,7 @@ int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,/* Find current connectors for CRTC */ num_connectors =get_connectors_for_crtc (crtc,NULL ,0 );BUG_ON (num_connectors ==0 ); - connector_list =kzalloc (num_connectors *sizeof (*connector_list), + connector_list =kcalloc (num_connectors *sizeof (*connector_list),GFP_KERNEL );if (!connector_list)return -ENOMEM ; --2.11.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171012221758.512-1-harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.