nfp: Explicitly include linux/bug.h

PATCH Applied Mark Brown 3 participants 3 messages Oct 13, 2017 – Oct 15, 2017

Subsystems (3)

Networking Network drivers Netronome Ethernet drivers

lore

Share & tools

lore

Mark Brown

author

2017-10-13 02:50 UTC #0 lore raw

PATCH 1/1 nfp: Explicitly include linux/bug.h

Today's -next build encountered an error due to a missing definition of WARN_ON(), caused by some header reorganization removing an implicit inclusion of linux/bug.h. Fix this with an explicit inclusion.

Signed-off-by Mark Brown <[email protected]>

---
 drivers/net/ethernet/netronome/nfp/nfp_app.c | 1 +
 drivers/net/ethernet/netronome/nfp/nfp_asm.h | 1 +
 2 files changed, 2 insertions(+)

drivers/net/ethernet/netronome/nfp/nfp_app.c +1 -0

index 82c290763529..5d9e2eba5b49 100644
@@ -31,6 +31,7 @@
  * SOFTWARE.
  */
 
+#include <linux/bug.h>
 #include <linux/skbuff.h>
 #include <linux/slab.h>

drivers/net/ethernet/netronome/nfp/nfp_asm.h +1 -0

index c4c18dd5630a..aa397bf308e4 100644
@@ -35,6 +35,7 @@
 #define __NFP_ASM_H__ 1
 
 #include <linux/bitfield.h>
+#include <linux/bug.h>
 #include <linux/types.h>
 
 #define REG_NONE	0

Signature · 1 line

2.14.1

Jakub Kicinski

Acked-by on v1 1/1

2017-10-13 03:16 UTC #1 lore raw

Quoted 5 lines · Mark Brown

Today's -next build encountered an error due to a missing definition of WARN_ON(), caused by some header reorganization removing an implicit inclusion of linux/bug.h. Fix this with an explicit inclusion.
Signed-off-by Mark Brown <[email protected]>

Acked-by Jakub Kicinski <[email protected]>

Thank you!

David Miller

maintainer Applied

2017-10-15 01:31 UTC #2 lore raw

In reply to Mark Brown

From: Mark Brown <[email protected]>
Date: Fri, 13 Oct 2017 03:50:35 +0100

Quoted 5 lines

Today's -next build encountered an error due to a missing definition of WARN_ON(), caused by some header reorganization removing an implicit inclusion of linux/bug.h. Fix this with an explicit inclusion.
Signed-off-by Mark Brown <[email protected]>

Applied, thanks Mark.