Skip to contentSkip to conversation

ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file

PATCH New Marco Franchi 2 participants 5 messages Sep 25, 2017 – Oct 13, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file

The following build warnings are seen with W=1:

warning: no previous prototype for ?mx31moboard_devboard_init? [-Wmissing-prototypes] void __init mx31moboard_devboard_init(void)
warning: no previous prototype for ?mx31moboard_marxbot_init? [-Wmissing-prototypes] void __init mx31moboard_marxbot_init(void)

Fix these warnings by including "board-mx31moboard.h".

---
 arch/arm/mach-imx/mx31moboard-devboard.c | 1 +
 arch/arm/mach-imx/mx31moboard-marxbot.c  | 1 +
 2 files changed, 2 insertions(+)
arch/arm/mach-imx/mx31moboard-devboard.c +1 -0
index 1e91a09..3c224f4 100644
@@ -22,6 +22,7 @@
 
 #include <linux/usb/otg.h>
 
+#include "board-mx31moboard.h"
 #include "common.h"
 #include "devices-imx31.h"
 #include "ehci.h"
arch/arm/mach-imx/mx31moboard-marxbot.c +1 -0
index 922d491..9a5a869 100644
@@ -24,6 +24,7 @@
 
 #include <linux/usb/otg.h>
 
+#include "board-mx31moboard.h"
 #include "common.h"
 #include "devices-imx31.h"
 #include "ehci.h"
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/4 ARM: imx: 3ds-debugboard: Include "3ds_debugboard.h" header file

The following build warning is seen with W=1:

warning: no previous prototype for ?mxc_expio_init? [-Wmissing-prototypes] int __init mxc_expio_init(u32 base, u32 intr_gpio)

Fix this warning by including "3ds_debugboard.h".

---
 arch/arm/mach-imx/3ds_debugboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/3ds_debugboard.c +1 -1
index cda330c..0015abe 100644
@@ -20,7 +20,7 @@
 #include <linux/smsc911x.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/fixed.h>
-
+#include "3ds_debugboard.h"
 #include "hardware.h"
 
 /* LAN9217 ethernet base address */
Signature · 1 line
2.7.4
#2 lore raw

PATCH 3/4 ARM: imx: cpuidle-imx5: Include "cpuidle.h" header file

In reply to Marco Franchi

The following build warning is seen with W=1:

warning: no previous prototype for ?imx5_cpuidle_init? [-Wmissing-prototypes] int __init imx5_cpuidle_init(void)

Fix this warning by including "cpuidle.h".

---
 arch/arm/mach-imx/cpuidle-imx5.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-imx/cpuidle-imx5.c +1 -0
index 3feca52..db01276 100644
@@ -9,6 +9,7 @@
 #include <linux/cpuidle.h>
 #include <linux/module.h>
 #include <asm/system_misc.h>
+#include "cpuidle.h"
 
 static int imx5_cpuidle_enter(struct cpuidle_device *dev,
 			      struct cpuidle_driver *drv, int index)
Signature · 1 line
2.7.4
#3 lore raw

PATCH 4/4 ARM: imx: mach-mx31lite: Make mx31lite_map_io static

In reply to Marco Franchi

The following build warning is seen with W=1:

warning: no previous prototype for ?mx31lite_map_io? [-Wmissing-prototypes] void __init mx31lite_map_io(void)

This function is only used in this file so make it "static".

---
 arch/arm/mach-imx/mach-mx31lite.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/mach-mx31lite.c +1 -1
index f033a57..a3250bc 100644
@@ -245,7 +245,7 @@ static struct map_desc mx31lite_io_desc[] __initdata = {
 /*
  * Set up static virtual mappings.
  */
-void __init mx31lite_map_io(void)
+static void __init mx31lite_map_io(void)
 {
 	mx31_map_io();
 	iotable_init(mx31lite_io_desc, ARRAY_SIZE(mx31lite_io_desc));
Signature · 1 line
2.7.4
Applied
#4 lore raw

PATCH 1/4 ARM: imx: imx31moboard: Include "board-mx31moboard.h" header file

In reply to Marco Franchi
Quoted 10 lines · Marco Franchi

The following build warnings are seen with W=1:

warning: no previous prototype for ?mx31moboard_devboard_init? [-Wmissing-prototypes] void __init mx31moboard_devboard_init(void)
warning: no previous prototype for ?mx31moboard_marxbot_init? [-Wmissing-prototypes] void __init mx31moboard_marxbot_init(void)

Fix these warnings by including "board-mx31moboard.h".

Applied all, thanks.