prelink: fix upstream version check
PATCH 1/1 prelink: fix upstream version check
Instead of reporting that we can update to a bogus version report that upstream version is not known.
--- meta/recipes-devtools/prelink/prelink_git.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-devtools/prelink/prelink_git.bb +2 -0
@@ -32,6 +32,8 @@ SRC_URI = "git://git.yoctoproject.org/prelink-cross.git;branch=cross_prelink \ file://prelink.cron.daily \ file://prelink.default \ file://macros.prelink" +UPSTREAM_CHECK_GITTAGREGEX = "upstream has no usable tags" +UPSTREAM_VERSION_UNKNOWN = "1" TARGET_OS_ORIG := "${TARGET_OS}" OVERRIDES_append = ":${TARGET_OS_ORIG}"
Signature · 1 line
2.14.1
Quoted 2 lines · Alexander Kanavin
Instead of reporting that we can update to a bogus version report that upstream version is not known.
You do know that there are release branches for prelink right?
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/refs/heads
cross_prelink and master are both 'release' quality branches.
Anything put there is a new version.
There is nothing for us to 'tag', since there are no formal versions.
Should be easy enough for the system to compare the SRCREV to the top of cross_prelink. If they don't match, an upgrade is needed.
--Mark
Quoted 19 lines
Signed-off-by Alexander Kanavin <[email protected]>--- meta/recipes-devtools/prelink/prelink_git.bb | 2 ++ 1 file changed, 2 insertions(+)meta/recipes-devtools/prelink/prelink_git.bb +2
-0@@ -32,6 +32,8 @@ SRC_URI = "git://git.yoctoproject.org/prelink-cross.git;branch=cross_prelink \ file://prelink.cron.daily \ file://prelink.default \ file://macros.prelink" +UPSTREAM_CHECK_GITTAGREGEX = "upstream has no usable tags" +UPSTREAM_VERSION_UNKNOWN = "1" TARGET_OS_ORIG := "${TARGET_OS}" OVERRIDES_append = ":${TARGET_OS_ORIG}"
Quoted 10 lines · Mark Hatle
Quoted 2 lines · Alexander Kanavin
Instead of reporting that we can update to a bogus version report that upstream version is not known.
You do know that there are release branches for prelink right?
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/refs/heads
cross_prelinkand master are both 'release' quality branches.
Quoted 8 lines
Anything put there is a new version.
There is nothing for us to 'tag', since there are no formal versions.
Should be easy enough for the system to compare the SRCREV to the top of
cross_prelink. If they don't match, an upgrade is needed.
The system currently supports only comparing tags, not comparing commits. I've filed a bug for it long time ago:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=8133
and no progress happened. In the meantime, for projects where commit == release, the best we can do is to mark them as 'upstream version cannot be established'. For prelink, also an exclusion of a bogus tag is needed, so you, as the maintainer, won't get reminders to update to it.
Alex
Quoted 23 lines · Alexander Kanavin
Quoted 10 lines · Mark Hatle
Quoted 2 lines · Alexander Kanavin
Instead of reporting that we can update to a bogus version report that upstream version is not known.
You do know that there are release branches for prelink right?
http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/refs/heads
cross_prelinkand master are both 'release' quality branches.Quoted 8 lines
Anything put there is a new version.
There is nothing for us to 'tag', since there are no formal versions.
Should be easy enough for the system to compare the SRCREV to the top of
cross_prelink. If they don't match, an upgrade is needed.The system currently supports only comparing tags, not comparing commits. I've filed a bug for it long time ago:
Quoted 6 lines
https://bugzilla.yoctoproject.org/show_bug.cgi?id=8133
and no progress happened. In the meantime, for projects where commit == release, the best we can do is to mark them as 'upstream version cannot be established'. For prelink, also an exclusion of a bogus tag is needed, so you, as the maintainer, won't get reminders to update to it.
didn't realize this hadn't been implemented in the system yet. Definitely something that should be.
--Mark
Quoted 2 lines
Alex