Skip to contentSkip to conversation

ifupdown-scripts: Stop installing .empty files.

PATCH New Cam Hutchison 3 participants 3 messages Oct 15, 2017 – Oct 17, 2017

lore
Share & tools
lore

Cam Hutchison

author
#0 lore raw

PATCH 1/1 ifupdown-scripts: Stop installing .empty files.

ifupdown-scripts has some .empty files to maintain empty directories in git. Previously this package used to be part of the skeleton which used SYSTEM_RSYNC to copy the directories to the target. When it was split into a separate package, cp -a was used to do the copy instead, which copies the .empty files.

Change to SYSTEM_RSYNC which excludes .empty files.

Signed-off-by Cam Hutchison <[email protected]>
---
 package/ifupdown-scripts/ifupdown-scripts.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/ifupdown-scripts/ifupdown-scripts.mk +1 -1
index 317c8f49bf..ebc89b3872 100644
@@ -31,7 +31,7 @@ endif
 
 define IFUPDOWN_SCRIPTS_INSTALL_TARGET_CMDS
 	mkdir -p $(TARGET_DIR)/etc/network
-	cp -a $(IFUPDOWN_SCRIPTS_PKGDIR)/network/* $(TARGET_DIR)/etc/network
+	$(call SYSTEM_RSYNC,$(IFUPDOWN_SCRIPTS_PKGDIR)/network,$(TARGET_DIR)/etc/network)
 	$(IFUPDOWN_SCRIPTS_LOCALHOST)
 	$(IFUPDOWN_SCRIPTS_DHCP)
 endef
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH 1/1 ifupdown-scripts: Stop installing .empty files.

Hello,

Quoted 6 lines · Cam Hutchison

ifupdown-scripts has some .empty files to maintain empty directories in git. Previously this package used to be part of the skeleton which used SYSTEM_RSYNC to copy the directories to the target. When it was split into a separate package, cp -a was used to do the copy instead, which copies the .empty files.

Quoted 6 lines

Change to SYSTEM_RSYNC which excludes .empty files.

Signed-off-by Cam Hutchison <[email protected]>
---
 package/ifupdown-scripts/ifupdown-scripts.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ifupdown-scripts: Stop installing .empty files.

In reply to Cam Hutchison
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Cam" == Cam Hutchison <[email protected]> writes:

ifupdown-scripts has some .empty files to maintain empty directories in git. Previously this package used to be part of the skeleton which used SYSTEM_RSYNC to copy the directories to the target. When it was split into a separate package, cp -a was used to do the copy instead, which copies the .empty files.

Change to SYSTEM_RSYNC which excludes .empty files.

Signed-off-by Cam Hutchison <[email protected]>

Committed to 2017.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard