Skip to contentSkip to conversation

ASoC: Intel: Skylake: Decrease loglevel for topology loading

PATCH In review Chintan Patel 2 participants 2 messages Oct 12, 2017 – Oct 16, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: Intel: Skylake: Decrease loglevel for topology loading

In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin".

Hence to convey proper message, changing log level and message.

---
Changes in v2:
Addressing review comments from Takashi Iwai by changing loglevel as info

sound/soc/intel/skylake/skl-topology.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/skylake/skl-topology.c +1 -1
index 22f768ca3c73..12f383fd7c39 100644
@@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
 
 	ret = request_firmware(&fw, skl->tplg_name, bus->dev);
 	if (ret < 0) {
-		dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+		dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
 				skl->tplg_name, ret);
 		ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
 		if (ret < 0) {
Signature · 1 line
1.9.1
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · Chintan Patel

In case of failure in loading customize topology firmware, dfw_sst.bin gets loaded. However, current log provides this message as error even after successfully falling back to default topology "dfw_sst.bin".

Hence to convey proper message, changing log level and message.

Quoted 25 lines

---
Changes in v2:
Addressing review comments from Takashi Iwai by changing loglevel as info

sound/soc/intel/skylake/skl-topology.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/skylake/skl-topology.c +1 -1
index 22f768ca3c73..12f383fd7c39 100644
@@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
 
 	ret = request_firmware(&fw, skl->tplg_name, bus->dev);
 	if (ret < 0) {
-		dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+		dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
 				skl->tplg_name, ret);
 		ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
 		if (ret < 0) {
Signature · 1 line
1.9.1
Signature · 1 line
~Vinod