drm/i915/cnl: DDIA Lane capability bit not set in clone mode
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915/cnl: DDIA Lane capability bit not set in clone mode
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_ddi.c +3 -2
@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations. */ -if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ; max_lanes =4 ; }
Signature · 6 lines
2.13.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/cnl: DDIA Lane capability bit not set in clone mode (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915/cnl: DDIA Lane capability bit not set in clone mode (rev2)
URL : https://patchwork.freedesktop.org/series/28204/
State : success
== Summary ==
Series 28204v2 drm/i915/cnl: DDIA Lane capability bit not set in clone mode
https://patchwork.freedesktop.org/api/1.0/series/28204/revisions/2/mbox/
Test gem_sync:
Subgroup basic-store-all:
pass -> FAIL (fi-ivb-3520m) fdo#100007fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:438s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:454s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:369s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:527s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:264s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:497s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:491s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:496s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:476s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:419s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:249s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:574s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:422s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:428s fi-ivb-3520m total:289 pass:259 dwarn:0 dfail:0 fail:1 skip:29 time:489s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:492s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:576s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:475s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:582s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:545s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:449s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:646s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:526s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:492s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:455s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:577s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:421s
0673a9da7359e1575ac4581254110a0b4bc06c96 drm-tip: 2017y-10m-16d-20h-13m-40s UTC integration manifest 21b047663119 drm/i915/cnl: DDIA Lane capability bit not set in clone mode
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6060/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 6 lines · Rodrigo Vivi
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
Please be more specific about what you mean with clone mode.
Quoted 13 lines
Cc Mika Kahola <[email protected]>Signed-off-by Clint Taylor <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_ddi.c +0
-0
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) · line 2793
Quoted 3 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations. */
The comment above needs updating too. Also, it doesn't say anything about cloning.
BR,
Jani.
Quoted 9 lines
drivers/gpu/drm/i915/intel_ddi.c +3
-2-if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ; max_lanes =4 ; }
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 9 lines · Jani Nikula
Quoted 6 lines · Rodrigo Vivi
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
Please be more specific about what you mean with clone mode.
Oh... yes, we need to change the comment.
I didn't see any relation here to the clone mode.
If eDP comes back on boot and HDMI comes later everything worked.
If HDMI is also present during boot at some point during initialization we have probably a long pulse on edp that hits our check of max_level and change that to 2, because this bit is unset as we were expecting.
I will grab more information here on the flow and proper update the commit message.
Quoted 9 lines
Quoted 9 lines
Cc Mika Kahola <[email protected]>Signed-off-by Clint Taylor <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 11 lines
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) · line 2793
Quoted 8 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations. */ The comment above needs updating too. Also, it doesn't say anything about cloning.
I will update this comment also. But also not related to clone mode I believe.
Quoted 4 lines
BR,
Jani.
Quoted 12 lines
Quoted 9 lines
drivers/gpu/drm/i915/intel_ddi.c +3
-2-if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ; max_lanes =4 ; }Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 21 lines · Rodrigo Vivi
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
Cc Mika Kahola <[email protected]>Signed-off-by Clint Taylor <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_ddi.c +0
-0@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations.
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) · line 2800
Quoted 10 lines
drivers/gpu/drm/i915/intel_ddi.c +3
-2*/ -if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ; max_lanes =4 ; }
CNL has DDI E so this doesn't make sense. If there are CNLs out there that don't actually use DDI E but forget to configure the bifurcation coreectly, then we'll need a fancier way to detect that. Ie. we need to be sure DDI E isn't going to be used before we can force DDI A to use 4 lanes.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 30 lines · Ville Syrjälä
Quoted 29 lines · Rodrigo Vivi
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
Cc Mika Kahola <[email protected]>Signed-off-by Clint Taylor <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_ddi.c +3
-2@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations. */ -if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ;
Quoted 8 lines
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) · line 2800
Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0max_lanes =4 ; }CNL has DDI E so this doesn't make sense. If there are CNLs out there that don't actually use DDI E but forget to configure the bifurcation coreectly, then we'll need a fancier way to detect that. Ie. we need to be sure DDI E isn't going to be used before we can force DDI A to use 4 lanes.
Oh, we'd really need some way to make sure all four lanes from DDI A are really connected to the panel. Otherwise link training would surely fail if we try to use four lanes.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 30 lines · Ville Syrjälä
Quoted 29 lines · Rodrigo Vivi
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
Cc Mika Kahola <[email protected]>Signed-off-by Clint Taylor <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_ddi.c +3
-2@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations. */ -if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ;
Quoted 8 lines
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) · line 2800
Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0max_lanes =4 ; }CNL has DDI E so this doesn't make sense. If there are CNLs out there that don't actually use DDI E but forget to configure the bifurcation coreectly, then we'll need a fancier way to detect that. Ie. we need to be sure DDI E isn't going to be used before we can force DDI A to use 4 lanes.
We got the confirmation that DDI E is not there for any of the current SKUs what support is currently merged.
DDI E is only available on the SKUs that posted yesterday... the one that supports DDI F that is the proper split. Also when DDI F is in use DDI E cannot be used because the interrupts handling.
So apparently this is not going to be used at all. But I agree that it would be good if we could have a smarter way to detect it... Any idea?
Thanks,
Rodrigo.
Quoted 4 lines
Signature · 3 lines
-- Ville Syrjälä Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 43 lines · Rodrigo Vivi
Quoted 30 lines · Ville Syrjälä
Quoted 29 lines · Rodrigo Vivi
From: Clint Taylor <[email protected]>
DDIA Lane capability control 4 lane bit is not being set by firmware during clone mode boot. This occurs when multiple monitors are connected during boot. The driver will configure the port for 2 lane maximum width if this bit is not set.
Cc Mika Kahola <[email protected]>Signed-off-by Clint Taylor <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_ddi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_ddi.c +3
-2@@ -2791,9 +2791,10 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)* configuration so that we use the proper lane count for our * calculations. */ -if (IS_GEN9_LP (dev_priv) && port ==PORT_A ) { +if ((IS_GEN9_LP (dev_priv) ||IS_CANNONLAKE (dev_priv)) && + port ==PORT_A ) {if (!(intel_dig_port->saved_port_bits &DDI_A_4_LANES )) { -DRM_DEBUG_KMS ("BXT BIOS forgot to set DDI_A_4_LANES for port A; fixing\n" ); +DRM_DEBUG_KMS ("BIOS forgot to set DDI_A_4_LANES for port A\n" ); intel_dig_port->saved_port_bits |=DDI_A_4_LANES ;Quoted 8 lines
drivers/gpu/drm/i915/intel_ddi.c void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port) · line 2800
Quoted 2 lines
drivers/gpu/drm/i915/intel_ddi.c +0
-0max_lanes =4 ; }CNL has DDI E so this doesn't make sense. If there are CNLs out there that don't actually use DDI E but forget to configure the bifurcation coreectly, then we'll need a fancier way to detect that. Ie. we need to be sure DDI E isn't going to be used before we can force DDI A to use 4 lanes.
We got the confirmation that DDI E is not there for any of the current SKUs what support is currently merged.
Quoted 6 lines
DDI E is only available on the SKUs that posted yesterday... the one that supports DDI F that is the proper split. Also when DDI F is in use DDI E cannot be used because the interrupts handling.
So apparently this is not going to be used at all. But I agree that it would be good if we could have a smarter way to detect it... Any idea?
Looks like DDI E doesn't have a hardware strap, so I suppose you could just check vbt.ddi_port_info. That still doesn't protect us against accidentally using 4 lanes when we should have used 2. Not sure there's anything in VBT that could help us there.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915/cnl: DDIA Lane capability bit not set in clone mode (rev2)
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915/cnl: DDIA Lane capability bit not set in clone mode (rev2)
URL : https://patchwork.freedesktop.org/series/28204/
State : failure
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbcpsr-2p-scndscrn-pri-indfb-draw-mmap-cpu:
skip -> INCOMPLETE (shard-hsw)
Test kms_flip:
Subgroup flip-vs-modeset-interruptible:
pass -> DMESG-WARN (shard-hsw) fdo#102557
Test gem_exec_params:
Subgroup invalid-bsd2-flag-on-render:
pass -> INCOMPLETE (shard-hsw)
Test perf:
Subgroup oa-exponents:
fail -> PASS (shard-hsw) fdo#102254fdo#102557 https://bugs.freedesktop.org/show_bug.cgi?id=102557
fdo#102254 https://bugs.freedesktop.org/show_bug.cgi?id=102254
shard-hsw total:2349 pass:1262 dwarn:1 dfail:0 fail:9 skip:978 time:8125s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6060/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx