ext4: Convert timers to use timer_setup()

PATCH Applied Kees Cook 2 participants 2 messages Oct 17, 2017 – Oct 18, 2017 ext4 file system

Share & tools

Kees Cook

author

2017-10-17 00:00 UTC #0 lore raw

PATCH 1/1 ext4: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly.

Cc "Theodore Ts'o" <[email protected]>

Cc Andreas Dilger <[email protected]>

Cc [email protected]

Signed-off-by Kees Cook <[email protected]>

Reviewed-by Reviewed-by: Jan Kara <[email protected]>

---
 fs/ext4/super.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

fs/ext4/super.c +1 -4

index b5d393321b7b..759281cec51f 100644
@@ -2793,14 +2793,11 @@ static int ext4_feature_set_ok(struct super_block *sb, int readonly)
  * This function is called once a day if we have errors logged
  * on the file system
  */
-static void print_daily_error_info(unsigned long arg)
+static void print_daily_error_info(struct timer_list *t)
 {
-	struct super_block *sb = (struct super_block *) arg;
-	struct ext4_sb_info *sbi;
-	struct ext4_super_block *es;

Theodore Ts'o

maintainer Applied

2017-10-18 16:46 UTC #1 lore raw

Quoted 9 lines · Kees Cook

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly.
Cc "Theodore Ts'o" <[email protected]>
Cc Andreas Dilger <[email protected]>
Cc [email protected]
Signed-off-by Kees Cook <[email protected]>
Reviewed-by Reviewed-by: Jan Kara <[email protected]>

Applied, thanks.

- Ted