Skip to contentSkip to conversation

iso: Reduce verbosity on test and info calls

PATCH New Alexander Graf 2 participants 2 messages Oct 6, 2017 – Oct 17, 2017

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iso: Reduce verbosity on test and info calls

The test and info callbacks into the partition callback struct are used by the "part list" command on the command line. That command is used by the distro script.

With verb=1 set, "part list" thus throws a lot of warnings about partitions it can't find when an upper layer searches for partitions.

So let's reduce verbosity to bring it to the same level of noise as the other partition targets.

---

v1 -> v2:

- Also silence the info callback

---
 disk/part_iso.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
disk/part_iso.c +2 -2
index 8aef251f4e..4036b00b25 100644
@@ -202,7 +202,7 @@ found:
 static int part_get_info_iso(struct blk_desc *dev_desc, int part_num,
 				  disk_partition_t *info)
 {
-	return part_get_info_iso_verb(dev_desc, part_num, info, 1);
+	return part_get_info_iso_verb(dev_desc, part_num, info, 0);
 }
 
 static void part_print_iso(struct blk_desc *dev_desc)
@@ -228,7 +228,7 @@ static int part_test_iso(struct blk_desc *dev_desc)
 {
 	disk_partition_t info;
 
-	return part_get_info_iso_verb(dev_desc, 1, &info, 1);
+	return part_get_info_iso_verb(dev_desc, 1, &info, 0);
 }
 
 U_BOOT_PART_TYPE(iso) = {
Signature · 1 line
2.12.3
#1 lore raw

PATCH v2 1/1 iso: Reduce verbosity on test and info calls

Quoted 11 lines · Alexander Graf

The test and info callbacks into the partition callback struct are used by the "part list" command on the command line. That command is used by the distro script.

With verb=1 set, "part list" thus throws a lot of warnings about partitions it can't find when an upper layer searches for partitions.

So let's reduce verbosity to bring it to the same level of noise as the other partition targets.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171016/b50b3333/attachment.sig>