Skip to contentSkip to conversation

bitbake.conf: add ssh to HOSTTOOLS_NONFATAL

PATCH In review Chen Qi 3 participants 6 messages Oct 17, 2017

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

v2 cover bitbake.conf: add ssh to HOSTTOOLS_NONFATAL

**** V2 *****
Change to keep the alphabetical order.

The following changes since commit 96967261993f8b583b51cdeccbb1fd06042d2192:

bitbake: toaster/highlight.pack.js: Fix corrupted file (2017-10-10 11:05:08 +0100)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib ChenQi/bug12227
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/bug12227

Chen Qi (1):
bitbake.conf: add ssh to HOSTTOOLS_NONFATAL

 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH v2 1/1 bitbake.conf: add ssh to HOSTTOOLS_NONFATAL

We changed to make tools required by testimage to be included conditionally. This resulted in users who use ssh for git fetching having failures.

Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.

[YOCTO #12227]

Signed-off-by Chen Qi <[email protected]>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index 0eefb86..4fba9d6 100644
@@ -487,7 +487,7 @@ HOSTTOOLS += " \
 HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
 
 # Link to these if present
-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
 
 # Temporary add few more detected in bitbake world
 HOSTTOOLS_NONFATAL += "join nl size yes zcat"
Signature · 1 line
1.9.1
#2 lore raw
Quoted 9 lines · Chen Qi

We changed to make tools required by testimage to be included conditionally. This resulted in users who use ssh for git fetching having failures.

Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.

[YOCTO #12227]

Signed-off-by Chen Qi <[email protected]>

---

1. Why don't people specify what has changed between v1 and v2 of the patch?

2. A corrected/sorted patch already went in earlier:
http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a

Quoted 24 lines
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index 0eefb86..4fba9d6 100644
@@ -487,7 +487,7 @@ HOSTTOOLS += " \
 HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
 
 # Link to these if present
-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
 
 # Temporary add few more detected in bitbake world
 HOSTTOOLS_NONFATAL += "join nl size yes zcat"
Signature · 7 lines
1.9.1

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
author
#3 lore raw
Quoted 11 lines · Denys Dmytriyenko
Quoted 9 lines · Chen Qi

We changed to make tools required by testimage to be included conditionally. This resulted in users who use ssh for git fetching having failures.

Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.

[YOCTO #12227]

Signed-off-by Chen Qi <[email protected]>

---

1. Why don't people specify what has changed between v1 and v2 of the patch?

It's in [OE-core] [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL.

Quoted 3 lines

2. A corrected/sorted patch already went in earlier:
http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a

Sorry. My carelessness.
I should have checked the latest master.

Best Regards,
Chen Qi

Quoted 25 lines
Quoted 25 lines
  meta/conf/bitbake.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index 0eefb86..4fba9d6 100644
@@ -487,7 +487,7 @@ HOSTTOOLS += " \
  HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
 
  # Link to these if present
-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
 
  # Temporary add few more detected in bitbake world
  HOSTTOOLS_NONFATAL += "join nl size yes zcat"
Signature · 7 lines
1.9.1

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#4 lore raw
Quoted 7 lines · ChenQi
Quoted 6 lines · Denys Dmytriyenko
Quoted 5 lines · Chen Qi

We changed to make tools required by testimage to be included conditionally. This resulted in users who use ssh for git fetching having failures.

Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

[YOCTO #12227]

Signed-off-by Chen Qi <[email protected]>

---

1. Why don't people specify what has changed between v1 and v2 of the patch?

It's in [OE-core] [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL.

The changelog between patch revisions?

Quoted 33 lines
Quoted 2 lines

2. A corrected/sorted patch already went in earlier:
http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a

Sorry. My carelessness.
I should have checked the latest master.

Best Regards,
Chen Qi

Quoted 23 lines
Quoted 23 lines
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/bitbake.conf +1 -1
index 0eefb86..4fba9d6 100644
@@ -487,7 +487,7 @@ HOSTTOOLS += " \
 HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
 # Link to these if present
-HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
+HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
 # Temporary add few more detected in bitbake world
 HOSTTOOLS_NONFATAL += "join nl size yes zcat"
Signature · 7 lines
1.9.1

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
#5 lore raw

✗ patchtest: failure for bitbake.conf: add ssh to HOSTTOOLS_NONFATAL

In reply to Chen Qi

== Series Details ==

Series: bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
Revision: 1
URL : https://patchwork.openembedded.org/series/9370/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 3b413a8057)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe