Skip to contentSkip to conversation

perf record: Fix documentation for a disused option '-l'

PATCH RESEND Applied Taeung Song 3 participants 3 messages Oct 13, 2017 – Oct 20, 2017 perf events

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 perf record: Fix documentation for a disused option '-l'

perf-record had a '-l' option that mean "scale counter values" very long time ago, but it currently belong to perf-stat as '-c'. So remove it. I found this problem in the below case.

    $ perf record -e cycles -l sleep 3
      Error: unknown switch `l
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/Documentation/perf-record.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-record.txt +2 -2
index 68a1ffb..5a626ef 100644
@@ -8,8 +8,8 @@ perf-record - Run a command and record its profile into perf.data
 SYNOPSIS
 --------
 [verse]
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] <command>
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] -- <command> [<options>]
+'perf record' [-e <EVENT> | --event=EVENT] [-a] <command>
+'perf record' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
 
 DESCRIPTION
 -----------
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw

Em Sat, Oct 14, 2017 at 12:10:12AM +0900, Taeung Song escreveu:

Quoted 3 lines

perf-record had a '-l' option that mean "scale counter values" very long time ago, but it currently belong to perf-stat as '-c'. So remove it. I found this problem in the below case.

Applied,

- Arnaldo

Quoted 27 lines
    $ perf record -e cycles -l sleep 3
      Error: unknown switch `l
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/Documentation/perf-record.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-record.txt +2 -2
index 68a1ffb..5a626ef 100644
@@ -8,8 +8,8 @@ perf-record - Run a command and record its profile into perf.data
 SYNOPSIS
 --------
 [verse]
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] <command>
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] -- <command> [<options>]
+'perf record' [-e <EVENT> | --event=EVENT] [-a] <command>
+'perf record' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
 
 DESCRIPTION
 -----------
Signature · 1 line
2.7.4
#2 lore raw

[tip:perf/urgent] perf record: Fix documentation for a inexistent option '-l'

In reply to Taeung Song
perf record: Fix documentation for a inexistent option '-l'
Commit-ID:  3f50f614d61f91ad30b1947c429d1f235493a7f9
Gitweb:     https://git.kernel.org/tip/3f50f614d61f91ad30b1947c429d1f235493a7f9
Author:     Taeung Song <[email protected]>
AuthorDate: Sat, 14 Oct 2017 00:10:12 +0900
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 17 Oct 2017 09:05:36 -0300

perf record: Fix documentation for a inexistent option '-l'

'perf record' had a '-l' option that meant "scale counter values" a very long time ago, but it currently belongs to 'perf stat' as '-c'. So remove it. I found this problem in the below case.

    $ perf record -e cycles -l sleep 3
      Error: unknown switch `l
---
 tools/perf/Documentation/perf-record.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/perf/Documentation/perf-record.txt +2 -2
index e397453..63526f4 100644
@@ -8,8 +8,8 @@ perf-record - Run a command and record its profile into perf.data
 SYNOPSIS
 --------
 [verse]
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] <command>
-'perf record' [-e <EVENT> | --event=EVENT] [-l] [-a] -- <command> [<options>]
+'perf record' [-e <EVENT> | --event=EVENT] [-a] <command>
+'perf record' [-e <EVENT> | --event=EVENT] [-a] -- <command> [<options>]
 
 DESCRIPTION
 -----------