Skip to contentSkip to conversation

dql: make dql_init return void

PATCH Applied Stephen Hemminger 3 participants 3 messages Oct 18, 2017 – Oct 19, 2017

Subsystems (3)
Networking Network drivers Library code
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 dql: make dql_init return void

dql_init always returned 0, and the only place that uses it in network core code didn't care about the return value anyway.

Signed-off-by Stephen Hemminger <[email protected]>
---
 include/linux/dynamic_queue_limits.h | 2 +-
 lib/dynamic_queue_limits.c           | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
include/linux/dynamic_queue_limits.h +1 -1
index a4be70398ce1..f69f98541953 100644
@@ -98,7 +98,7 @@ void dql_completed(struct dql *dql, unsigned int count);
 void dql_reset(struct dql *dql);
 
 /* Initialize dql state */
-int dql_init(struct dql *dql, unsigned hold_time);
+void dql_init(struct dql *dql, unsigned int hold_time);
 
 #endif /* _KERNEL_ */
lib/dynamic_queue_limits.c +1 -2
index f346715e2255..dbe61c4c2a97 100644
@@ -127,12 +127,11 @@ void dql_reset(struct dql *dql)
 }
 EXPORT_SYMBOL(dql_reset);
 
-int dql_init(struct dql *dql, unsigned hold_time)
+void dql_init(struct dql *dql, unsigned int hold_time)
 {
 	dql->max_limit = DQL_MAX_LIMIT;
 	dql->min_limit = 0;
 	dql->slack_hold_time = hold_time;
 	dql_reset(dql);
-	return 0;
 }
 EXPORT_SYMBOL(dql_init);
Signature · 1 line
2.11.0