drm/i915: Print the condition causing GEM_BUG_ON
Subsystems (2)
PATCH v2 1/1 drm/i915: Print the condition causing GEM_BUG_ON
It is easier to categorize and debug bugs if the failed condition is in plain sight in the actual dmesg output. Make it so.
--- drivers/gpu/drm/i915/i915_gem.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_gem.h +5 -1
@@ -28,7 +28,11 @@#include <linux/bug.h> #ifdef CONFIG_DRM_I915_DEBUG_GEM -#define GEM_BUG_ON (expr) BUG_ON(expr) +#define GEM_BUG_ON (condition) do { if (unlikely((condition))) { \ + printk(KERN_ERR "GEM_BUG_ON(%s)\n", __stringify(condition)); \ + BUG(); \ + } \ + } while(0)#define GEM_WARN_ON (expr) WARN_ON(expr)#define GEM_DEBUG_DECL (var) var
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Print the condition causing GEM_BUG_ON (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON (rev2)
URL : https://patchwork.freedesktop.org/series/32050/
State : failure
== Summary ==
Series 32050v2 drm/i915: Print the condition causing GEM_BUG_ON
https://patchwork.freedesktop.org/api/1.0/series/32050/revisions/2/mbox/
Test gem_exec_flush:
Subgroup basic-uc-set-default:
pass -> INCOMPLETE (fi-blb-e6850)
Subgroup basic-wb-ro-default:
pass -> INCOMPLETE (fi-skl-6700k)
Test gem_exec_nop:
Subgroup basic-series:
pass -> INCOMPLETE (fi-kbl-7500u)
Test gem_sync:
Subgroup basic-many-each:
pass -> INCOMPLETE (fi-kbl-7567u)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-gdg-551) fdo#102618
Subgroup basic-flip-after-cursor-varying-size:
skip -> PASS (fi-hsw-4770r)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-kbl-7560u) fdo#102846fdo#102618 https://bugs.freedesktop.org/show_bug.cgi?id=102618
fdo#102846 https://bugs.freedesktop.org/show_bug.cgi?id=102846
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:447s fi-blb-e6850 total:289 pass:33 dwarn:0 dfail:0 fail:0 skip:33 fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:526s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:263s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:500s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:491s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:498s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:475s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:560s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:420s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:250s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:424s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:431s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:490s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:465s fi-kbl-7500u total:289 pass:63 dwarn:1 dfail:0 fail:0 skip:12 fi-kbl-7560u total:246 pass:229 dwarn:0 dfail:0 fail:0 skip:16 fi-kbl-7567u total:289 pass:146 dwarn:0 dfail:0 fail:0 skip:12 fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:575s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:544s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:449s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:647s fi-skl-6700k total:230 pass:58 dwarn:0 dfail:0 fail:0 skip:12 fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:486s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:565s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:415s
fi-bdw-gvtdvm failed to connect after reboot
fi-glk-1 failed to connect after reboot
fi-skl-gvtdvm failed to connect after reboot
920fa3252916e0ec9da1df709744c568f621a43d drm-tip: 2017y-10m-17d-09h-45m-06s UTC integration manifest ea888252a173 drm/i915: Print the condition causing GEM_BUG_ON
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6070/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for drm/i915: Print the condition causing GEM_BUG_ON (rev2)
Quoting Patchwork (2017-10-17 14:28:39)
Quoted 22 lines
== Series Details ==
Series: drm/i915: Print the condition causing
GEM_BUG_ON(rev2)
URL : https://patchwork.freedesktop.org/series/32050/
State : failure== Summary ==
Series 32050v2 drm/i915: Print the condition causing
GEM_BUG_ON
https://patchwork.freedesktop.org/api/1.0/series/32050/revisions/2/mbox/Test
gem_exec_flush:Subgroup basic-uc-set-default: pass -> INCOMPLETE (fi-blb-e6850) Subgroup basic-wb-ro-default: pass -> INCOMPLETE (fi-skl-6700k) Test gem_exec_nop: Subgroup basic-series: pass -> INCOMPLETE (fi-kbl-7500u) Test gem_sync: Subgroup basic-many-each: pass -> INCOMPLETE (fi-kbl-7567u)
Quoted 8 lines
Test
kms_cursor_legacy:Subgroup basic-busy-flip-before-cursor-legacy: fail -> PASS (fi-gdg-551) fdo#102618 Subgroup basic-flip-after-cursor-varying-size: skip -> PASS (fi-hsw-4770r) Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-b: pass -> INCOMPLETE (fi-kbl-7560u) fdo#102846
Are you going to tell me all of those
watchdog: watchdog0: watchdog did not stop!
were merely coincidence? ;)
-Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Print the condition causing GEM_BUG_ON (rev2)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON (rev2)
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Series 32050v2 drm/i915: Print the condition causing GEM_BUG_ON
https://patchwork.freedesktop.org/api/1.0/series/32050/revisions/2/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-gdg-551) fdo#102618
Subgroup basic-flip-after-cursor-varying-size:
skip -> PASS (fi-hsw-4770r)fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#102618 https://bugs.freedesktop.org/show_bug.cgi?id=102618
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:448s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:456s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:371s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:524s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:263s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:492s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:488s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:497s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:475s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:560s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:418s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:250s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:582s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:419s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:431s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:488s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:463s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:476s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:570s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:474s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:576s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:552s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:451s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:642s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:516s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:495s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:452s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:557s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:428s
920fa3252916e0ec9da1df709744c568f621a43d drm-tip: 2017y-10m-17d-09h-45m-06s UTC integration manifest cf4185de816a drm/i915: Print the condition causing GEM_BUG_ON
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6074/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Print the condition causing GEM_BUG_ON (rev2)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON (rev2)
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Test kms_cursor_legacy:
Subgroup cursor-vs-flip-atomic-transitions:
fail -> PASS (shard-hsw)shard-hsw total:2502 pass:1411 dwarn:0 dfail:0 fail:10 skip:1081 time:9173s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6070/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Print the condition causing GEM_BUG_ON (rev2)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: drm/i915: Print the condition causing GEM_BUG_ON (rev2)
URL : https://patchwork.freedesktop.org/series/32050/
State : success
== Summary ==
Test kms_cursor_legacy:
Subgroup cursor-vs-flip-atomic-transitions:
fail -> PASS (shard-hsw)
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-hsw total:2553 pass:1441 dwarn:0 dfail:0 fail:9 skip:1103 time:9327s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6074/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx