Skip to contentSkip to conversation

ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property

PATCH New Fabio Estevam 2 participants 5 messages Oct 16, 2017 – Oct 18, 2017

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/4 ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property

From: Fabio Estevam <[email protected]>

The 'interrupts' property has an extra cell by mistake.

Fix this, so that the following build warning is gone:

DTC arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
arch/arm/boot/dts/imx6ul-pico-hobbit.dtb: Warning (interrupts_property): interrupts size is (12), expected multiple of 8 in /soc/aips-bus at 2000000/ethernet at 20b4000/mdio/ethernet-phy at 1

---
 arch/arm/boot/dts/imx6ul-pico-hobbit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6ul-pico-hobbit.dts +1 -1
index 7d7254b..de54c70 100644
@@ -175,7 +175,7 @@
 			reg = <1>;
 			max-speed = <100>;
 			interrupt-parent = <&gpio5>;
-			interrupts = <6 IRQ_TYPE_LEVEL_LOW 0>;
+			interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
 };
Signature · 1 line
2.7.4
author reviewer
#1 lore raw

PATCH 2/4 ARM: dts: imx6sx-softing-vining-2000: Fix the 'interrupt-parent' property

From: Fabio Estevam <[email protected]>

The correct property name is 'interrupt-parent', so fix it accordingly.

This fixes the following build warning:

arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /soc/aips-bus at 02100000/ethernet at 02188000/mdio/ethernet0-phy at 0 arch/arm/boot/dts/imx6sx-softing-vining-2000.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /soc/aips-bus at 02100000/ethernet at 021b4000/mdio/ethernet1-phy at 0

Cc Christoph Fritz <[email protected]>
---
 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts +2 -2
index ee012bc..44bfeac 100644
@@ -116,7 +116,7 @@
 		ethphy0: ethernet0-phy at 0 {
 			reg = <0>;
 			max-speed = <100>;
-			interrupts-parent = <&gpio2>;
+			interrupt-parent = <&gpio2>;
 			interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
@@ -139,7 +139,7 @@
 		ethphy1: ethernet1-phy at 0 {
 			reg = <0>;
 			max-speed = <100>;
-			interrupts-parent = <&gpio2>;
+			interrupt-parent = <&gpio2>;
 			interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
 		};
 	};
Signature · 1 line
2.7.4
author reviewer
#2 lore raw

PATCH 3/4 ARM: dts: imx35-eukrea-mbimxsd35-baseboard: Fix the 'cd-gpios' property

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

The GPIO polarity is missing in the cd-gpios property.

Fix it, so that the following build warning is gone:

DTC arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dtb: Warning (gpios_property): cd-gpios property size (8) too small for cell size 2 in /soc/aips at 53f00000/esdhc at 53fb400

---
 arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts +1 -1
index e935713..dfc7f45 100644
@@ -65,7 +65,7 @@
 &esdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_esdhc1>;
-	cd-gpios = <&gpio3 24>;
+	cd-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
Signature · 1 line
2.7.4
author reviewer
#3 lore raw

PATCH 4/4 ARM: dts: imx50: Pass the 'dma-cells' property

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

Pass the '#dma-cells' property in the sdma node, so that the following build warning is gone:

DTC arch/arm/boot/dts/imx50-evk.dtb
arch/arm/boot/dts/imx50-evk.dtb: Warning (dmas_property): Missing property '#dma-cells' in node /soc/aips at 60000000/sdma at 63fb0000 or bad phandle (referred from /soc/aips at 50000000/spba at 50000000/ssi at 50014000:dmas[0])

---
 arch/arm/boot/dts/imx50.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx50.dtsi +1 -0
index 3747d80..30edf9a 100644
@@ -443,6 +443,7 @@
 				clocks = <&clks IMX5_CLK_SDMA_GATE>,
 					 <&clks IMX5_CLK_SDMA_GATE>;
 				clock-names = "ipg", "ahb";
+				#dma-cells = <3>;
 				fsl,sdma-ram-script-name = "imx/sdma/sdma-imx50.bin";
 			};
 
Signature · 1 line
2.7.4
Applied
#4 lore raw

PATCH 1/4 ARM: dts: imx6ul-pico-hobbit: Fix the 'interrupts' property

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The 'interrupts' property has an extra cell by mistake.

Fix this, so that the following build warning is gone:

DTC arch/arm/boot/dts/imx6ul-pico-hobbit.dtb
arch/arm/boot/dts/imx6ul-pico-hobbit.dtb: Warning (interrupts_property): interrupts size is (12), expected multiple of 8 in /soc/aips-bus at 2000000/ethernet at 20b4000/mdio/ethernet-phy at 1

Applied, thanks.