Skip to contentSkip to conversation

powertop: needs autoreconf

PATCH New Baruch Siach 3 participants 5 messages Oct 18, 2017

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 powertop: needs autoreconf

Commit 01048deab60 (package/powertop: bump to version 2.9) removed autoreconf even though the remaining patch touches Makefile.am. Fix this.

Fixes:
http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/

Cc Romain Naour <[email protected]>
Cc Steven Noonan <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/powertop/powertop.mk | 2 ++
 1 file changed, 2 insertions(+)
package/powertop/powertop.mk +2 -0
index ce7a11875894..7c9c7ccc3f41 100644
@@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
 POWERTOP_LICENSE = GPL-2.0
 POWERTOP_LICENSE_FILES = COPYING
 POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
+# Patching Makefile.am
+POWERTOP_AUTORECONF = YES
 
 # Help powertop at finding the right ncurses library depending on
 # which one is available.
Signature · 1 line
2.14.2
#1 lore raw

PATCH 1/1 powertop: needs autoreconf

Hi Baruch,

Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:

Quoted 3 lines

Commit 01048deab60 (package/powertop: bump to version 2.9) removed autoreconf even though the remaining patch touches Makefile.am. Fix this.

Indeed...
I don't recall what happened, probably I had the intend to remove all patches with the version bump but I finally re-added 0001-dont-force-stack-smashing-protection.patch.

The issue appear now following the automake bump 1.15.1.

Quoted 18 lines

Fixes:
http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/

Cc Romain Naour <[email protected]>
Cc Steven Noonan <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/powertop/powertop.mk | 2 ++
 1 file changed, 2 insertions(+)
package/powertop/powertop.mk +0 -0
index ce7a11875894..7c9c7ccc3f41 100644

package/powertop/powertop.mk POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \ · line 15

Quoted 4 lines
package/powertop/powertop.mk +1 -0
@@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
 POWERTOP_LICENSE = GPL-2.0
 POWERTOP_LICENSE_FILES = COPYING
 POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
+# Patching Makefile.am

Maybe you can name the patch here
# 0001-dont-force-stack-smashing-protection.patch

package/powertop/powertop.mk POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \ · line 16

Quoted 1 line
package/powertop/powertop.mk +1 -0
+POWERTOP_AUTORECONF = YES

Gettextize was needed with powertop 2.27, can you check if it's still needed ?

Best regards,
Romain

Quoted 4 lines
package/powertop/powertop.mk +0 -0
 # Help powertop at finding the right ncurses library depending on
 # which one is available.
author
#2 lore raw

PATCH 1/1 powertop: needs autoreconf

Hi Romain,

Quoted 37 lines · Romain Naour

Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:

Quoted 3 lines

Commit 01048deab60 (package/powertop: bump to version 2.9) removed autoreconf even though the remaining patch touches Makefile.am. Fix this.

Indeed...
I don't recall what happened, probably I had the intend to remove all patches with the version bump but I finally re-added 0001-dont-force-stack-smashing-protection.patch.

The issue appear now following the automake bump 1.15.1.

Quoted 17 lines

Fixes:
http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/

Cc Romain Naour <[email protected]>
Cc Steven Noonan <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/powertop/powertop.mk | 2 ++
 1 file changed, 2 insertions(+)
package/powertop/powertop.mk +0 -0
index ce7a11875894..7c9c7ccc3f41 100644

package/powertop/powertop.mk POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \ · line 15

Quoted 4 lines
package/powertop/powertop.mk +1 -0
@@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
 POWERTOP_LICENSE = GPL-2.0
 POWERTOP_LICENSE_FILES = COPYING
 POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
+# Patching Makefile.am

Maybe you can name the patch here
# 0001-dont-force-stack-smashing-protection.patch

Quoted 3 lines

package/powertop/powertop.mk POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \ · line 16

Quoted 1 line
package/powertop/powertop.mk +1 -0
+POWERTOP_AUTORECONF = YES

Gettextize was needed with powertop 2.27, can you check if it's still needed ?

The build succeeds here without gettextize. The same config fails without the patch with the same error as the autobuilder.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 powertop: needs autoreconf

Hi Baruch,

Le 18/10/2017 ? 21:33, Baruch Siach a ?crit?:

Quoted 40 lines

Hi Romain,

Quoted 37 lines · Romain Naour

Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:

Quoted 3 lines

Commit 01048deab60 (package/powertop: bump to version 2.9) removed autoreconf even though the remaining patch touches Makefile.am. Fix this.

Indeed...
I don't recall what happened, probably I had the intend to remove all patches with the version bump but I finally re-added 0001-dont-force-stack-smashing-protection.patch.

The issue appear now following the automake bump 1.15.1.

Quoted 17 lines

Fixes:
http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/

Cc Romain Naour <[email protected]>
Cc Steven Noonan <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/powertop/powertop.mk | 2 ++
 1 file changed, 2 insertions(+)
package/powertop/powertop.mk +0 -0
index ce7a11875894..7c9c7ccc3f41 100644

package/powertop/powertop.mk POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \ · line 15

Quoted 4 lines
package/powertop/powertop.mk +1 -0
@@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
 POWERTOP_LICENSE = GPL-2.0
 POWERTOP_LICENSE_FILES = COPYING
 POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
+# Patching Makefile.am

Maybe you can name the patch here
# 0001-dont-force-stack-smashing-protection.patch

Quoted 6 lines
Quoted 3 lines

package/powertop/powertop.mk POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \ · line 16

Quoted 1 line
package/powertop/powertop.mk +1 -0
+POWERTOP_AUTORECONF = YES

Gettextize was needed with powertop 2.27, can you check if it's still needed ?

The build succeeds here without gettextize. The same config fails without the patch with the same error as the autobuilder.

Thanks for checking :)

Best regards,
Romain

Quoted 3 lines

baruch

Applied
#4 lore raw

PATCH 1/1 powertop: needs autoreconf

In reply to Baruch Siach

Hello,

Quoted 9 lines · Baruch Siach

Commit 01048deab60 (package/powertop: bump to version 2.9) removed autoreconf even though the remaining patch touches Makefile.am. Fix this.

Fixes:
http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/

Quoted 6 lines
Cc Romain Naour <[email protected]>
Cc Steven Noonan <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/powertop/powertop.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied to master after tweaking the comment to mention exactly which patch requires autoreconf, as suggested by Romain.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com