Skip to contentSkip to conversation

Unreference pixmap's FB with EXA as well in radeon_set_pixmap_bo

PATCH In review Michel Dänzer 2 participants 2 messages Oct 19, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Unreference pixmap's FB with EXA as well in radeon_set_pixmap_bo

From: Michel Dänzer <[email protected]>

Not doing so resulted in DRI2 page flips not actually changing the FB being scanned out, showing intermittent flicker of the "back" buffer rendering.

Bugzilla: https://bugs.freedesktop.org/102643

Fixes 55e513b978b2 "Use reference counting for tracking KMS framebuffer

lifetimes"

---
 src/radeon.h | 2 ++
 1 file changed, 2 insertions(+)
src/radeon.h +2 -0
index 81b04ae24..d54e4990c 100644
@@ -769,6 +769,8 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_bo *bo)
 	    if (driver_priv->bo)
 		radeon_bo_unref(driver_priv->bo);
 
+	    drmmode_fb_reference(pRADEONEnt->fd, &driver_priv->fb, NULL);
+
 	    radeon_bo_ref(bo);
 	    driver_priv->bo = bo;
 
Signature · 6 lines
2.14.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20171019165835.11966-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Thursday, October 19, 2017 12:59 PM
To: [email protected]
Subject: [PATCH xf86-video-ati] Unreference pixmap's FB with EXA as well in radeon_set_pixmap_bo

From: Michel Dänzer <[email protected]>

Quoted 8 lines

Not doing so resulted in DRI2 page flips not actually changing the FB being scanned out, showing intermittent flicker of the "back" buffer rendering.

Bugzilla: https://bugs.freedesktop.org/102643

Fixes 55e513b978b2 "Use reference counting for tracking KMS framebuffer

lifetimes"

Quoted 19 lines
---
 src/radeon.h | 2 ++
 1 file changed, 2 insertions(+)
src/radeon.h +2 -0
index 81b04ae24..d54e4990c 100644
@@ -769,6 +769,8 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr
 pPix, struct radeon_bo *bo)
 	    if (driver_priv->bo)
 		radeon_bo_unref(driver_priv->bo);
 
+	    drmmode_fb_reference(pRADEONEnt->fd, &driver_priv->fb,
 NULL);
+
 	    radeon_bo_ref(bo);

driver_priv->bo = bo;

Quoted 7 lines

--
2.14.2

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx