Skip to contentSkip to conversation

Config.in: fix help comment for gcc optimization

PATCH New Lothar Felten 3 participants 4 messages Oct 20, 2017 – Oct 24, 2017

lore
Share & tools
lore

Lothar Felten

author
#0 lore raw

PATCH 1/1 Config.in: fix help comment for gcc optimization

The default for is set to BR2_OPTIMIZE_S, the help comment designated BR2_OPTIMIZE_0 as default.
Changed the help comment to show that BR2_OPTIMIZE_S is the default.

Signed-off-by Lothar Felten <[email protected]>
---
 Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Config.in +2 -1
index 814dc02..9bdb0b8 100644
@@ -458,7 +458,7 @@ choice
 config BR2_OPTIMIZE_0
 	bool "optimization level 0"
 	help
-	  Do not optimize. This is the default.
+	  Do not optimize.
 
 config BR2_OPTIMIZE_1
 	bool "optimization level 1"

@@ -525,6 +525,7 @@ config BR2_OPTIMIZE_S
 	  -falign-loops -falign-labels -freorder-blocks
 	  -freorder-blocks-and-partition -fprefetch-loop-arrays
 	  -ftree-vect-loop-version
+	  This is the default.
 
 endchoice
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Config.in: fix help comment for gcc optimization

Hello,

Quoted 8 lines · Lothar Felten

The default for is set to BR2_OPTIMIZE_S, the help comment designated BR2_OPTIMIZE_0 as default.
Changed the help comment to show that BR2_OPTIMIZE_S is the default.

Signed-off-by Lothar Felten <[email protected]>
---
 Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Impressive that this has been wrong for so long without being noticed. Applied your patch, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 Config.in: fix help comment for gcc optimization

In reply to Lothar Felten
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Lothar" == Lothar Felten <[email protected]> writes:

The default for is set to BR2_OPTIMIZE_S, the help comment designated BR2_OPTIMIZE_0 as default.
Changed the help comment to show that BR2_OPTIMIZE_S is the default.

Signed-off-by Lothar Felten <[email protected]>

Committed to 2017.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 Config.in: fix help comment for gcc optimization

In reply to Lothar Felten
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Lothar" == Lothar Felten <[email protected]> writes:

The default for is set to BR2_OPTIMIZE_S, the help comment designated BR2_OPTIMIZE_0 as default.
Changed the help comment to show that BR2_OPTIMIZE_S is the default.

Signed-off-by Lothar Felten <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard