cups-filters: add new package cups-filters 1.17.9
PATCH 1/1 cups-filters: add new package cups-filters 1.17.9
--- Config.in.legacy | 1 + package/Config.in | 1 + package/cups-filters/Config.in | 31 ++++++++++++++ package/cups-filters/cups-filters.hash | 2 + package/cups-filters/cups-filters.mk | 78 ++++++++++++++++++++++++++++++++++ 5 files changed, 113 insertions(+) create mode 100644 package/cups-filters/Config.in create mode 100644 package/cups-filters/cups-filters.hash create mode 100644 package/cups-filters/cups-filters.mk
Config.in.legacy +1 -0
@@ -1303,6 +1303,7 @@ config BR2_LINUX_KERNEL_SAME_AS_HEADERS config BR2_PACKAGE_CUPS_PDFTOPS bool "Pdftops support has been removed from Cups" + select BR2_PACKAGE_CUPS_FILTERS select BR2_LEGACY help Pdftops support has been removed from the cups package
package/Config.in +1 -0
@@ -1621,6 +1621,7 @@ menu "Networking applications" source "package/crda/Config.in" source "package/ctorrent/Config.in" source "package/cups/Config.in" + source "package/cups-filters/Config.in" source "package/dante/Config.in" source "package/darkhttpd/Config.in" source "package/dhcp/Config.in"
package/cups-filters/Config.in new file +31 -0
@@ -0,0 +1,31 @@ +config BR2_PACKAGE_CUPS_FILTERS + bool "cups-filters" + # needs fork() + depends on BR2_USE_MMU + depends on BR2_INSTALL_LIBSTDCPP #qpdf + depends on !BR2_STATIC_LIBS + depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS #libglib2 + depends on BR2_PACKAGE_CUPS + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LCMS2 + select BR2_PACKAGE_QPDF + help + This project provides backends, filters, and other software that was + once part of the core CUPS distribution but is no longer maintained + by Apple Inc. In addition it contains additional filters and software + developed independently of Apple, especially filters for the PDF- + centric printing workflow introduced by OpenPrinting and a daemon + to browse Bonjour broadcasts of remote CUPS printers to make these + printers available locally and to provide backward compatibility to + the old CUPS broadcasting and browsing of CUPS 1.5.x and older. + From CUPS 1.6.0 on, this package is required for using printer drivers + with CUPS under Linux. With CUPS 1.5.x and earlier this package can be + used optionally to switch over to PDF-based printing. + + http://www.linuxfoundation.org/collaborate/workgroups/openprinting/cups-filters + +comment "cups-filters needs a toolchain w/ wchar, C++, threads and dynamic library support" + depends on BR2_USE_MMU + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || !BR2_STATIC_LIBS +
package/cups-filters/cups-filters.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally computed: +sha256 95254d7950df4c74d293ed7dfa0b714f51cff329a82da74a4ac976d342bb35ab cups-filters-1.17.9.tar.gz
package/cups-filters/cups-filters.mk new file +78 -0
78 lines not on this page · raw message
Signature · 1 line
2.11.0
PATCH 1/1 cups-filters: add new package cups-filters 1.17.9
Hello,
Quoted 11 lines · Olivier Schonken
Signed-off-by Olivier Schonken <[email protected]>--- Config.in.legacy | 1 + package/Config.in | 1 + package/cups-filters/Config.in | 31 ++++++++++++++ package/cups-filters/cups-filters.hash | 2 + package/cups-filters/cups-filters.mk | 78 ++++++++++++++++++++++++++++++++++ 5 files changed, 113 insertions(+) create mode 100644 package/cups-filters/Config.in create mode 100644 package/cups-filters/cups-filters.hash create mode 100644 package/cups-filters/cups-filters.mk
Thanks for this contribution. Unfortunately, it doesn't build here, even after fixing a number of build issues. Dependencies on fontconfig and freetype were missing, so I added them. But even with that, the build still fails with:
checking for LIBQPDF... no
configure: error: Package requirements (libqpdf >= 3.0.2) were not met:
Package libjpeg was not found in the pkg-config search path. Perhaps you should add the directory containing `libjpeg.pc' to the PKG_CONFIG_PATH environment variable Package 'libjpeg', required by 'libqpdf', not found
But libjpeg is installed (as a dependency of qpdf), but it hasn't installed any .pc file.
Another minor issue is that you forgot to update the DEVELOPERS file.
package/cups-filters/Config.in line 3
Quoted 9 lines
package/cups-filters/Config.in new file +3
-0@@ -0,0 +1,31 @@ +config BR2_PACKAGE_CUPS_FILTERS + bool "cups-filters" + # needs fork()
This entire file is broken: it uses spaces instead of tabs for indentation. If possible, try to use ./utils/check-package to check this kind of coding style problems.
package/cups-filters/Config.in line 24
Quoted 12 lines
package/cups-filters/Config.in new file +12
-0+ help + This project provides backends, filters, and other software that was + once part of the core CUPS distribution but is no longer maintained + by Apple Inc. In addition it contains additional filters and software + developed independently of Apple, especially filters for the PDF- + centric printing workflow introduced by OpenPrinting and a daemon + to browse Bonjour broadcasts of remote CUPS printers to make these + printers available locally and to provide backward compatibility to + the old CUPS broadcasting and browsing of CUPS 1.5.x and older. + From CUPS 1.6.0 on, this package is required for using printer drivers + with CUPS under Linux. With CUPS 1.5.x and earlier this package can be + used optionally to switch over to PDF-based printing.
Text needs to be wrapped at 72 characters.
package/cups-filters/Config.in line 31
Quoted 4 lines
package/cups-filters/Config.in new file +4
-0+comment "cups-filters needs a toolchain w/ wchar, C++, threads and dynamic library support" + depends on BR2_USE_MMU + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR || !BR2_STATIC_LIBS +
Useless empty newline.
package/cups-filters/Config.in line 22
Quoted 3 lines
package/cups-filters/Config.in new file +3
-0+CUPS_FILTERS_VERSION = 1.17.9 +CUPS_FILTERS_SITE = http://openprinting.org/download/cups-filters +CUPS_FILTERS_LICENSE = GPL-2.0, GPL-2.0+, GPL-3.0, GPL-3.0+, LGPL-2, LGPL-2.1+, MIT, BSD-4-Clause
I was hoping to get a description of what is under what license, but the list is super long, and it's anyway described very clearly in the COPYING file. So for me, what you did is good enough.
package/cups-filters/Config.in line 25
Quoted 3 lines
package/cups-filters/Config.in new file +3
-0+CUPS_FILTERS_LICENSE_FILES = COPYING + +CUPS_FILTERS_DEPENDENCIES = cups libglib2 lcms2 qpdf
So fontconfig and freetype missing here.
package/cups-filters/Config.in
Quoted 7 lines
package/cups-filters/Config.in new file +7
-0+ +CUPS_FILTERS_CONF_OPTS = --disable-imagefilters \ + --disable-mutool \ + --disable-foomatic \ + --with-cups-config=$(STAGING_DIR)/usr/bin/cups-config \ + --with-sysroot=$(STAGING_DIR) \ + --with-pdftops=pdftops
Please use one tab for indentation, not spaces.
Could you fix those problems, and send an updated version?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com