mpd: enable package for external ARC toolchain
PATCH 1/1 mpd: enable package for external ARC toolchain
Now using prebuilt arc-2017.09-rc1 toolchain it is possible to build mpd package. The GCC patch solving the problem with pthread support check now is the part of ARC toolchain.
Note this patch has a prerequisite that updates ARC prebuilt toolchain,
http://patchwork.ozlabs.org/patch/824311/
--- package/mpd/Config.in | 3 --- 1 file changed, 3 deletions(-)
package/mpd/Config.in +0 -3
@@ -7,8 +7,6 @@ menuconfig BR2_PACKAGE_MPD depends on BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr - # ARC toolchain issue - depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG)
@@ -320,7 +318,6 @@ comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9" depends on BR2_TOOLCHAIN_HAS_ATOMIC depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 - depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC comment "mpd needs a toolchain not affected by GCC bug 64735" depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
Signature · 1 line
2.11.0
PATCH 1/1 mpd: enable package for external ARC toolchain
Hi Evgeny,
Quoted 6 lines · Evgeniy Didin
Now using prebuilt arc-2017.09-rc1 toolchain it is possible to build mpd package. The GCC patch solving the problem with pthread support check now is the part of ARC toolchain.
Note this patch has a prerequisite that updates ARC prebuilt toolchain,
http://patchwork.ozlabs.org/patch/824311/
In this case you should send the patches as a series. And if you don't, such a
comment should be below the --- line because it's not something that should stay in the history.
Otherwise:
Regards,
Arnout
Quoted 32 lines
Signed-off-by Evgeniy Didin <[email protected]>CC Alexey Brodkin <[email protected]>CC arc-buildroot at synopsys.comCC Thomas Petazzoni <[email protected]>--- package/mpd/Config.in | 3 --- 1 file changed, 3 deletions(-)package/mpd/Config.in +0
-3@@ -7,8 +7,6 @@ menuconfig BR2_PACKAGE_MPD depends on BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++14 depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr - # ARC toolchain issue - depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_MPD_TREMOR if !(BR2_PACKAGE_MPD_MAD || BR2_PACKAGE_MPD_MPG123 || BR2_PACKAGE_MPD_VORBIS || BR2_PACKAGE_MPD_WAVPACK || BR2_PACKAGE_MPD_FLAC || BR2_PACKAGE_MPD_MUSEPACK || BR2_PACKAGE_MPD_FFMPEG)@@ -320,7 +318,6 @@ comment "mpd needs a toolchain w/ C++, threads, wchar, gcc >= 4.9" depends on BR2_TOOLCHAIN_HAS_ATOMIC depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 - depends on !BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC comment "mpd needs a toolchain not affected by GCC bug 64735" depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 mpd: enable package for external ARC toolchain
Hello,
Quoted 9 lines · Arnout Vandecappelle
Hi Evgeny,
Quoted 6 lines · Evgeniy Didin
Now using prebuilt arc-2017.09-rc1 toolchain it is possible to build mpd package. The GCC patch solving the problem with pthread support check now is the part of ARC toolchain.
Note this patch has a prerequisite that updates ARC prebuilt toolchain,
http://patchwork.ozlabs.org/patch/824311/
The ARC prebuilt toolchain is not tested by our autobuilders. The two ARC configurations that we have are:
support/config-fragments/autobuild/br-arc-full-internal.config support/config-fragments/autobuild/br-arcle-hs38.config
The first is a Buildroot internal toolchain, the second is an external toolchain, built with Buildroot.
So we are not testing the Synopsys-provided pre-built toolchain, and therefore the build failures that were detected in mpd and vlc were not caused by Synopsys pre-built toolchain.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 mpd: enable package for external ARC toolchain
Hi Thomas,
Quoted 22 lines · Thomas Petazzoni
Hello,
Quoted 12 lines · Arnout Vandecappelle
?Hi Evgeny,
Quoted 8 lines · Evgeniy Didin
Now using prebuilt arc-2017.09-rc1 toolchain it is possible to build mpd package. The GCC patch solving the problem with pthread support check now is the part of ARC toolchain.
Note this patch has a prerequisite that updates ARC prebuilt toolchain,
https://urldefense.proofpoint.com/v2/url?u=http-3A__patchwork.ozlabs.org_patch_824311_&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eV
iXO7breS55ytWkhpk5R81I&m=g9SyhkcD7kkLjdVnxy_0PIxm6vf8vG9VuhheaCLHUOM&s=iTUcPjYUEl_yRBzAeiF08HNRskfS5hohJtPn80zE064&e=??The ARC prebuilt toolchain is not tested by our autobuilders. The two ARC configurations that we have are:
support/config-fragments/autobuild/br-arc-full-internal.configsupport/config-fragments/autobuild/br-arcle-hs38.config
Quoted 6 lines
The first is a Buildroot internal toolchain, the second is an external toolchain, built with Buildroot.
So we are not testing the Synopsys-provided pre-built toolchain, and therefore the build failures that were detected in mpd and vlc were not caused by Synopsys pre-built toolchain.
Indeed, so then that note about prerequisite makes no sense. Evgeniy will resend this patch with fixed commit message shortly.
-Alexey
PATCH 1/1 mpd: enable package for external ARC toolchain
In reply to Evgeniy DidinHello,
Quoted 7 lines · Evgeniy Didin
Now using prebuilt arc-2017.09-rc1 toolchain it is possible to build mpd package. The GCC patch solving the problem with pthread support check now is the part of ARC toolchain.
Note this patch has a prerequisite that updates ARC prebuilt toolchain,
http://patchwork.ozlabs.org/patch/824311/
Quoted 8 lines
Signed-off-by Evgeniy Didin <[email protected]>CC Alexey Brodkin <[email protected]>CC arc-buildroot at synopsys.comCC Thomas Petazzoni <[email protected]>--- package/mpd/Config.in | 3 --- 1 file changed, 3 deletions(-)
As was pointed out in the comments, this is only applicable once the ARC external toolchain has been updated. So could you please send both patches as a patch series, once the final version of the 2017.09 ARC external toolchain is available?
In the mean time I'll mark the patch as Changes Requested in patchwork.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com