Skip to contentSkip to conversation

ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' node with unit name and no reg property

PATCH New Marco Franchi 2 participants 8 messages Oct 20, 2017 – Oct 23, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/6 ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' node with unit name and no reg property

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /backlight at bl1 has a unit name, but no reg property

Fix this warning by removing '@bl1'from such node and change 'bl1grp' to 'backlightgrp', once there is only one backlight in this dts.

---
Changes since v2:
-change message log
-change backlight-bl1 to backlight
-change bl1grp to backlightgrp
-add missed space

 arch/arm/boot/dts/imx51-apf51dev.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx51-apf51dev.dts +2 -2
index 2f1a9d2..3e1846a 100644
@@ -16,7 +16,7 @@
 	model = "Armadeus Systems APF51Dev docking/development board";
 	compatible = "armadeus,imx51-apf51dev", "armadeus,imx51-apf51", "fsl,imx51";
 
-	backlight at bl1{
+	backlight {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_backlight>;
 		compatible = "gpio-backlight";
@@ -120,7 +120,7 @@
 	pinctrl-0 = <&pinctrl_hog>;
 
 	imx51-apf51dev {
-		pinctrl_backlight: bl1grp {
+		pinctrl_backlight: backlightgrp {
 			fsl,pins = <
 				MX51_PAD_DI1_D1_CS__GPIO3_4 0x1F5
 			>;
Signature · 1 line
2.7.4
#1 lore raw

PATCH v3 2/6 ARM: dts: imx51-ts4800: Fix 'port@0' node with unit name and no reg property

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /display-di0/port at 0 has a unit name, but no reg property

Fix this warning by removing '@' from such node.

---
Changes since v2:
-none

 arch/arm/boot/dts/imx51-ts4800.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx51-ts4800.dts +1 -1
index 35a1112..564233e 100644
@@ -71,7 +71,7 @@
 			};
 		};
 
-		port at 0 {
+		port {
 			display0_in: endpoint {
 				remote-endpoint = <&ipu_di0_disp1>;
 			};
Signature · 1 line
2.7.4
#2 lore raw

PATCH v3 3/6 ARM: dts: imx53: Fix 'usbphy@x' node with unit name and no reg property

In reply to Marco Franchi

The following build warnings are seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 50000000/usbphy at 0 has a unit name, but no reg property Warning (unit_address_vs_reg): Node /soc/aips at 50000000/usbphy at 1 has a unit name, but no reg property

Fix these warnings by changing '@' to '-'.

---
Changes since v2:
-none

 arch/arm/boot/dts/imx53.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx53.dtsi +2 -2
index 8bf0d89..c937949 100644
@@ -299,14 +299,14 @@
 				reg = <0x53f00000 0x60>;
 			};
 
-			usbphy0: usbphy at 0 {
+			usbphy0: usbphy-0 {
 				compatible = "usb-nop-xceiv";
 				clocks = <&clks IMX5_CLK_USB_PHY1_GATE>;
 				clock-names = "main_clk";
 				status = "okay";
 			};
 
-			usbphy1: usbphy at 1 {
+			usbphy1: usbphy-1 {
 				compatible = "usb-nop-xceiv";
 				clocks = <&clks IMX5_CLK_USB_PHY2_GATE>;
 				clock-names = "main_clk";
Signature · 1 line
2.7.4
#3 lore raw

PATCH v3 4/6 ARM: dts: imx53-m53evk: Fix 'led_gpio@0' node with unit name and no reg property

In reply to Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 50000000/iomuxc at 53fa8000/imx53-m53evk/led_gpio at 0 has a unit name, but no reg property

Fix this warning by removing '@0' from such node.

---
Changes since v2:
-none

 arch/arm/boot/dts/imx53-m53evk.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx53-m53evk.dts +1 -1
index 9794a04..fdbf525 100644
@@ -183,7 +183,7 @@
 			>;
 		};
 
-		led_pin_gpio: led_gpio at 0 {
+		led_pin_gpio: led_gpio {
 			fsl,pins = <
 				MX53_PAD_PATA_DATA8__GPIO2_8		0x80000000
 				MX53_PAD_PATA_DATA9__GPIO2_9		0x80000000
Signature · 1 line
2.7.4
#4 lore raw

PATCH v3 5/6 ARM: dts: imx53-qsb-common: Fix 'led_gpio7_7@0' node with unit name and no reg property

In reply to Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 50000000/iomuxc at 53fa8000/imx53-qsb/led_gpio7_7 at 0 has a unit name, but no reg property

Fix this warning by removing '@0' from such node.

---
Changes since v2:
-none

 arch/arm/boot/dts/imx53-qsb-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx53-qsb-common.dtsi +1 -1
index d5adf33..3c71de8 100644
@@ -172,7 +172,7 @@
 			>;
 		};
 
-		led_pin_gpio7_7: led_gpio7_7 at 0 {
+		led_pin_gpio7_7: led_gpio7_7 {
 			fsl,pins = <
 				MX53_PAD_PATA_DA_1__GPIO7_7 0x80000000
 			>;
Signature · 1 line
2.7.4
#5 lore raw

PATCH v3 6/6 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

In reply to Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node.

---
Changes since v2:
-change message log
-add reg property

 arch/arm/boot/dts/imx53-tx53.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx53-tx53.dtsi +1 -0
index 76e7186..61ecd13 100644
@@ -226,6 +226,7 @@
 	status = "okay";
 
 	phy0: ethernet-phy at 0 {
+		reg = <0>;
 		interrupts-extended = <&gpio2 4 IRQ_TYPE_EDGE_FALLING>;
 		device_type = "ethernet-phy";
 	};
Signature · 1 line
2.7.4
#6 lore raw

PATCH v3 6/6 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

Quoted 7 lines · Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node.

I'm not sure if you tested the change, but I'm seeing the following warning.

Warning (reg_format): "reg" property in
/soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)

Shawn

Quoted 22 lines

---
Changes since v2:

(quoted diff) +0 -2
-change message log
-add reg property
 arch/arm/boot/dts/imx53-tx53.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx53-tx53.dtsi +1 -0
index 76e7186..61ecd13 100644
@@ -226,6 +226,7 @@
 	status = "okay";
 
 	phy0: ethernet-phy at 0 {
+		reg = <0>;
 		interrupts-extended = <&gpio2 4 IRQ_TYPE_EDGE_FALLING>;
 		device_type = "ethernet-phy";
 	};
Signature · 1 line
2.7.4
#7 lore raw

PATCH v3 1/6 ARM: dts: imx51-apf51dev: Fix 'backlight@bl1' node with unit name and no reg property

In reply to Marco Franchi
Quoted 8 lines · Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /backlight at bl1 has a unit name, but no reg property

Fix this warning by removing '@bl1'from such node and change 'bl1grp' to 'backlightgrp', once there is only one backlight in this dts.

Applied #1 ~ #5, thanks.