libcpprestsdk: new package
PATCH v4 1/1 libcpprestsdk: new package
The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.
This package is licensed under the MIT package and depends on BOOST and OpenSSL/LibreSSL.
Signed-off-by Adam Duskett <[email protected]>
---
Changes v1 -> v2:
- Add "depends on BR2_USE_WCHAR # boost" to boost.mk (Thomas)
- Remove "depends on BR2_USE_MMU" from boost.mk (Thomas)
- Add "!BR2_USE_WCHAR" to boost.mk (Thomas)
Changes v2 -> v3:
- Update to v2.10.0
- Remove check for libressl now that OpenSSL is a virtual package.
- Add 0001-remove-cast-align-error-flag.patch to prevent cross-compiling warning errors.
- Add 0002-fix-xlocale-header-check.patch to prevent uclibc/musl errors due to a missing header.
- Add 0003-fix-compilation-issues-with-musl.patch which adds sys/time.h to asyncrt_utils.h.
Changes v3 -> v4:
- Fixed 0003-fix-compilation-issues-with-musl.patch
DEVELOPERS | 1 + package/Config.in | 1 + .../0001-remove-cast-align-error-flag.patch | 29 ++++++++++++ .../0002-fix-xlocale-header-check.patch | 55 ++++++++++++++++++++++ .../0003-fix-compilation-issues-with-musl.patch | 28 +++++++++++ package/libcpprestsdk/Config.in | 26 ++++++++++ package/libcpprestsdk/libcpprestsdk.hash | 3 ++ package/libcpprestsdk/libcpprestsdk.mk | 15 ++++++ 8 files changed, 158 insertions(+) create mode 100644 package/libcpprestsdk/0001-remove-cast-align-error-flag.patch create mode 100644 package/libcpprestsdk/0002-fix-xlocale-header-check.patch create mode 100644 package/libcpprestsdk/0003-fix-compilation-issues-with-musl.patch create mode 100644 package/libcpprestsdk/Config.in create mode 100644 package/libcpprestsdk/libcpprestsdk.hash create mode 100644 package/libcpprestsdk/libcpprestsdk.mk
DEVELOPERS +1 -0
@@ -34,6 +34,7 @@ F: package/audit/ F: package/checkpolicy/ F: package/gstreamer1/gst1-vaapi/ F: package/janus-gateway/ +F: package/libcpprestsdk/ F: package/libressl/ F: package/libselinux/ F: package/libsemanage/
package/Config.in +1 -0
@@ -1337,6 +1337,7 @@ menu "Networking" source "package/libcgi/Config.in" source "package/libcgicc/Config.in" source "package/libcoap/Config.in" + source "package/libcpprestsdk/Config.in" source "package/libcurl/Config.in" source "package/libdnet/Config.in" source "package/libeXosip2/Config.in"
package/libcpprestsdk/0001-remove-cast-align-error-flag.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 2b1b376b6daa96e663f30032e3ac047c9f0668d7 Mon Sep 17 00:00:00 2001 +From: Adam Duskett <[email protected]> +Date: Mon, 23 Oct 2017 07:47:42 -0400 +Subject: [PATCH 1/1] remove cast-align error flag + +When cross compiling, frame.hpp and md5.hpp both have casts that will throw +a cast-align warning, by default this will throw an error. + +Signed-off-by: Adam Duskett <[email protected]> +--- + Release/CMakeLists.txt | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/Release/CMakeLists.txt b/Release/CMakeLists.txt +index bc1d612..d57aa3d 100644 +--- a/Release/CMakeLists.txt ++++ b/Release/CMakeLists.txt +@@ -161,7 +161,7 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR IOS) + elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU") + message("-- Setting gcc options") + +- set(WARNINGS -Wall -Wextra -Wunused-parameter -Wcast-align -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls -Wunreachable-code) ++ set(WARNINGS -Wall -Wextra -Wunused-parameter -Wcast-qual -Wconversion -Wformat=2 -Winit-self -Winvalid-pch -Wmissing-format-attribute -Wmissing-include-dirs -Wpacked -Wredundant-decls -Wunreachable-code) + set(LD_FLAGS "${LD_FLAGS} -Wl,-z,defs") + + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-strict-aliasing") +-- +2.13.6 +
package/libcpprestsdk/0002-fix-xlocale-header-check.patch new file +55 -0
55 lines not on this page · raw message
package/libcpprestsdk/0003-fix-compilation-issues-with-musl.patch new file +28 -0
@@ -0,0 +1,28 @@ +From 25453f9c186cf441881b06bc5503d979acb0ab75 Mon Sep 17 00:00:00 2001 +From: Adam Duskett <[email protected]> +Date: Mon, 23 Oct 2017 09:38:11 -0400 +Subject: [PATCH] fix compilation issues with musl + +sys/time.h needed for struct timeval + +Upstream-Status: Pending +Signed-off-by: Adam Duskett <[email protected]> +--- + Release/include/cpprest/asyncrt_utils.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/Release/include/cpprest/asyncrt_utils.h b/Release/include/cpprest/asyncrt_utils.h +index 8faa2dc..aab87a5 100644 +--- a/Release/include/cpprest/asyncrt_utils.h ++++ b/Release/include/cpprest/asyncrt_utils.h +@@ -28,6 +28,7 @@ + #endif + + #ifndef _WIN32 ++#include <sys/time.h> + #include <boost/algorithm/string.hpp> + #if !defined(ANDROID) && !defined(__ANDROID__) && defined(HAVE_XLOCALE_H) // CodePlex 269 + /* Systems using glibc: xlocale.h has been removed from glibc 2.26 +-- +2.13.6 +
package/libcpprestsdk/Config.in new file +26 -0
@@ -0,0 +1,26 @@ +config BR2_PACKAGE_LIBCPPRESTSDK + bool "libcpprestsdk" + depends on BR2_INSTALL_LIBSTDCPP # boost + depends on BR2_TOOLCHAIN_HAS_THREADS # boost + depends on BR2_USE_WCHAR # boost + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_ATOMIC + select BR2_PACKAGE_BOOST_CHRONO + select BR2_PACKAGE_BOOST_DATE_TIME + select BR2_PACKAGE_BOOST_FILESYSTEM + select BR2_PACKAGE_BOOST_RANDOM + select BR2_PACKAGE_BOOST_REGEX + select BR2_PACKAGE_BOOST_THREAD + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_ZLIB + help + The C++ REST SDK is a Microsoft project for cloud-based + client-server communication in native code using a modern + asynchronous C++ API design. This project aims to help C++ + developers connect to and interact with services. + + https://github.com/Microsoft/cpprestsdk + +comment "libcpprestsdk needs a toolchain w/ C++, wchar, threads" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \ + || !BR2_USE_WCHAR
package/libcpprestsdk/libcpprestsdk.hash new file +3 -0
@@ -0,0 +1,3 @@ +# Locally calculated +sha256 de333da67f1cb3d1b30be118860531092467f18d24ca6b4d36f6623fecab0de0 libcpprestsdk-v2.10.0.tar.gz +sha256 5c191789f502ac87df83b57008d2fc3e47fbf31315381b5bc4309f6602d0fe97 license.txt
package/libcpprestsdk/libcpprestsdk.mk new file +15 -0
@@ -0,0 +1,15 @@ +################################################################################ +# +# libcpprestsdk +# +################################################################################ + +LIBCPPRESTSDK_VERSION = v2.10.0 +LIBCPPRESTSDK_SITE = $(call github,Microsoft,cpprestsdk,$(LIBCPPRESTSDK_VERSION)) +LIBCPPRESTSDK_DEPENDENCIES = boost +LIBCPPRESTSDK_LICENSE = MIT +LIBCPPRESTSDK_LICENSE_FILES = license.txt +LIBCPPRESTSDK_SUBDIR = Release +LIBCPPRESTSDK_DEPENDENCIES += openssl zlib + +$(eval $(cmake-package))
Signature · 1 line
2.13.6
PATCH v4 1/1 libcpprestsdk: new package
Quoted 9 lines · Adam Duskett
The C++ REST SDK is a Microsoft project for cloud-based client-server communication in native code using a modern asynchronous C++ API design. This project aims to help C++ developers connect to and interact with services.
This package is licensed under the MIT package and depends on BOOST and OpenSSL/LibreSSL.
Signed-off-by Adam Duskett <[email protected]>
[snip]
package/libcpprestsdk/0001-remove-cast-align-error-flag.patch line 7
Quoted 13 lines
package/libcpprestsdk/0001-remove-cast-align-error-flag.patch new file +7
-0@@ -0,0 +1,29 @@ +From 2b1b376b6daa96e663f30032e3ac047c9f0668d7 Mon Sep 17 00:00:00 2001 +From: Adam Duskett <[email protected]> +Date: Mon, 23 Oct 2017 07:47:42 -0400 +Subject: [PATCH 1/1] remove cast-align error flag + +When cross compiling, frame.hpp and md5.hpp both have casts that will throw +a cast-align warning, by default this will throw an error.
So I trust you have verified that those casts can never lead to unaligned
accesses on architectures that don't support unaligned access? Note BTW that this has nothing to do with cross-compilation, only with the target architecture.
Anyway, it's better to disable the -Werror by giving cmake -DWERROR=OFF.
[snip]
Quoted 6 lines
package/libcpprestsdk/0002-fix-xlocale-header-check.patch new file +0
-0
package/libcpprestsdk/0002-fix-xlocale-header-check.patch line 10
Quoted 10 lines
package/libcpprestsdk/0002-fix-xlocale-header-check.patch new file +10
-0@@ -0,0 +1,55 @@ +From a826b7b656c165bc35746d9af3ec371387d2bca1 Mon Sep 17 00:00:00 2001 +From: Adam Duskett <[email protected]> +Date: Mon, 23 Oct 2017 08:11:21 -0400 +Subject: [PATCH 2/2] fix xlocale header check + +asyncrt_utils.h checks if __GLIBC__ is not defined before including +xlocal.h. This will cause a compilation failure on uclibc and musl. + +Add a proper check in CMakeLists.txt and check for HAVE_XLOCALE_H +instead of __GLIBC__
Good patch!
package/libcpprestsdk/0002-fix-xlocale-header-check.patch line 12
Quoted 2 lines
package/libcpprestsdk/0002-fix-xlocale-header-check.patch new file +2
-0+ +Upstream-Status: Pending
And upstreamed as well, great!
Quoted 1 line
package/libcpprestsdk/0002-fix-xlocale-header-check.patch new file +1
-0+Signed-off-by: Adam Duskett <[email protected]>
[snip]
package/libcpprestsdk/0003-fix-compilation-issues-with-musl.patch line 6
Quoted 12 lines
package/libcpprestsdk/0003-fix-compilation-issues-with-musl.patch new file +6
-0@@ -0,0 +1,28 @@ +From 25453f9c186cf441881b06bc5503d979acb0ab75 Mon Sep 17 00:00:00 2001 +From: Adam Duskett <[email protected]> +Date: Mon, 23 Oct 2017 09:38:11 -0400 +Subject: [PATCH] fix compilation issues with musl + +sys/time.h needed for struct timeval
Small nit: this is a better subject line. "Fix compilation issues with musl"
doesn't say much. So
Include sys/time.h for struct timeval
This is needed with musl.
Quoted 28 lines
package/libcpprestsdk/0003-fix-compilation-issues-with-musl.patch new file +22
-0+ +Upstream-Status: Pending +Signed-off-by: Adam Duskett <[email protected]> +--- + Release/include/cpprest/asyncrt_utils.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/Release/include/cpprest/asyncrt_utils.h b/Release/include/cpprest/asyncrt_utils.h +index 8faa2dc..aab87a5 100644 +--- a/Release/include/cpprest/asyncrt_utils.h ++++ b/Release/include/cpprest/asyncrt_utils.h +@@ -28,6 +28,7 @@ + #endif + + #ifndef _WIN32 ++#include <sys/time.h> + #include <boost/algorithm/string.hpp> + #if !defined(ANDROID) && !defined(__ANDROID__) && defined(HAVE_XLOCALE_H) // CodePlex 269 + /* Systems using glibc: xlocale.h has been removed from glibc 2.26 +-- +2.13.6 +package/libcpprestsdk/Config.in new file +0
-0
package/libcpprestsdk/Config.in line 3
Quoted 3 lines
package/libcpprestsdk/Config.in new file +3
-0@@ -0,0 +1,26 @@ +config BR2_PACKAGE_LIBCPPRESTSDK + bool "libcpprestsdk" + depends on BR2_INSTALL_LIBSTDCPP # boost
Another small nit: it is this package itself that requires C++, so remove the
# boost
Quoted 13 lines
package/libcpprestsdk/Config.in new file +13
-0+ depends on BR2_TOOLCHAIN_HAS_THREADS # boost + depends on BR2_USE_WCHAR # boost + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_BOOST_ATOMIC + select BR2_PACKAGE_BOOST_CHRONO + select BR2_PACKAGE_BOOST_DATE_TIME + select BR2_PACKAGE_BOOST_FILESYSTEM + select BR2_PACKAGE_BOOST_RANDOM + select BR2_PACKAGE_BOOST_REGEX + select BR2_PACKAGE_BOOST_THREAD + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_ZLIB + help
package/libcpprestsdk/Config.in line 26
Quoted 10 lines
package/libcpprestsdk/Config.in new file +10
-0+ The C++ REST SDK is a Microsoft project for cloud-based + client-server communication in native code using a modern + asynchronous C++ API design. This project aims to help C++ + developers connect to and interact with services. + + https://github.com/Microsoft/cpprestsdk + +comment "libcpprestsdk needs a toolchain w/ C++, wchar, threads" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \ + || !BR2_USE_WCHAR
Indent this line one tab more.
package/libcpprestsdk/libcpprestsdk.hash line 3
Quoted 9 lines
package/libcpprestsdk/libcpprestsdk.hash new file +3
-0@@ -0,0 +1,3 @@ +# Locally calculated +sha256 de333da67f1cb3d1b30be118860531092467f18d24ca6b4d36f6623fecab0de0 libcpprestsdk-v2.10.0.tar.gz +sha256 5c191789f502ac87df83b57008d2fc3e47fbf31315381b5bc4309f6602d0fe97 license.txt
We have no rules for the spaces in the hash files, but this definitely looks weird.
Quoted 9 lines
package/libcpprestsdk/libcpprestsdk.mk new file +3
-0@@ -0,0 +1,15 @@ +################################################################################ +# +# libcpprestsdk
package/libcpprestsdk/libcpprestsdk.mk line 13
Quoted 10 lines
package/libcpprestsdk/libcpprestsdk.mk new file +10
-0+# +################################################################################ + +LIBCPPRESTSDK_VERSION = v2.10.0 +LIBCPPRESTSDK_SITE = $(call github,Microsoft,cpprestsdk,$(LIBCPPRESTSDK_VERSION)) +LIBCPPRESTSDK_DEPENDENCIES = boost +LIBCPPRESTSDK_LICENSE = MIT +LIBCPPRESTSDK_LICENSE_FILES = license.txt +LIBCPPRESTSDK_SUBDIR = Release +LIBCPPRESTSDK_DEPENDENCIES += openssl zlib
Makes no sense to have two DEPENDENCIES lines here, collect them in a single line.
Regards,
Arnout
Quoted 3 lines
package/libcpprestsdk/libcpprestsdk.mk new file +2
-0+ +$(eval $(cmake-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF