net: rxrpc: call_object: use BUG_ON instead of if condition followed by BUG

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 23, 2017

Subsystems (3)

Networking Network drivers Rxrpc sockets (AF_RXRPC)

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-10-23 18:13 UTC #0 lore raw

PATCH 1/1 net: rxrpc: call_object: use BUG_ON instead of if condition followed by BUG

Use BUG_ON instead of if condition followed by BUG in rxrpc_release_call.

This issue was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 net/rxrpc/call_object.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

net/rxrpc/call_object.c +1 -2

index fcdd655..b4b1a63 100644
@@ -457,8 +457,7 @@ void rxrpc_release_call(struct rxrpc_sock *rx, struct rxrpc_call *call)
 	ASSERTCMP(call->state, ==, RXRPC_CALL_COMPLETE);
 
 	spin_lock_bh(&call->lock);
-	if (test_and_set_bit(RXRPC_CALL_RELEASED, &call->flags))
-		BUG();
+	BUG_ON(test_and_set_bit(RXRPC_CALL_RELEASED, &call->flags));
 	spin_unlock_bh(&call->lock);
 
 	del_timer_sync(&call->timer);

Signature · 1 line

2.7.4