usb: musb_core: mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 3 participants 6 messages Oct 24, 2017 – Oct 30, 2017

Subsystems (2)

USB MUSB multipoint high speed dual-role controller

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-10-24 03:10 UTC #0 lore raw

PATCH 1/1 usb: musb_core: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1397608

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/usb/musb/musb_core.c | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/musb/musb_core.c +1 -0

index ff5a1a8..889ca9b 100644
@@ -767,6 +767,7 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
 		case OTG_STATE_B_IDLE:
 			if (!musb->is_active)
 				break;
+			/* fall through */
 		case OTG_STATE_B_PERIPHERAL:
 			musb_g_suspend(musb);
 			musb->is_active = musb->g.b_hnp_enable;

Signature · 1 line

2.7.4

Bin Liu

maintainer

2017-10-27 16:45 UTC #1 lore raw

Hi,

Quoted 5 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 1397608
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied with the above Coverity-ID message removed.

Thanks,
-Bin.

Greg Kroah-Hartman

maintainer

2017-10-27 16:49 UTC #2 lore raw

Quoted 10 lines · Bin Liu

Hi,
Quoted 5 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 1397608
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied with the above Coverity-ID message removed.

Why? It's good to track these things.

thanks,

greg k-h

Bin Liu

maintainer

2017-10-27 16:56 UTC #3 lore raw

Quoted 7 lines · Greg Kroah-Hartman

Quoted 6 lines · Bin Liu
Hi,
Quoted 3 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Quoted 6 lines

Quoted 4 lines
Quoted 2 lines
Addresses-Coverity-ID: 1397608
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied with the above Coverity-ID message removed.
Why? It's good to track these things.

hmm, I thought we don't want non-kernel related information in the commit message.

I just sent the musb v4.15-rc1 patches to you. Do you want to resend them with this message adding back?

Regards,
-Bin.

Greg Kroah-Hartman

maintainer

2017-10-30 08:51 UTC #4 lore raw

Quoted 11 lines · Bin Liu

Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Bin Liu
Hi,
Quoted 5 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 1397608
Signed-off-by Gustavo A. R. Silva <[email protected]>

Quoted 6 lines

Quoted 3 lines
Quoted 1 line
Applied with the above Coverity-ID message removed.
Why? It's good to track these things.
hmm, I thought we don't want non-kernel related information in the commit message.

This is kernel-related information.

We don't want foolish "Id:" lines, from gerrit instances, as they are no help at all because we can not do anything with them.

We _do_ want identifiers that are globally unique that provide real information, like public bugzilla ids, and tools like coverity. So for things like this, always keep them on.

I've added it back by hand now.

thanks,

greg k-h

Bin Liu

maintainer

2017-10-30 13:18 UTC #5 lore raw

Quoted 19 lines · Greg Kroah-Hartman

Quoted 11 lines · Bin Liu
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Bin Liu
Hi,
Quoted 5 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 1397608
Signed-off-by Gustavo A. R. Silva <[email protected]>
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Applied with the above Coverity-ID message removed.
Why? It's good to track these things.
hmm, I thought we don't want non-kernel related information in the commit message.

Quoted 8 lines

This is kernel-related information.
We don't want foolish "Id:" lines, from gerrit instances, as they are no help at all because we can not do anything with them.
We _do_ want identifiers that are globally unique that provide real information, like public bugzilla ids, and tools like coverity. So for things like this, always keep them on.

Thanks for clarifying this.

Quoted 2 lines

I've added it back by hand now.

Thanks,
-Bin.