Skip to contentSkip to conversation

usb: host: isp116x-hcd: mark expected switch fall-throughs

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 24, 2017

Subsystems (2)
USB USB ISP116X driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 usb: host: isp116x-hcd: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 115006
Addresses-Coverity-ID: 115007

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/host/isp116x-hcd.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/usb/host/isp116x-hcd.c +3 -0
index 73fec38..ebf2ff2 100644
@@ -1018,6 +1018,7 @@ static int isp116x_hub_control(struct usb_hcd *hcd,
 			spin_lock_irqsave(&isp116x->lock, flags);
 			isp116x_write_reg32(isp116x, HCRHSTATUS, RH_HS_OCIC);
 			spin_unlock_irqrestore(&isp116x->lock, flags);
+			/* fall through */
 		case C_HUB_LOCAL_POWER:
 			DBG("C_HUB_LOCAL_POWER\n");
 			break;

@@ -1433,8 +1434,10 @@ static int isp116x_bus_suspend(struct usb_hcd *hcd)
 		isp116x_write_reg32(isp116x, HCCONTROL,
 				    (val & ~HCCONTROL_HCFS) |
 				    HCCONTROL_USB_RESET);
+		/* fall through */
 	case HCCONTROL_USB_RESET:
 		ret = -EBUSY;
+		/* fall through */
 	default:		/* HCCONTROL_USB_SUSPEND */
 		spin_unlock_irqrestore(&isp116x->lock, flags);
 		break;
Signature · 1 line
2.7.4