Skip to contentSkip to conversation

drm_hwcomposer: remove unnecessary external includes

PATCH Applied Rob Herring 3 participants 3 messages Oct 25, 2017

lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 drm_hwcomposer: remove unnecessary external includes

Linking to libraries will add necessary include paths, so we don't need to list them explicitly.

Still need libsync for sw_sync.h until this dependency is removed.

Signed-off-by Rob Herring <[email protected]>
---
 Android.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Android.mk +1 -5
index 109e352f2a0e..8b11e375adde 100644
@@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
 
 LOCAL_C_INCLUDES := \
 	external/drm_gralloc \
-	external/libdrm \
-	external/libdrm/include/drm \
-	system/core/include/utils \
-	system/core/libsync \
-	system/core/libsync/include \
+	system/core/libsync
 
 LOCAL_SRC_FILES := \
 	autolock.cpp \
Signature · 6 lines
2.14.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

2017-10-25 8:06 GMT+08:00 Rob Herring <[email protected]>:

Quoted 18 lines

Linking to libraries will add necessary include paths, so we don't need to list them explicitly.

Still need libsync for sw_sync.h until this dependency is removed.

Signed-off-by Rob Herring <[email protected]>
---
 Android.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Android.mk +0 -0
index 109e352f2a0e..8b11e375adde 100644
@@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
 
 LOCAL_C_INCLUDES := \
        external/drm_gralloc \

Android.mk LOCAL_STATIC_LIBRARIES := libdrmhwc_utils

Quoted 10 lines
Android.mk +1 -6
-       external/libdrm \
-       external/libdrm/include/drm \
-       system/core/include/utils \
-       system/core/libsync \
-       system/core/libsync/include \
+       system/core/libsync
 
 LOCAL_SRC_FILES := \
        autolock.cpp \
--

Looks good to me

Reviewed-and-tested-by Chih-Wei Huang <[email protected]>
Signature · 7 lines
Chih-Wei
Android-x86 project
http://www.android-x86.org
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Applied
#2 lore raw
Quoted 26 lines · Chih-Wei Huang

2017-10-25 8:06 GMT+08:00 Rob Herring <[email protected]>:

Quoted 25 lines

Linking to libraries will add necessary include paths, so we don't need to list them explicitly.

Still need libsync for sw_sync.h until this dependency is removed.

Signed-off-by Rob Herring <[email protected]>
---
 Android.mk | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Android.mk +1 -5
index 109e352f2a0e..8b11e375adde 100644
@@ -48,11 +48,7 @@ LOCAL_STATIC_LIBRARIES := libdrmhwc_utils
 
 LOCAL_C_INCLUDES := \
        external/drm_gralloc \
-       external/libdrm \
-       external/libdrm/include/drm \
-       system/core/include/utils \
-       system/core/libsync \
-       system/core/libsync/include \
+       system/core/libsync
Quoted 6 lines

Android.mk LOCAL_STATIC_LIBRARIES := libdrmhwc_utils

Quoted 3 lines
Android.mk +0 -1
 LOCAL_SRC_FILES := \
        autolock.cpp \
--

Looks good to me

Reviewed-and-tested-by Chih-Wei Huang <[email protected]>

Applied, thanks for the patch & review.

Sean

Quoted 9 lines
Signature · 8 lines
-- 
Chih-Wei
Android-x86 project
http://www.android-x86.org
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel