arm64: remove some unused defconfig options

PATCH In review Alex Elder 3 participants 10 messages Oct 20, 2017 – Oct 25, 2017

Subsystems (3)

USB Arm Qualcomm mailing list USB ehci driver

lore

Share & tools

lore

Alex Elder

author

2017-10-20 17:20 UTC #0 lore raw

cover arm64: remove some unused defconfig options

This series deletes three config options related to USB on Qualcomm SoCs from the arm64 "defconfig", along with the code that they enable. The code is no longer needed by any Qualcomm hardware.

-Alex

Alex Elder (3):
arm64: defconfig: remove CONFIG_USB_EHCI_MSM
arm64: defconfig: remove CONFIG_USB_MSM_OTG
arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

 arch/arm64/configs/defconfig        |    3 -
 drivers/usb/host/Makefile           |    1 -
 drivers/usb/host/ehci-msm.c         |  265 -----
 drivers/usb/phy/Makefile            |    2 -
 drivers/usb/phy/phy-msm-usb.c       | 2085 -----------------------------------
 drivers/usb/phy/phy-qcom-8x16-usb.c |  366 ------
 6 files changed, 2722 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c
 delete mode 100644 drivers/usb/phy/phy-qcom-8x16-usb.c

Signature · 1 line

2.11.0

Alex Elder

author

2017-10-20 17:20 UTC #1 lore raw

PATCH 1/3 arm64: defconfig: remove CONFIG_USB_EHCI_MSM

No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove the code, and remove the config option from the arm64 defconfig.

Signed-off-by Alex Elder <[email protected]>

Acked-by Bjorn Andersson <[email protected]>

---
 arch/arm64/configs/defconfig |   1 -
 drivers/usb/host/Makefile    |   1 -
 drivers/usb/host/ehci-msm.c  | 265 -------------------------------------------
 3 files changed, 267 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c

arch/arm64/configs/defconfig +0 -1

index 34480e9af2e7..4d0b96bb340a 100644
@@ -410,7 +410,6 @@ CONFIG_USB_OTG=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_TEGRA=y
 CONFIG_USB_EHCI_HCD=y
-CONFIG_USB_EHCI_MSM=y
 CONFIG_USB_EHCI_EXYNOS=y
 CONFIG_USB_EHCI_HCD_PLATFORM=y
 CONFIG_USB_OHCI_HCD=y

drivers/usb/host/Makefile +0 -1

index cf2691fffcc0..1645c549bdb1 100644
@@ -39,7 +39,6 @@ obj-$(CONFIG_USB_EHCI_HCD_SPEAR)	+= ehci-spear.o
 obj-$(CONFIG_USB_EHCI_HCD_STI)	+= ehci-st.o
 obj-$(CONFIG_USB_EHCI_EXYNOS)	+= ehci-exynos.o
 obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
-obj-$(CONFIG_USB_EHCI_MSM)	+= ehci-msm.o
 obj-$(CONFIG_USB_EHCI_TEGRA)	+= ehci-tegra.o
 obj-$(CONFIG_USB_W90X900_EHCI)	+= ehci-w90x900.o

drivers/usb/host/ehci-msm.c deleted +0 ~~-265~~

265 lines not on this page · raw message

Signature · 1 line

2.11.0

Andy Gross

Acked-by on v1 1/3

2017-10-25 07:00 UTC #2 lore raw

Re: [PATCH 1/3] arm64: defconfig: remove CONFIG_USB_EHCI_MSM

Quoted 6 lines · Alex Elder

No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove the code, and remove the config option from the arm64 defconfig.
Suggested-by Stephen Boyd <[email protected]>
Signed-off-by Alex Elder <[email protected]>
Acked-by Bjorn Andersson <[email protected]>

Acked-by Andy Gross <[email protected]>

Alex Elder

author

2017-10-20 17:20 UTC #3 lore raw

PATCH 2/3 arm64: defconfig: remove CONFIG_USB_MSM_OTG

In reply to Alex Elder

No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support any more. Remove the code, and remove the config option from the arm64 defconfig.

Signed-off-by Alex Elder <[email protected]>

Acked-by Bjorn Andersson <[email protected]>

---
 arch/arm64/configs/defconfig  |    1 -
 drivers/usb/phy/Makefile      |    1 -
 drivers/usb/phy/phy-msm-usb.c | 2085 -----------------------------------------
 3 files changed, 2087 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c

arch/arm64/configs/defconfig +0 -1

index 4d0b96bb340a..85ca53f59c3e 100644
@@ -425,7 +425,6 @@ CONFIG_USB_CHIPIDEA_HOST=y
 CONFIG_USB_ISP1760=y
 CONFIG_USB_HSIC_USB3503=y
 CONFIG_NOP_USB_XCEIV=y
-CONFIG_USB_MSM_OTG=y
 CONFIG_USB_QCOM_8X16_PHY=y
 CONFIG_USB_ULPI=y
 CONFIG_USB_GADGET=y

drivers/usb/phy/Makefile +0 -1

index e7c9ca8cafb0..61013f38abbe 100644
@@ -18,7 +18,6 @@ obj-$(CONFIG_TWL6030_USB)		+= phy-twl6030-usb.o
 obj-$(CONFIG_USB_EHCI_TEGRA)		+= phy-tegra-usb.o
 obj-$(CONFIG_USB_GPIO_VBUS)		+= phy-gpio-vbus-usb.o
 obj-$(CONFIG_USB_ISP1301)		+= phy-isp1301.o
-obj-$(CONFIG_USB_MSM_OTG)		+= phy-msm-usb.o
 obj-$(CONFIG_USB_QCOM_8X16_PHY)	+= phy-qcom-8x16-usb.o
 obj-$(CONFIG_USB_MV_OTG)		+= phy-mv-usb.o
 obj-$(CONFIG_USB_MXS_PHY)		+= phy-mxs-usb.o

drivers/usb/phy/phy-msm-usb.c deleted +0 ~~-2085~~

2,085 lines not on this page · raw message

Signature · 1 line

2.11.0

Andy Gross

Acked-by on v1 2/3

2017-10-25 07:01 UTC #4 lore raw

Re: [PATCH 2/3] arm64: defconfig: remove CONFIG_USB_MSM_OTG

Quoted 7 lines · Alex Elder

No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support any more. Remove the code, and remove the config option from the arm64 defconfig.
Suggested-by Stephen Boyd <[email protected]>
Signed-off-by Alex Elder <[email protected]>
Acked-by Bjorn Andersson <[email protected]>

Acked-by Andy Gross <[email protected]>

Alex Elder

author

2017-10-20 17:20 UTC #5 lore raw

PATCH 3/3 arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

In reply to Alex Elder

No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver support any more. Remove the code, and remove the config option from the arm64 defconfig.

Signed-off-by Alex Elder <[email protected]>

Acked-by Bjorn Andersson <[email protected]>

---
 arch/arm64/configs/defconfig        |   1 -
 drivers/usb/phy/Makefile            |   1 -
 drivers/usb/phy/phy-qcom-8x16-usb.c | 366 ------------------------------------
 3 files changed, 368 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-qcom-8x16-usb.c

arch/arm64/configs/defconfig +0 -1

index 85ca53f59c3e..22ca89e58d9d 100644
@@ -425,7 +425,6 @@ CONFIG_USB_CHIPIDEA_HOST=y
 CONFIG_USB_ISP1760=y
 CONFIG_USB_HSIC_USB3503=y
 CONFIG_NOP_USB_XCEIV=y
-CONFIG_USB_QCOM_8X16_PHY=y
 CONFIG_USB_ULPI=y
 CONFIG_USB_GADGET=y
 CONFIG_USB_RENESAS_USBHS_UDC=m

drivers/usb/phy/Makefile +0 -1

index 61013f38abbe..8beefb7f2777 100644
@@ -18,7 +18,6 @@ obj-$(CONFIG_TWL6030_USB)		+= phy-twl6030-usb.o
 obj-$(CONFIG_USB_EHCI_TEGRA)		+= phy-tegra-usb.o
 obj-$(CONFIG_USB_GPIO_VBUS)		+= phy-gpio-vbus-usb.o
 obj-$(CONFIG_USB_ISP1301)		+= phy-isp1301.o
-obj-$(CONFIG_USB_QCOM_8X16_PHY)	+= phy-qcom-8x16-usb.o
 obj-$(CONFIG_USB_MV_OTG)		+= phy-mv-usb.o
 obj-$(CONFIG_USB_MXS_PHY)		+= phy-mxs-usb.o
 obj-$(CONFIG_USB_ULPI)			+= phy-ulpi.o

drivers/usb/phy/phy-qcom-8x16-usb.c deleted +0 ~~-366~~

366 lines not on this page · raw message

Signature · 1 line

2.11.0

Andy Gross

Acked-by on v1 3/3

2017-10-25 07:01 UTC #6 lore raw

Re: [PATCH 3/3] arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

Quoted 7 lines · Alex Elder

No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver support any more. Remove the code, and remove the config option from the arm64 defconfig.
Suggested-by Stephen Boyd <[email protected]>
Signed-off-by Alex Elder <[email protected]>
Acked-by Bjorn Andersson <[email protected]>

Acked-by Andy Gross <[email protected]>

Stephen Boyd

2017-10-25 00:20 UTC #7 lore raw

In reply to Alex Elder

Quoted 10 lines · Alex Elder

This series deletes three config options related to USB on Qualcomm SoCs from the arm64 "defconfig", along with the code that they enable. The code is no longer needed by any Qualcomm hardware.
-Alex
Alex Elder (3):
arm64: defconfig: remove CONFIG_USB_EHCI_MSM
arm64: defconfig: remove CONFIG_USB_MSM_OTG
arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

As I said off-list, I would split this into defconfig for arm-soc and drivers/usb for usb subsystem to pick up.

Quoted 12 lines

 arch/arm64/configs/defconfig        |    3 -
 drivers/usb/host/Makefile           |    1 -
 drivers/usb/host/ehci-msm.c         |  265 -----
 drivers/usb/phy/Makefile            |    2 -
 drivers/usb/phy/phy-msm-usb.c       | 2085 -----------------------------------
 drivers/usb/phy/phy-qcom-8x16-usb.c |  366 ------
 6 files changed, 2722 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c
 delete mode 100644 drivers/usb/phy/phy-qcom-8x16-usb.c

Signature · 2 lines

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Andy Gross

2017-10-25 07:02 UTC #8 lore raw

Quoted 7 lines · Stephen Boyd

Quoted 6 lines · Alex Elder
This series deletes three config options related to USB on Qualcomm SoCs from the arm64 "defconfig", along with the code that they enable. The code is no longer needed by any Qualcomm hardware.
-Alex

Quoted 7 lines

Quoted 4 lines
Alex Elder (3):
arm64: defconfig: remove CONFIG_USB_EHCI_MSM
arm64: defconfig: remove CONFIG_USB_MSM_OTG
arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY
As I said off-list, I would split this into defconfig for arm-soc and drivers/usb for usb subsystem to pick up.

I agree with splitting. But carry my ACKs when you do.

Alex Elder

author

2017-10-25 15:12 UTC #9 lore raw

Quoted 13 lines · Andy Gross

Quoted 12 lines · Stephen Boyd
Quoted 10 lines · Alex Elder
This series deletes three config options related to USB on Qualcomm SoCs from the arm64 "defconfig", along with the code that they enable. The code is no longer needed by any Qualcomm hardware.
-Alex
Alex Elder (3):
arm64: defconfig: remove CONFIG_USB_EHCI_MSM
arm64: defconfig: remove CONFIG_USB_MSM_OTG
arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

Quoted 4 lines

Quoted 2 lines
As I said off-list, I would split this into defconfig for arm-soc and drivers/usb for usb subsystem to pick up.
I agree with splitting. But carry my ACKs when you do.

I will. And I'll send two series, one for defconfig and one for the drivers. Thanks.

-Alex