Remove network test for ancient software
cover Remove network test for ancient software
Hi,
I'm proposing to remove tests for ancient software.
I don't think we should be maintaining tests for something which hardly anyone use.
Kind regards,
Petr
Petr Vorel (7):
net/tcp_cmds: Remove rwho test
net/tcp_cmds: Remove rdist test
net/tcp_cmds: Remove rlogin test
net/tcp_cmds: Remove rsh test
net/tcp_cmds: Remove rcp test
net/tcp_cmds: Remove finger test
net/tcp_cmds: Remove echo test
runtest/net.tcp_cmds | 7 - testcases/network/tcp_cmds/echo/Makefile | 38 --- testcases/network/tcp_cmds/echo/createfile.c | 52 ---- testcases/network/tcp_cmds/echo/echo01 | 127 --------- testcases/network/tcp_cmds/echo/echoes.c | 375 --------------------------- testcases/network/tcp_cmds/finger/Makefile | 31 --- testcases/network/tcp_cmds/finger/finger01 | 203 --------------- testcases/network/tcp_cmds/rcp/Makefile | 30 --- testcases/network/tcp_cmds/rcp/rcp01 | 144 ---------- testcases/network/tcp_cmds/rdist/Makefile | 30 --- testcases/network/tcp_cmds/rdist/rdist01 | 187 ------------- testcases/network/tcp_cmds/rlogin/Makefile | 31 --- testcases/network/tcp_cmds/rlogin/rlogin01 | 90 ------- testcases/network/tcp_cmds/rsh/Makefile | 31 --- testcases/network/tcp_cmds/rsh/rsh01 | 115 -------- testcases/network/tcp_cmds/rwho/Makefile | 31 --- testcases/network/tcp_cmds/rwho/rwho01 | 91 ------- 17 files changed, 1613 deletions(-) delete mode 100644 testcases/network/tcp_cmds/echo/Makefile delete mode 100644 testcases/network/tcp_cmds/echo/createfile.c delete mode 100755 testcases/network/tcp_cmds/echo/echo01 delete mode 100644 testcases/network/tcp_cmds/echo/echoes.c delete mode 100644 testcases/network/tcp_cmds/finger/Makefile delete mode 100755 testcases/network/tcp_cmds/finger/finger01 delete mode 100644 testcases/network/tcp_cmds/rcp/Makefile delete mode 100755 testcases/network/tcp_cmds/rcp/rcp01 delete mode 100644 testcases/network/tcp_cmds/rdist/Makefile delete mode 100755 testcases/network/tcp_cmds/rdist/rdist01 delete mode 100644 testcases/network/tcp_cmds/rlogin/Makefile delete mode 100755 testcases/network/tcp_cmds/rlogin/rlogin01 delete mode 100644 testcases/network/tcp_cmds/rsh/Makefile delete mode 100755 testcases/network/tcp_cmds/rsh/rsh01 delete mode 100644 testcases/network/tcp_cmds/rwho/Makefile delete mode 100755 testcases/network/tcp_cmds/rwho/rwho01
Signature · 1 line
2.14.2
RFC PATCH 1/7 net/tcp_cmds: Remove rwho test
rwhod daemon is way too old to bother to test it.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/rwho/Makefile | 31 ----------- testcases/network/tcp_cmds/rwho/rwho01 | 91 -------------------------------- 3 files changed, 123 deletions(-) delete mode 100644 testcases/network/tcp_cmds/rwho/Makefile delete mode 100755 testcases/network/tcp_cmds/rwho/rwho01
runtest/net.tcp_cmds +0 -1
@@ -16,7 +16,6 @@ rcp export TCbin=$LTPROOT/testcases/network/tcp_cmds/rcp; rcp01 rdist export TCbin=$LTPROOT/testcases/network/tcp_cmds/rdist; rdist01 rlogin rlogin01 rsh rsh01 -rwho rwho01 sendfile export TCbin=$LTPROOT/testcases/network/tcp_cmds/sendfile; sendfile01 tcpdump tcpdump01 telnet telnet01
testcases/network/tcp_cmds/rwho/Makefile deleted +0 -31
@@ -1,31 +0,0 @@ -# -# network/tcp_cmds/rwho testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := rwho01 - -MAKE_TARGETS := - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/rwho/rwho01 deleted +0 -91
91 lines not on this page · raw message
Signature · 1 line
2.14.2
RFC PATCH 1/7 net/tcp_cmds: Remove rwho test
Quoted 1 line · Petr Vorel
rwhod daemon is way too old to bother to test it.
As far as I remember, another problem with this test is that it's not really applicable for automated runs because rwho requires someone to be logged in to the machine for about 2 min to make it pass.
I'm ok with removing it.
Thanks,
Alexey
RFC PATCH 1/7 net/tcp_cmds: Remove rwho test
Hi Alexey,
Quoted 11 lines · Petr Vorel
Quoted 1 line
rwhod daemon is way too old to bother to test it.
As far as I remember, another problem with this test is that it's not really applicable for automated runs because rwho requires someone to be logged in to the machine for about 2 min to make it pass.
I'm ok with removing it.
Thanks,
Alexey
Thanks, I pushed it.
Please if you agree with other tests to be deleted, ack it.
I'd be for deleting at least finger, echo, rlogin and rdist, as Vapier asked for keeping rcp and rsh. IMHO these project should test their code themselves, I'd prefer LTP concern more about the Linux kernel itself, not about *anything* it runs on linux distribution (including networking).
Kind regards,
Petr
RFC PATCH 1/7 net/tcp_cmds: Remove rwho test
Quoted 6 lines · Petr Vorel
...
Please if you agree with other tests to be deleted, ack it.
I'd be for deleting at least finger, echo, rlogin and rdist, as Vapier asked for keeping rcp and rsh. IMHO these project should test their code themselves, I'd prefer LTP concern more about the Linux kernel itself, not about *anything* it runs on linux distribution (including networking).
By running those tests youare also verifying kernel TCP stack and network drivers.
Looking at rlogin, it's the only one among them which is convertedto newer API
already, let's keep it along with the rcp, rsh, they are inthe same packages.
Acked the rest. I guess we should also change default network configuration to SSH.
Best regards,
Alexey
RFC PATCH 1/7 net/tcp_cmds: Remove rwho test
Hi Alexey,
Quoted 10 lines · Petr Vorel
Quoted 6 lines
...
Please if you agree with other tests to be deleted, ack it.
I'd be for deleting at least finger, echo, rlogin and rdist, as Vapier asked for keeping rcp and rsh. IMHO these project should test their code themselves, I'd prefer LTP concern more about the Linux kernel itself, not about *anything* it runs on linux distribution (including networking).By running those tests youare also verifying kernel TCP stack and network drivers.
Sure :-). But it's question, whether it's a best way to test it with testing complicated apps like FTP or DNS servers (error in these hardly ever find a problem in kernel API, or drivers, more likely it's a bug in test itself or configuration problem).
IPsec and interface related tests looks to me much more relevant (are in a good shape after you fixed them and use only basic user space tools like ip).
BTW content of runtest/commands might be better to have in util-linux testing repo, where there are some anyway [1].
Quoted 5 lines
Looking at rlogin, it's the only one among them which is convertedto newer API
already, let's keep it along with the rcp, rsh, they are inthe same packages.
Acked the rest.
Thanks for acking, I kept these three, deleted rest.
Quoted 1 line
I guess we should also change default network configuration to SSH.
+1.
Kind regards,
Petr
[1] https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/tests
RFC PATCH 2/7 net/tcp_cmds: Remove rdist test
In reply to Petr Vorelrdist is way too old to bother to test it.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/rdist/Makefile | 30 ----- testcases/network/tcp_cmds/rdist/rdist01 | 187 ------------------------------ 3 files changed, 218 deletions(-) delete mode 100644 testcases/network/tcp_cmds/rdist/Makefile delete mode 100755 testcases/network/tcp_cmds/rdist/rdist01
runtest/net.tcp_cmds +0 -1
@@ -13,7 +13,6 @@ netstat netstat01 ping01 ping01.sh ping02 ping02.sh rcp export TCbin=$LTPROOT/testcases/network/tcp_cmds/rcp; rcp01 -rdist export TCbin=$LTPROOT/testcases/network/tcp_cmds/rdist; rdist01 rlogin rlogin01 rsh rsh01 sendfile export TCbin=$LTPROOT/testcases/network/tcp_cmds/sendfile; sendfile01
testcases/network/tcp_cmds/rdist/Makefile deleted +0 -30
@@ -1,30 +0,0 @@ -# -# network/tcp_cmds/rdist testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, September 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/testcases.mk -include $(abs_srcdir)/../Makefile.inc - -INSTALL_TARGETS := rdist01 - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/rdist/rdist01 deleted +0 -187
187 lines not on this page · raw message
Signature · 1 line
2.14.2
RFC PATCH 3/7 net/tcp_cmds: Remove rlogin test
In reply to Petr Vorelrlogin is way too old to bother to test it and has been deprecated for many years in favour of ssh.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/rlogin/Makefile | 31 ---------- testcases/network/tcp_cmds/rlogin/rlogin01 | 90 ------------------------------ 3 files changed, 122 deletions(-) delete mode 100644 testcases/network/tcp_cmds/rlogin/Makefile delete mode 100755 testcases/network/tcp_cmds/rlogin/rlogin01
runtest/net.tcp_cmds +0 -1
@@ -13,7 +13,6 @@ netstat netstat01 ping01 ping01.sh ping02 ping02.sh rcp export TCbin=$LTPROOT/testcases/network/tcp_cmds/rcp; rcp01 -rlogin rlogin01 rsh rsh01 sendfile export TCbin=$LTPROOT/testcases/network/tcp_cmds/sendfile; sendfile01 tcpdump tcpdump01
testcases/network/tcp_cmds/rlogin/Makefile deleted +0 -31
@@ -1,31 +0,0 @@ -# -# network/tcp_cmds/rlogin testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := rlogin01 - -MAKE_TARGETS := - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/rlogin/rlogin01 deleted +0 -90
90 lines not on this page · raw message
Signature · 1 line
2.14.2
RFC PATCH 4/7 net/tcp_cmds: Remove rsh test
In reply to Petr Vorelrsh is way too old to bother to test it and it has been deprecated for many years in favour of ssh.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/rsh/Makefile | 31 --------- testcases/network/tcp_cmds/rsh/rsh01 | 115 -------------------------------- 3 files changed, 147 deletions(-) delete mode 100644 testcases/network/tcp_cmds/rsh/Makefile delete mode 100755 testcases/network/tcp_cmds/rsh/rsh01
runtest/net.tcp_cmds +0 -1
@@ -13,7 +13,6 @@ netstat netstat01 ping01 ping01.sh ping02 ping02.sh rcp export TCbin=$LTPROOT/testcases/network/tcp_cmds/rcp; rcp01 -rsh rsh01 sendfile export TCbin=$LTPROOT/testcases/network/tcp_cmds/sendfile; sendfile01 tcpdump tcpdump01 telnet telnet01
testcases/network/tcp_cmds/rsh/Makefile deleted +0 -31
@@ -1,31 +0,0 @@ -# -# network/tcp_cmds/rsh testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := rsh01 - -MAKE_TARGETS := - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/rsh/rsh01 deleted +0 -115
115 lines not on this page · raw message
Signature · 1 line
2.14.2
RFC PATCH 5/7 net/tcp_cmds: Remove rcp test
In reply to Petr Vorelrcp is way too old to bother to test it as it has been deprecated for many years in favour of scp.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/rcp/Makefile | 30 ------- testcases/network/tcp_cmds/rcp/rcp01 | 144 -------------------------------- 3 files changed, 175 deletions(-) delete mode 100644 testcases/network/tcp_cmds/rcp/Makefile delete mode 100755 testcases/network/tcp_cmds/rcp/rcp01
runtest/net.tcp_cmds +0 -1
@@ -12,7 +12,6 @@ host host01 netstat netstat01 ping01 ping01.sh ping02 ping02.sh -rcp export TCbin=$LTPROOT/testcases/network/tcp_cmds/rcp; rcp01 sendfile export TCbin=$LTPROOT/testcases/network/tcp_cmds/sendfile; sendfile01 tcpdump tcpdump01 telnet telnet01
testcases/network/tcp_cmds/rcp/Makefile deleted +0 -30
@@ -1,30 +0,0 @@ -# -# network/tcp_cmds/rcp testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, September 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/testcases.mk -include $(abs_srcdir)/../Makefile.inc - -INSTALL_TARGETS := rcp01 - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/rcp/rcp01 deleted +0 -144
144 lines not on this page · raw message
Signature · 1 line
2.14.2
RFC PATCH 6/7 net/tcp_cmds: Remove finger test
In reply to Petr Vorelfinger is way too old to bother to test it.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/finger/Makefile | 31 ----- testcases/network/tcp_cmds/finger/finger01 | 203 ----------------------------- 3 files changed, 235 deletions(-) delete mode 100644 testcases/network/tcp_cmds/finger/Makefile delete mode 100755 testcases/network/tcp_cmds/finger/finger01
runtest/net.tcp_cmds +0 -1
@@ -6,7 +6,6 @@ ipneigh01 ipneigh01.sh arping01 arping01.sh clockdiff01 clockdiff01.sh echo export TCbin=$LTPROOT/testcases/network/tcp_cmds/echo; echo01 -finger finger01 ftp export TCbin=$LTPROOT/testcases/network/tcp_cmds/ftp; ftp01 host host01 netstat netstat01
testcases/network/tcp_cmds/finger/Makefile deleted +0 -31
@@ -1,31 +0,0 @@ -# -# network/tcp_cmds/finger testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/env_pre.mk - -INSTALL_TARGETS := finger01 - -MAKE_TARGETS := - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/finger/finger01 deleted +0 -203
203 lines not on this page · raw message
Signature · 1 line
2.14.2
RFC PATCH 7/7 net/tcp_cmds: Remove echo test
In reply to Petr VorelPurpose of the test is to stresses the inetd/xinetd daemon using the echo service.
Echo service is usually disabled in distros these days and there is another test testing xinetd.
--- runtest/net.tcp_cmds | 1 - testcases/network/tcp_cmds/echo/Makefile | 38 --- testcases/network/tcp_cmds/echo/createfile.c | 52 ---- testcases/network/tcp_cmds/echo/echo01 | 127 --------- testcases/network/tcp_cmds/echo/echoes.c | 375 --------------------------- 5 files changed, 593 deletions(-) delete mode 100644 testcases/network/tcp_cmds/echo/Makefile delete mode 100644 testcases/network/tcp_cmds/echo/createfile.c delete mode 100755 testcases/network/tcp_cmds/echo/echo01 delete mode 100644 testcases/network/tcp_cmds/echo/echoes.c
runtest/net.tcp_cmds +0 -1
@@ -5,7 +5,6 @@ ipneigh01 ipneigh01.sh arping01 arping01.sh clockdiff01 clockdiff01.sh -echo export TCbin=$LTPROOT/testcases/network/tcp_cmds/echo; echo01 ftp export TCbin=$LTPROOT/testcases/network/tcp_cmds/ftp; ftp01 host host01 netstat netstat01
testcases/network/tcp_cmds/echo/Makefile deleted +0 -38
@@ -1,38 +0,0 @@ -# -# network/tcp_cmds/echo testcases Makefile. -# -# Copyright (C) 2009, Cisco Systems Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Ngie Cooper, July 2009 -# - -top_srcdir ?= ../../../.. - -include $(top_srcdir)/include/mk/testcases.mk - -CPPFLAGS += -DDEBUG -I$(abs_srcdir)/../include - -INSTALL_TARGETS := echo01 - -MAKE_TARGETS := echoes echoes6 createfile - -%6: CPPFLAGS += -DINET6 - -%6.o: %.c - $(COMPILE.c) $(OUTPUT_OPTION) $< - -include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/echo/createfile.c deleted +0 -52
52 lines not on this page · raw message
testcases/network/tcp_cmds/echo/echo01 deleted +0 -127
127 lines not on this page · raw message
testcases/network/tcp_cmds/echo/echoes.c deleted +0 -375
375 lines not on this page · raw message
Signature · 1 line
2.14.2
cover Remove network test for ancient software
In reply to Petr Vorelfwiw, rsh/rcp are still used in the embedded world where security is not a concern, but speed/size matters much more (e.g. development) -mike
Quoted 54 lines · Petr Vorel
Hi,
I'm proposing to remove tests for ancient software.
I don't think we should be maintaining tests for something which hardly anyone use.Kind regards,
PetrPetr Vorel (7):
net/tcp_cmds: Remove rwho test
net/tcp_cmds: Remove rdist test
net/tcp_cmds: Remove rlogin test
net/tcp_cmds: Remove rsh test
net/tcp_cmds: Remove rcp test
net/tcp_cmds: Remove finger test
net/tcp_cmds: Remove echo testruntest/net.tcp_cmds | 7 - testcases/network/tcp_cmds/echo/Makefile | 38 --- testcases/network/tcp_cmds/echo/createfile.c | 52 ---- testcases/network/tcp_cmds/echo/echo01 | 127 --------- testcases/network/tcp_cmds/echo/echoes.c | 375 --------------------------- testcases/network/tcp_cmds/finger/Makefile | 31 --- testcases/network/tcp_cmds/finger/finger01 | 203 --------------- testcases/network/tcp_cmds/rcp/Makefile | 30 --- testcases/network/tcp_cmds/rcp/rcp01 | 144 ---------- testcases/network/tcp_cmds/rdist/Makefile | 30 --- testcases/network/tcp_cmds/rdist/rdist01 | 187 ------------- testcases/network/tcp_cmds/rlogin/Makefile | 31 --- testcases/network/tcp_cmds/rlogin/rlogin01 | 90 ------- testcases/network/tcp_cmds/rsh/Makefile | 31 --- testcases/network/tcp_cmds/rsh/rsh01 | 115 -------- testcases/network/tcp_cmds/rwho/Makefile | 31 --- testcases/network/tcp_cmds/rwho/rwho01 | 91 ------- 17 files changed, 1613 deletions(-) delete mode 100644 testcases/network/tcp_cmds/echo/Makefile delete mode 100644 testcases/network/tcp_cmds/echo/createfile.c delete mode 100755 testcases/network/tcp_cmds/echo/echo01 delete mode 100644 testcases/network/tcp_cmds/echo/echoes.c delete mode 100644 testcases/network/tcp_cmds/finger/Makefile delete mode 100755 testcases/network/tcp_cmds/finger/finger01 delete mode 100644 testcases/network/tcp_cmds/rcp/Makefile delete mode 100755 testcases/network/tcp_cmds/rcp/rcp01 delete mode 100644 testcases/network/tcp_cmds/rdist/Makefile delete mode 100755 testcases/network/tcp_cmds/rdist/rdist01 delete mode 100644 testcases/network/tcp_cmds/rlogin/Makefile delete mode 100755 testcases/network/tcp_cmds/rlogin/rlogin01 delete mode 100644 testcases/network/tcp_cmds/rsh/Makefile delete mode 100755 testcases/network/tcp_cmds/rsh/rsh01 delete mode 100644 testcases/network/tcp_cmds/rwho/Makefile delete mode 100755 testcases/network/tcp_cmds/rwho/rwho01
Quoted 4 lines
--
2.14.2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20171018/920121b5/attachment.html>
cover Remove network test for ancient software
Hi Mike,
Quoted 2 lines
fwiw, rsh/rcp are still used in the embedded world where security is not a concern, but speed/size matters much more (e.g. development)
I used dropbear even on quite low power arm. But, ok I'd agree that rsh/rcp can be still worth to test. But I'd really drop the rest (rwho, rdist, rlogin, finger, echo).
Quoted 1 line
-mike
Kind regards,
Petr
cover Remove network test for ancient software
In reply to Mike FrysingerHi!
Quoted 2 lines
fwiw, rsh/rcp are still used in the embedded world where security is not a concern, but speed/size matters much more (e.g. development)
The question is how much do we care about maintaing the testcases for these. I guess that rsh and rcp may be still useful in a certain cases but for a general usage it has been replaced by scp and ssh long time ago.
Signature · 2 lines
Cyril Hrubis [email protected]