Skip to contentSkip to conversation

libsepol: require threads

PATCH Superseded Adam Duskett 3 participants 3 messages Oct 25, 2017 – Oct 27, 2017

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 libsepol: require threads

libsepol 2.7 now uses pthreads.h

---
Changes v1 -> v2:
- Added thread dependency to semodule-utils (Arnout)

Changes v2 -> v3:
- Added explinations for dependencies (Matt Webber)

 package/libsepol/Config.in       | 1 +
 package/semodule-utils/Config.in | 4 ++++
 2 files changed, 5 insertions(+)
package/libsepol/Config.in +1 -0
index f92af52072..f17eb47448 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBSEPOL
 	bool "libsepol"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # pthread
 	help
 	  Libsepol is the binary policy manipulation library. It doesn't
 	  depend upon or use any of the other SELinux components.
package/semodule-utils/Config.in +4 -0
index d9cb928c4c..38e043dc2c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_SEMODULE_UTILS
 	bool "semodule-utils"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libsepol
 	select BR2_PACKAGE_LIBSEPOL
 	help
 	  semodule-utils is a package that contains tools for handling
@@ -13,3 +14,6 @@ config BR2_PACKAGE_SEMODULE_UTILS
 	  * semodule_package - Create a SELinux policy module package.
 
 	  https://github.com/SELinuxProject/selinux/wiki/Releases
+
+comment "semodule-utils needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.13.6
#1 lore raw

PATCH v3 1/1 libsepol: require threads

Adam,

Quoted 10 lines · Adam Duskett

libsepol 2.7 now uses pthreads.h

---
Changes v1 -> v2:
- Added thread dependency to semodule-utils (Arnout)

Changes v2 -> v3:
- Added explinations for dependencies (Matt Webber)

minor nit, spelling of 'explanations' above

Quoted 40 lines
 package/libsepol/Config.in       | 1 +
 package/semodule-utils/Config.in | 4 ++++
 2 files changed, 5 insertions(+)
package/libsepol/Config.in +1 -0
index f92af52072..f17eb47448 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBSEPOL
        bool "libsepol"
+       depends on BR2_TOOLCHAIN_HAS_THREADS # pthread
        help
          Libsepol is the binary policy manipulation library. It doesn't
          depend upon or use any of the other SELinux components.
package/semodule-utils/Config.in +4 -1
index d9cb928c4c..38e043dc2c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_SEMODULE_UTILS
        bool "semodule-utils"
+       depends on BR2_TOOLCHAIN_HAS_THREADS # libsepol
        select BR2_PACKAGE_LIBSEPOL
        help
          semodule-utils is a package that contains tools for handling
@@ -13,3 +14,6 @@ config BR2_PACKAGE_SEMODULE_UTILS
          * semodule_package - Create a SELinux policy module package.
 
          https://github.com/SELinuxProject/selinux/wiki/Releases
+
+comment "semodule-utils needs a toolchain w/ threads"
+       depends on !BR2_TOOLCHAIN_HAS_THREADS
--

2.13.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 8 lines
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.
#2 lore raw

PATCH v3 1/1 libsepol: require threads

In reply to Adam Duskett

Hello,

package/libsepol/Config.in line 6

Quoted 11 lines · Adam Duskett
package/libsepol/Config.in +1 -0
index f92af52072..f17eb47448 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBSEPOL
 	bool "libsepol"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # pthread
 	help
 	  Libsepol is the binary policy manipulation library. It doesn't
 	  depend upon or use any of the other SELinux components.

So a Config.in comment needs to be added here.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com