Skip to contentSkip to conversation

drm/amdgpu: Remove immutable flag from freesync_capable property

PATCH In review Harry Wentland 2 participants 2 messages Oct 25, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: Remove immutable flag from freesync_capable property

Atomic drivers should not use legacy properties but atomic properties don't support the immutable flag. Remove the immutable flag for now.

This will be followed by a bunch of DC patches to start treating freesync_capable as an atomic property on a connector_state.

Eventually we'll want to remove the these properties and replace them with new atomic adaptive sync properties that we define in DRM.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +1 -1
index 6744e0cd1373..d704a45c866b 100644
@@ -638,7 +638,7 @@ int amdgpu_modeset_create_props(struct amdgpu_device *adev)
 			return -ENOMEM;
 		adev->mode_info.freesync_capable_property =
 			drm_property_create_bool(adev->ddev,
-						 DRM_MODE_PROP_IMMUTABLE,
+						 0,
 						 "freesync_capable");
 		if (!adev->mode_info.freesync_capable_property)
 			return -ENOMEM;
Signature · 6 lines
2.14.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20171025153125.27521-1-harry.wentland-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 19 lines · Harry Wentland

Atomic drivers should not use legacy properties but atomic properties don't support the immutable flag. Remove the immutable flag for now.

This will be followed by a bunch of DC patches to start treating freesync_capable as an atomic property on a connector_state.

Eventually we'll want to remove the these properties and replace them with new atomic adaptive sync properties that we define in DRM.

---
  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +0 -0
index 6744e0cd1373..d704a45c866b 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_display.c int amdgpu_modeset_create_props(struct amdgpu_device *adev) · line 644

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +1 -1
@@ -638,7 +638,7 @@ int amdgpu_modeset_create_props(struct amdgpu_device *adev)
  			return -ENOMEM;
  		adev->mode_info.freesync_capable_property =
  			drm_property_create_bool(adev->ddev,
-						 DRM_MODE_PROP_IMMUTABLE,
+						 0,
  						 "freesync_capable");
  		if (!adev->mode_info.freesync_capable_property)
  			return -ENOMEM;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx