Skip to contentSkip to conversation

usb: remove some unused code

PATCH Superseded Alex Elder 3 participants 8 messages Oct 25, 2017 – Oct 26, 2017

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Alex Elder

author
#0 lore raw

cover usb: remove some unused code

This series deletes some Qualcomm USB code is no longer needed by any Qualcomm hardware.

-Alex
Alex Elder (3):
usb: host: remove ehci-msm.c
usb: phy: remove phy-msm-usb.c
usb: phy: remove phy-qcom-8x16-usb.c

 drivers/usb/host/Makefile           |    1 -
 drivers/usb/host/ehci-msm.c         |  265 -----
 drivers/usb/phy/Makefile            |    2 -
 drivers/usb/phy/phy-msm-usb.c       | 2085 -----------------------------------
 drivers/usb/phy/phy-qcom-8x16-usb.c |  366 ------
 5 files changed, 2719 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c
 delete mode 100644 drivers/usb/phy/phy-qcom-8x16-usb.c
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 1/3 usb: host: remove ehci-msm.c

No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it.

---
 drivers/usb/host/Makefile   |   1 -
 drivers/usb/host/ehci-msm.c | 265 --------------------------------------------
 2 files changed, 266 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c
drivers/usb/host/Makefile +0 -1
index cf2691fffcc0..1645c549bdb1 100644
@@ -39,7 +39,6 @@ obj-$(CONFIG_USB_EHCI_HCD_SPEAR)	+= ehci-spear.o
 obj-$(CONFIG_USB_EHCI_HCD_STI)	+= ehci-st.o
 obj-$(CONFIG_USB_EHCI_EXYNOS)	+= ehci-exynos.o
 obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
-obj-$(CONFIG_USB_EHCI_MSM)	+= ehci-msm.o
 obj-$(CONFIG_USB_EHCI_TEGRA)	+= ehci-tegra.o
 obj-$(CONFIG_USB_W90X900_EHCI)	+= ehci-w90x900.o
 
drivers/usb/host/ehci-msm.c deleted +0 -265

265 lines not on this page · raw message

Signature · 1 line
2.11.0
#2 lore raw

Re: [PATCH 1/3] usb: host: remove ehci-msm.c

Hi,

Quoted 17 lines · Alex Elder

No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it.

---
 drivers/usb/host/Makefile   |   1 -
 drivers/usb/host/ehci-msm.c | 265 --------------------------------------------
 2 files changed, 266 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c
drivers/usb/host/Makefile +0 -0
index cf2691fffcc0..1645c549bdb1 100644

drivers/usb/host/Makefile obj-$(CONFIG_USB_EHCI_HCD_SPEAR) += ehci-spear.o · line 42

Quoted 4 lines
drivers/usb/host/Makefile +0 -1
@@ -39,7 +39,6 @@ obj-$(CONFIG_USB_EHCI_HCD_SPEAR)	+= ehci-spear.o
 obj-$(CONFIG_USB_EHCI_HCD_STI)	+= ehci-st.o
 obj-$(CONFIG_USB_EHCI_EXYNOS)	+= ehci-exynos.o
 obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
-obj-$(CONFIG_USB_EHCI_MSM)	+= ehci-msm.o

drivers/usb/host/Kconfig also needs update?

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#3 lore raw

Re: [PATCH 1/3] usb: host: remove ehci-msm.c

Quoted 1 line · Manu Gautam

Hi,

I'll re-send with the kconfig updates pointed out by you and Felipe Balbi. Sorry about that.

-Alex

Quoted 26 lines · Alex Elder
Quoted 17 lines

No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it.

---
 drivers/usb/host/Makefile   |   1 -
 drivers/usb/host/ehci-msm.c | 265 --------------------------------------------
 2 files changed, 266 deletions(-)
 delete mode 100644 drivers/usb/host/ehci-msm.c
drivers/usb/host/Makefile +0 -0
index cf2691fffcc0..1645c549bdb1 100644

drivers/usb/host/Makefile obj-$(CONFIG_USB_EHCI_HCD_SPEAR) += ehci-spear.o · line 42

Quoted 4 lines
drivers/usb/host/Makefile +0 -1
@@ -39,7 +39,6 @@ obj-$(CONFIG_USB_EHCI_HCD_SPEAR)	+= ehci-spear.o
 obj-$(CONFIG_USB_EHCI_HCD_STI)	+= ehci-st.o
 obj-$(CONFIG_USB_EHCI_EXYNOS)	+= ehci-exynos.o
 obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
-obj-$(CONFIG_USB_EHCI_MSM)	+= ehci-msm.o

drivers/usb/host/Kconfig also needs update?

author
#4 lore raw

PATCH 2/3 usb: phy: remove phy-msm-usb.c

In reply to Alex Elder

No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support any more, so remove the code.

---
 drivers/usb/phy/Makefile      |    1 -
 drivers/usb/phy/phy-msm-usb.c | 2085 -----------------------------------------
 2 files changed, 2086 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c
drivers/usb/phy/Makefile +0 -1
index e7c9ca8cafb0..61013f38abbe 100644
@@ -18,7 +18,6 @@ obj-$(CONFIG_TWL6030_USB)		+= phy-twl6030-usb.o
 obj-$(CONFIG_USB_EHCI_TEGRA)		+= phy-tegra-usb.o
 obj-$(CONFIG_USB_GPIO_VBUS)		+= phy-gpio-vbus-usb.o
 obj-$(CONFIG_USB_ISP1301)		+= phy-isp1301.o
-obj-$(CONFIG_USB_MSM_OTG)		+= phy-msm-usb.o
 obj-$(CONFIG_USB_QCOM_8X16_PHY)	+= phy-qcom-8x16-usb.o
 obj-$(CONFIG_USB_MV_OTG)		+= phy-mv-usb.o
 obj-$(CONFIG_USB_MXS_PHY)		+= phy-mxs-usb.o
drivers/usb/phy/phy-msm-usb.c deleted +0 -2085

2,085 lines not on this page · raw message

Signature · 1 line
2.11.0
#5 lore raw

Re: [PATCH 2/3] usb: phy: remove phy-msm-usb.c

Hi,

Quoted 18 lines · Alex Elder

No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support any more, so remove the code.

---
 drivers/usb/phy/Makefile      |    1 -
 drivers/usb/phy/phy-msm-usb.c | 2085 -----------------------------------------
 2 files changed, 2086 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-msm-usb.c
drivers/usb/phy/Makefile +0 -0
index e7c9ca8cafb0..61013f38abbe 100644

drivers/usb/phy/Makefile obj-$(CONFIG_TWL6030_USB) += phy-twl6030-usb.o · line 21

Quoted 4 lines
drivers/usb/phy/Makefile +0 -1
@@ -18,7 +18,6 @@ obj-$(CONFIG_TWL6030_USB)		+= phy-twl6030-usb.o
 obj-$(CONFIG_USB_EHCI_TEGRA)		+= phy-tegra-usb.o
 obj-$(CONFIG_USB_GPIO_VBUS)		+= phy-gpio-vbus-usb.o
 obj-$(CONFIG_USB_ISP1301)		+= phy-isp1301.o
-obj-$(CONFIG_USB_MSM_OTG)		+= phy-msm-usb.o

drivers/usb/phy/Kconfig update?

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#6 lore raw

PATCH 3/3 usb: phy: remove phy-qcom-8x16-usb.c

In reply to Alex Elder

No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver support any more, so remove the code.

---
 drivers/usb/phy/Makefile            |   1 -
 drivers/usb/phy/phy-qcom-8x16-usb.c | 366 ------------------------------------
 2 files changed, 367 deletions(-)
 delete mode 100644 drivers/usb/phy/phy-qcom-8x16-usb.c
drivers/usb/phy/Makefile +0 -1
index 61013f38abbe..8beefb7f2777 100644
@@ -18,7 +18,6 @@ obj-$(CONFIG_TWL6030_USB)		+= phy-twl6030-usb.o
 obj-$(CONFIG_USB_EHCI_TEGRA)		+= phy-tegra-usb.o
 obj-$(CONFIG_USB_GPIO_VBUS)		+= phy-gpio-vbus-usb.o
 obj-$(CONFIG_USB_ISP1301)		+= phy-isp1301.o
-obj-$(CONFIG_USB_QCOM_8X16_PHY)	+= phy-qcom-8x16-usb.o
 obj-$(CONFIG_USB_MV_OTG)		+= phy-mv-usb.o
 obj-$(CONFIG_USB_MXS_PHY)		+= phy-mxs-usb.o
 obj-$(CONFIG_USB_ULPI)			+= phy-ulpi.o
drivers/usb/phy/phy-qcom-8x16-usb.c deleted +0 -366

366 lines not on this page · raw message

Signature · 1 line
2.11.0