qt5base: remove nostrip qmake.conf config option
PATCH 1/1 qt5base: remove nostrip qmake.conf config option
Re-enables the qmake default behaviour for qmake projects living out-side of buildroot (debug build with-out strip, release build with strip).
--- package/qt5/qt5base/qmake.conf | 1 - 1 file changed, 1 deletion(-)
package/qt5/qt5base/qmake.conf +0 -1
@@ -16,7 +16,6 @@ QMAKE_CXX = $${CROSS_COMPILE}g++ QMAKE_CFLAGS += $${BR_COMPILER_CFLAGS} QMAKE_CXXFLAGS += $${BR_COMPILER_CXXFLAGS} QMAKE_CXXFLAGS_RELEASE += -O3 -CONFIG += nostrip QMAKE_LIBS += -lrt -lpthread -ldl QMAKE_CFLAGS_ISYSTEM =
Signature · 1 line
2.14.2
PATCH 1/1 qt5base: remove nostrip qmake.conf config option
Hello,
Quoted 5 lines · Peter Seiderer
Re-enables the qmake default behaviour for qmake projects living out-side of buildroot (debug build with-out strip, release build with strip).
Signed-off-by Peter Seiderer <[email protected]>
What is the reasoning for this?
I think we do want qmake to *not* strip anything, and leave it to Buildroot's BR2_STRIP_strip option to decide whether stripping should happen or not.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 qt5base: remove nostrip qmake.conf config option
Hello Thomas,
Quoted 7 lines · Thomas Petazzoni
Hello,
Quoted 4 lines · Peter Seiderer
Re-enables the qmake default behaviour for qmake projects living out-side of buildroot (debug build with-out strip, release build with strip).
Quoted 7 lines
Quoted 1 line
Signed-off-by Peter Seiderer <[email protected]>What is the reasoning for this?
I think we do want qmake to *not* strip anything, and leave it to Buildroot's
BR2_STRIP_stripoption to decide whether stripping should happen or not.
Mhhh, I see the reason for the in-buildroot usage of qmake, but still a bit annoying for out-of-buildroot usage (but maybe a 'qmake CONIFG-=nostrip' works here), would still prefer to keep the simple/original qmake default and (maybe) add an additional 'CONFIG+=nostrip' to all in-buildroot qmake usages?
Regards,
Peter
Quoted 4 lines
Thanks!
Thomas
PATCH 1/1 qt5base: remove nostrip qmake.conf config option
Hello,
Quoted 7 lines · Peter Seiderer
Quoted 3 lines
I think we do want qmake to *not* strip anything, and leave it to Buildroot's
BR2_STRIP_stripoption to decide whether stripping should happen or not.Mhhh, I see the reason for the in-buildroot usage of qmake, but still a bit annoying for out-of-buildroot usage (but maybe a 'qmake CONIFG-=nostrip' works here),
Hum, OK, I see the problem.
Quoted 3 lines
would still prefer to keep the simple/original qmake default and (maybe) add an additional 'CONFIG+=nostrip' to all in-buildroot qmake usages?
Having to explicitly specify CONFIG+=nostrip to each and every qmake based package is not going to be very nice. Can we have a Buildroot specific qmake.conf that inherits a common one, and is used by Buildroot when building qmake packages ?
Or is it enough to just specify CONFIG+=nostrip in $(QT_QMAKE) and $(QT5_QMAKE) ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com