Skip to contentSkip to conversation

net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Oct 28, 2017 – Nov 1, 2017

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header

Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 net/decnet/dn_nsp_out.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
net/decnet/dn_nsp_out.c +2 -5
index e50a4ad..56a52a0 100644
@@ -313,11 +313,8 @@ static __le16 *dn_mk_ack_header(struct sock *sk, struct sk_buff *skb, unsigned c
 	ackcrs |= 0x8000;
 
 	/* If this is an "other data/ack" message, swap acknum and ackcrs */
-	if (other) {
-		unsigned short tmp = acknum;
-		acknum = ackcrs;
-		ackcrs = tmp;
-	}
+	if (other)
+		swap(acknum, ackcrs);
 
 	/* Set "cross subchannel" bit in ackcrs */
 	ackcrs |= 0x2000;
Signature · 1 line
2.7.4