Skip to contentSkip to conversation

ceph: remove the bump of i_version

PATCH In review Jeff Layton 2 participants 2 messages Oct 30, 2017 – Oct 31, 2017 Ceph client

lore
Share & tools
lore

Jeff Layton

author
#0 lore raw

PATCH 1/1 ceph: remove the bump of i_version

From: Jeff Layton <[email protected]>

Eventually, we'll want to wire cephfs up to use the change attribute that the cluster tracks instead, but for now this is unneeded.

Signed-off-by Jeff Layton <[email protected]>
---
 fs/ceph/inode.c | 1 -
 1 file changed, 1 deletion(-)
fs/ceph/inode.c +0 -1
index 373dab5173ca..8aae7200a425 100644
@@ -785,7 +785,6 @@ static int fill_inode(struct inode *inode, struct page *locked_page,
 
 	/* update inode */
 	ci->i_version = le64_to_cpu(info->version);
-	inode->i_version++;
 	inode->i_rdev = le32_to_cpu(info->rdev);
 	inode->i_blkbits = fls(le32_to_cpu(info->layout.fl_stripe_unit)) - 1;
Signature · 1 line
2.13.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines · Jeff Layton

From: Jeff Layton <[email protected]>

Eventually, we'll want to wire cephfs up to use the change attribute that the cluster tracks instead, but for now this is unneeded.

Signed-off-by Jeff Layton <[email protected]>

---
fs/ceph/inode.c | 1 -

1 file changed, 1 deletion(-)
fs/ceph/inode.c +0 -0
index 373dab5173ca..8aae7200a425 100644

fs/ceph/inode.c static int fill_inode(struct inode *inode, struct page *locked_page, · line 790

Quoted 7 lines
fs/ceph/inode.c +0 -1
@@ -785,7 +785,6 @@ static int fill_inode(struct inode *inode, struct page *locked_page,
 
 	/* update inode */
 	ci->i_version = le64_to_cpu(info->version);
-	inode->i_version++;
 	inode->i_rdev = le32_to_cpu(info->rdev);
 	inode->i_blkbits = fls(le32_to_cpu(info->layout.fl_stripe_unit)) - 1;
Reviewed-by "Yan, Zheng" <[email protected]>
Quoted 3 lines
Signature · 1 line
2.13.6