ecryptfs: remove unnecessary i_version bump
Subsystems (2)
PATCH 1/1 ecryptfs: remove unnecessary i_version bump
From: Jeff Layton <[email protected]>
There is no need to bump the i_version counter here, as ecryptfs does not set the MS_I_VERSION flag, and doesn't use it internally. It also only bumps it when the inode is instantiated, which doesn't make much sense.
--- fs/ecryptfs/inode.c | 1 - 1 file changed, 1 deletion(-)
fs/ecryptfs/inode.c +0 -1
@@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque)/* i_size will be overwritten for encrypted regular files */ fsstack_copy_inode_size (inode, lower_inode); inode->i_ino = lower_inode->i_ino; - inode->i_version++; inode->i_mapping->a_ops = &ecryptfs_aops;if (S_ISLNK (inode->i_mode))
Signature · 1 line
2.13.6
Quoted 4 lines · Jeff Layton
From: Jeff Layton <[email protected]>
There is no need to bump the
i_versioncounter here, as ecryptfs does not set theMS_I_VERSIONflag, and doesn't use it internally. It also
My apologies, I've been sitting on this patch for a while now. That should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing that up before merge, or would you like me to resend?
Quoted 20 lines
only bumps it when the inode is instantiated, which doesn't make much sense.
Signed-off-by Jeff Layton <[email protected]>--- fs/ecryptfs/inode.c | 1 - 1 file changed, 1 deletion(-)fs/ecryptfs/inode.c +0
-1@@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque)/* i_size will be overwritten for encrypted regular files */ fsstack_copy_inode_size (inode, lower_inode); inode->i_ino = lower_inode->i_ino; - inode->i_version++; inode->i_mapping->a_ops = &ecryptfs_aops;if (S_ISLNK (inode->i_mode))
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 9 lines · Jeff Layton
Quoted 4 lines · Jeff Layton
From: Jeff Layton <[email protected]>
There is no need to bump the
i_versioncounter here, as ecryptfs does not set theMS_I_VERSIONflag, and doesn't use it internally. It alsoMy apologies, I've been sitting on this patch for a while now. That should be changed to the
SB_I_VERSIONflag. Tyler, do you mind fixing that up before merge, or would you like me to resend?
That's no problem. Thanks for the patch! It looks good to me and I'll take it through my tree.
Tyler
Quoted 22 lines
Quoted 21 lines
only bumps it when the inode is instantiated, which doesn't make much sense.
Signed-off-by Jeff Layton <[email protected]>--- fs/ecryptfs/inode.c | 1 - 1 file changed, 1 deletion(-)fs/ecryptfs/inode.c +0
-1@@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque)/* i_size will be overwritten for encrypted regular files */ fsstack_copy_inode_size (inode, lower_inode); inode->i_ino = lower_inode->i_ino; - inode->i_version++; inode->i_mapping->a_ops = &ecryptfs_aops;if (S_ISLNK (inode->i_mode))