hpfs: don't bother with the i_version counter or f_version

PATCH New Jeff Layton 1 participant 1 message Oct 30, 2017

Subsystems (2)

VFS Hpfs filesystem

lore

Share & tools

lore

Jeff Layton

author

2017-10-30 15:14 UTC #0 lore raw

PATCH 1/1 hpfs: don't bother with the i_version counter or f_version

From: Jeff Layton <[email protected]>

HPFS does not set SB_I_VERSION and does not use the i_version counter internally.

Signed-off-by Jeff Layton <[email protected]>

---
 fs/hpfs/dir.c   | 1 -
 fs/hpfs/dnode.c | 2 --
 fs/hpfs/super.c | 1 -
 3 files changed, 4 deletions(-)

fs/hpfs/dir.c +0 -1

index fa6bbb4f509f..cc0193891347 100644
@@ -149,7 +149,6 @@ static int hpfs_readdir(struct file *file, struct dir_context *ctx)
 			if (unlikely(ret < 0))
 				goto out;
 			ctx->pos = ((loff_t) hpfs_de_as_down_as_possible(inode->i_sb, hpfs_inode->i_dno) << 4) + 1;
-			file->f_version = inode->i_version;
 		}
 		next_pos = ctx->pos;
 		if (!(de = map_pos_dirent(inode, &next_pos, &qbh))) {

fs/hpfs/dnode.c +0 -2

index 86ab7e790b4e..454acb0a009a 100644
@@ -418,7 +418,6 @@ int hpfs_add_dirent(struct inode *i,
 		c = 1;
 		goto ret;
 	}	
-	i->i_version++;
 	c = hpfs_add_to_dnode(i, dno, name, namelen, new_de, 0);
 	ret:
 	return c;

@@ -725,7 +724,6 @@ int hpfs_remove_dirent(struct inode *i, dnode_secno dno, struct hpfs_dirent *de,
 			return 2;
 		}
 	}
-	i->i_version++;
 	for_all_poss(i, hpfs_pos_del, (t = get_pos(dnode, de)) + 1, 1);
 	hpfs_delete_de(i->i_sb, dnode, de);
 	hpfs_mark_4buffers_dirty(qbh);

fs/hpfs/super.c +0 -1

index 1516fb4e28f4..5b2d84a719ef 100644
@@ -235,7 +235,6 @@ static struct inode *hpfs_alloc_inode(struct super_block *sb)
 	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
 	if (!ei)
 		return NULL;
-	ei->vfs_inode.i_version = 1;
 	return &ei->vfs_inode;
 }

Signature · 1 line

2.13.6