Skip to contentSkip to conversation

reiserfs: remove unneeded i_version bump

PATCH In review Jeff Layton 2 participants 2 messages Oct 30, 2017 – Nov 15, 2017 VFS

lore
Share & tools
lore

Jeff Layton

author
#0 lore raw

PATCH 1/1 reiserfs: remove unneeded i_version bump

From: Jeff Layton <[email protected]>

The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it.

Signed-off-by Jeff Layton <[email protected]>
---
 fs/reiserfs/super.c | 1 -
 1 file changed, 1 deletion(-)
fs/reiserfs/super.c +0 -1
index 5464ec517702..4885c7b6e44f 100644
@@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
 		return err;
 	if (inode->i_size < off + len - towrite)
 		i_size_write(inode, off + len - towrite);
-	inode->i_version++;
 	inode->i_mtime = inode->i_ctime = current_time(inode);
 	mark_inode_dirty(inode);
 	return len - towrite;
Signature · 1 line
2.13.6
reviewer
#1 lore raw
Quoted 6 lines · Jeff Layton

From: Jeff Layton <[email protected]>

The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it.

Signed-off-by Jeff Layton <[email protected]>

Thanks! I've added this patch to my tree.

Honza

Quoted 19 lines
---
 fs/reiserfs/super.c | 1 -
 1 file changed, 1 deletion(-)
fs/reiserfs/super.c +0 -1
index 5464ec517702..4885c7b6e44f 100644
@@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
 		return err;
 	if (inode->i_size < off + len - towrite)
 		i_size_write(inode, off + len - towrite);
-	inode->i_version++;
 	inode->i_mtime = inode->i_ctime = current_time(inode);
 	mark_inode_dirty(inode);
 	return len - towrite;
Signature · 1 line
2.13.6
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR