Skip to contentSkip to conversation

kconfig: kill off GENERIC_IO option

PATCH In review Rob Herring 3 participants 5 messages Oct 16, 2017 – Oct 31, 2017

Subsystems (3)
Library code Memory technology devices (MTD) User-mode Linux (UML)
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 kconfig: kill off GENERIC_IO option

The GENERIC_IO option is set for every architecture except tile and score as those define NO_IOMEM. The option only controls visibility of CONFIG_MTD which doesn't appear to be necessary for any reason, so let's just remove GENERIC_IO.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Dike <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Brian Norris <[email protected]>
Cc Boris Brezillon <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Cyrille Pitchen <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
---
 arch/um/Kconfig.common | 1 -
 drivers/mtd/Kconfig    | 1 -
 lib/Kconfig            | 4 ----
 3 files changed, 6 deletions(-)
arch/um/Kconfig.common +0 -1
index 85f6dd204ab6..5514ec52108f 100644
@@ -9,7 +9,6 @@ config UML
 	select HAVE_DEBUG_KMEMLEAK
 	select GENERIC_IRQ_SHOW
 	select GENERIC_CPU_DEVICES
-	select GENERIC_IO
 	select GENERIC_CLOCKEVENTS
 	select HAVE_GCC_PLUGINS
 	select TTY # Needed for line.c
drivers/mtd/Kconfig +0 -1
index 5a2d71729b9a..2a8ac6829d42 100644
@@ -1,6 +1,5 @@
 menuconfig MTD
 	tristate "Memory Technology Device (MTD) support"
-	depends on GENERIC_IO
 	help
 	  Memory Technology Devices are flash, RAM and similar chips, often
 	  used for solid state file systems on embedded devices. This option
lib/Kconfig +0 -4
index b1445b22a6de..994fa37a1d96 100644
@@ -46,10 +46,6 @@ config GENERIC_IOMAP
 	bool
 	select GENERIC_PCI_IOMAP
 
-config GENERIC_IO
-	bool
-	default n
-
 config STMP_DEVICE
 	bool
Signature · 1 line
2.11.0
maintainer Acked-by on v1 1/1
#1 lore raw

Am Dienstag, 17. Oktober 2017, 00:16:31 CEST schrieb Rob Herring:

Quoted 16 lines

The GENERIC_IO option is set for every architecture except tile and score as those define NO_IOMEM. The option only controls visibility of CONFIG_MTD which doesn't appear to be necessary for any reason, so let's just remove GENERIC_IO.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Dike <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Brian Norris <[email protected]>
Cc Boris Brezillon <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Cyrille Pitchen <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Quoted 5 lines
---
 arch/um/Kconfig.common | 1 -
 drivers/mtd/Kconfig    | 1 -
 lib/Kconfig            | 4 ----
 3 files changed, 6 deletions(-)
Acked-by Richard Weinberger <[email protected]>

Thanks,
//richard

Acked-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 11 lines · On Mon, 16 Oct 2017 17:16:31 -0500 Rob Herring <[email protected]> wrote:

The GENERIC_IO option is set for every architecture except tile and score as those define NO_IOMEM. The option only controls visibility of CONFIG_MTD which doesn't appear to be necessary for any reason, so let's just remove GENERIC_IO.

Signed-off-by Rob Herring <[email protected]>
Cc Jeff Dike <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Brian Norris <[email protected]>
Cc Boris Brezillon <[email protected]>
Acked-by Boris Brezillon <[email protected]>
Quoted 49 lines
Cc Marek Vasut <[email protected]>
Cc Cyrille Pitchen <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
---
 arch/um/Kconfig.common | 1 -
 drivers/mtd/Kconfig    | 1 -
 lib/Kconfig            | 4 ----
 3 files changed, 6 deletions(-)
arch/um/Kconfig.common +0 -1
index 85f6dd204ab6..5514ec52108f 100644
@@ -9,7 +9,6 @@ config UML
 	select HAVE_DEBUG_KMEMLEAK
 	select GENERIC_IRQ_SHOW
 	select GENERIC_CPU_DEVICES
-	select GENERIC_IO
 	select GENERIC_CLOCKEVENTS
 	select HAVE_GCC_PLUGINS
 	select TTY # Needed for line.c
drivers/mtd/Kconfig +0 -1
index 5a2d71729b9a..2a8ac6829d42 100644
@@ -1,6 +1,5 @@
 menuconfig MTD
 	tristate "Memory Technology Device (MTD) support"
-	depends on GENERIC_IO
 	help
 	  Memory Technology Devices are flash, RAM and similar chips, often
 	  used for solid state file systems on embedded devices. This option
lib/Kconfig +0 -4
index b1445b22a6de..994fa37a1d96 100644
@@ -46,10 +46,6 @@ config GENERIC_IOMAP
 	bool
 	select GENERIC_PCI_IOMAP
 
-config GENERIC_IO
-	bool
-	default n
-
 config STMP_DEVICE
 	bool
author
#3 lore raw
In reply to Rob Herring
Quoted 4 lines · Rob Herring

The GENERIC_IO option is set for every architecture except tile and score as those define NO_IOMEM. The option only controls visibility of CONFIG_MTD which doesn't appear to be necessary for any reason, so let's just remove GENERIC_IO.

Andrew, there's no clear owner for this, can you take it?

Rob

Quoted 59 lines
Signed-off-by Rob Herring <[email protected]>
Cc Jeff Dike <[email protected]>
Cc Richard Weinberger <[email protected]>
Cc David Woodhouse <[email protected]>
Cc Brian Norris <[email protected]>
Cc Boris Brezillon <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Cyrille Pitchen <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
---
 arch/um/Kconfig.common | 1 -
 drivers/mtd/Kconfig    | 1 -
 lib/Kconfig            | 4 ----
 3 files changed, 6 deletions(-)
arch/um/Kconfig.common +0 -1
index 85f6dd204ab6..5514ec52108f 100644
@@ -9,7 +9,6 @@ config UML
        select HAVE_DEBUG_KMEMLEAK
        select GENERIC_IRQ_SHOW
        select GENERIC_CPU_DEVICES
-       select GENERIC_IO
        select GENERIC_CLOCKEVENTS
        select HAVE_GCC_PLUGINS
        select TTY # Needed for line.c
drivers/mtd/Kconfig +0 -1
index 5a2d71729b9a..2a8ac6829d42 100644
@@ -1,6 +1,5 @@
 menuconfig MTD
        tristate "Memory Technology Device (MTD) support"
-       depends on GENERIC_IO
        help
          Memory Technology Devices are flash, RAM and similar chips, often
          used for solid state file systems on embedded devices. This option
lib/Kconfig +0 -5
index b1445b22a6de..994fa37a1d96 100644
@@ -46,10 +46,6 @@ config GENERIC_IOMAP
        bool
        select GENERIC_PCI_IOMAP
 
-config GENERIC_IO
-       bool
-       default n
-
 config STMP_DEVICE
        bool
 
--

2.11.0

maintainer
#4 lore raw

Am Dienstag, 31. Oktober 2017, 20:34:35 CET schrieb Rob Herring:

Quoted 7 lines · Rob Herring
Quoted 4 lines

The GENERIC_IO option is set for every architecture except tile and score as those define NO_IOMEM. The option only controls visibility of CONFIG_MTD which doesn't appear to be necessary for any reason, so let's just remove GENERIC_IO.

Andrew, there's no clear owner for this, can you take it?

Well, I can take it via the UML since I maintain UML and MTD. :)

Thanks,
//richard