Skip to contentSkip to conversation

distrodata.bbclass: make upstream version check more useful for git upstreams

PATCH In review Alexander Kanavin 3 participants 7 messages Oct 31, 2017 – Nov 1, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 distrodata.bbclass: make upstream version check more useful for git upstreams

Specifically:

1) remove +git${SRCPV} stuff from comparison and output; it's just unnecessary clutter;

2) write the commit id of the latest version tag into the output; this saves quite a bit of trouble of manually checking what that commit id is when doing version updates;

3) when UPSTREAM_CHECK_COMMITS is set, ignore the tags altogether; instead check if the latest commit is different to the one we use, and if so, report that the recipe can be updated to said commit (which is also written into the output, as in 2). Multiple recipes are failing the upstream check because they never issue tags, now we can fix them.

---
 meta/classes/distrodata.bbclass | 26 ++++++++----------------
 meta/lib/oe/recipeutils.py      | 44 +++++++++++++++++------------------------
 2 files changed, 26 insertions(+), 44 deletions(-)
meta/classes/distrodata.bbclass +8 -18
index c85f7b3474f..b0f4ecea09f 100644
@@ -272,24 +272,15 @@ python do_checkpkg() {
             if upstream_check_unreliable == "1":
                 return "N/A", "CHECK_IS_UNRELIABLE"
 
-            try:
-                uv = oe.recipeutils.get_recipe_upstream_version(localdata)
-                pupver = uv['version'] if uv['version'] else "N/A"
-            except Exception as e:
-                pupver = "N/A"
+            uv = oe.recipeutils.get_recipe_upstream_version(localdata)
+            pupver = uv['version'] if uv['version'] else "N/A"
+            pversion = uv['current_version']
+            revision = uv['revision'] if uv['revision'] else "N/A"
 
             if pupver == "N/A":
                 pstatus = "UNKNOWN" if upstream_version_unknown else "UNKNOWN_BROKEN"
             else:
-                src_uri = (localdata.getVar('SRC_URI') or '').split()
-                if src_uri:
-                    uri_type, _, _, _, _, _ = decodeurl(src_uri[0])
-                else:
-                    uri_type = "none"
-                pv, _, _ = oe.recipeutils.get_recipe_pv_without_srcpv(pversion, uri_type)
-                upv, _, _ = oe.recipeutils.get_recipe_pv_without_srcpv(pupver, uri_type)
-
-                cmp = vercmp_string(pv, upv)
+                cmp = vercmp_string(pversion, pupver)
                 if cmp == -1:
                     pstatus = "UPDATE" if not upstream_version_unknown else "KNOWN_BROKEN"
                 elif cmp == 0:
@@ -297,7 +288,7 @@ python do_checkpkg() {
                 else:
                     pstatus = "UNKNOWN" if upstream_version_unknown else "UNKNOWN_BROKEN"
 
-            return pupver, pstatus
+            return pversion, pupver, pstatus, revision
 
 
         """initialize log files."""
@@ -334,7 +325,6 @@ python do_checkpkg() {
 
         pdesc = localdata.getVar('DESCRIPTION')
         pgrp = localdata.getVar('SECTION')
-        pversion = localdata.getVar('PV')
         plicense = localdata.getVar('LICENSE')
         psection = localdata.getVar('SECTION')
         phome = localdata.getVar('HOMEPAGE')
@@ -345,7 +335,7 @@ python do_checkpkg() {
         psrcuri = localdata.getVar('SRC_URI')
         maintainer = localdata.getVar('RECIPE_MAINTAINER')
 
-        pupver, pstatus = get_upstream_version_and_status()
+        pversion, pupver, pstatus, prevision = get_upstream_version_and_status()
 
         if psrcuri:
             psrcuri = psrcuri.split()[0]
@@ -358,7 +348,7 @@ python do_checkpkg() {
         with open(logfile, "a") as f:
             writer = csv.writer(f, delimiter='\t')
             writer.writerow([pname, pversion, pupver, plicense, psection, phome, 
-                prelease, pdepends, pbugtracker, ppe, pdesc, pstatus, pupver,
+                prelease, pdepends, pbugtracker, ppe, pdesc, pstatus, prevision,
                 psrcuri, maintainer, no_upgr_reason])
             f.close()
         bb.utils.unlockfile(lf)
meta/lib/oe/recipeutils.py +18 -26

82 lines not on this page · raw message

Signature · 1 line
2.14.2
#1 lore raw

PATCH 2/2 oe-core: take UPSTREAM_CHECK_COMMITS into use where possible

This greatly reduces the amount of recipes for which upstream version check fails: from about 30 to about 8.

---
 meta/recipes-core/dbus-wait/dbus-wait_git.bb                           | 2 +-
 meta/recipes-core/psplash/psplash_git.bb                               | 2 +-
 meta/recipes-core/update-rc.d/update-rc.d_0.7.bb                       | 2 +-
 meta/recipes-devtools/build-compare/build-compare_git.bb               | 2 +-
 meta/recipes-devtools/gnu-config/gnu-config_git.bb                     | 2 +-
 meta/recipes-devtools/llvm/llvm_git.bb                                 | 2 +-
 meta/recipes-devtools/mmc/mmc-utils_git.bb                             | 2 +-
 meta/recipes-devtools/prelink/prelink_git.bb                           | 3 +--
 meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb             | 2 +-
 meta/recipes-extended/go-examples/go-helloworld_0.1.bb                 | 2 +-
 meta/recipes-graphics/fstests/fstests_git.bb                           | 2 +-
 meta/recipes-graphics/kmscube/kmscube_git.bb                           | 2 +-
 meta/recipes-graphics/piglit/piglit_git.bb                             | 2 +-
 meta/recipes-graphics/vulkan/vulkan-demos_git.bb                       | 2 +-
 .../xcursor-transparent-theme/xcursor-transparent-theme_git.bb         | 2 +-
 meta/recipes-graphics/xorg-lib/libxcalibrate_git.bb                    | 2 +-
 meta/recipes-graphics/xorg-proto/calibrateproto_git.bb                 | 2 +-
 meta/recipes-graphics/xvideo-tests/xvideo-tests_git.bb                 | 2 +-
 meta/recipes-kernel/linux-firmware/linux-firmware_git.bb               | 2 +-
 meta/recipes-multimedia/gstreamer/gst-player_git.bb                    | 2 +-
 meta/recipes-multimedia/x264/x264_git.bb                               | 2 +-
 meta/recipes-sato/puzzles/puzzles_git.bb                               | 2 +-
 22 files changed, 22 insertions(+), 23 deletions(-)
meta/recipes-core/dbus-wait/dbus-wait_git.bb +1 -1
index 4afb90c20a5..c24295b5370 100644
@@ -11,7 +11,7 @@ PV = "0.1+git${SRCPV}"
 PR = "r2"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-core/psplash/psplash_git.bb +1 -1
index 3b7f818fc56..aab2c0360de 100644
@@ -12,7 +12,7 @@ PR = "r15"
 SRC_URI = "git://git.yoctoproject.org/${BPN} \
            file://psplash-init \
            ${SPLASH_IMAGES}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
 
meta/recipes-core/update-rc.d/update-rc.d_0.7.bb +1 -1
index 6fc6f6e1abe..76d4312d881 100644
@@ -16,7 +16,7 @@ SRC_URI = "git://github.com/philb/update-rc.d.git \
            file://check-if-symlinks-are-valid.patch \
            file://fix-to-handle-priority-numbers-correctly.patch \
           "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-devtools/build-compare/build-compare_git.bb +1 -1
index 84d04cfa0d3..efcf6b6dd3c 100644
@@ -22,7 +22,7 @@ SRC_URI = "git://github.com/openSUSE/build-compare.git \
 SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
 PE = "1"
 PV = "2015.02.10+git${SRCPV}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-devtools/gnu-config/gnu-config_git.bb +1 -1
index 4fded60f197..8de81381276 100644
@@ -14,7 +14,7 @@ PV = "20150728+git${SRCPV}"
 SRC_URI = "git://git.savannah.gnu.org/config.git \
            file://gnu-configize.in"
 S = "${WORKDIR}/git"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 CLEANBROKEN = "1"
 
meta/recipes-devtools/llvm/llvm_git.bb +1 -1
index f06fa49ae58..de57dd16147 100644
@@ -26,7 +26,7 @@ SRC_URI = "git://github.com/llvm-mirror/llvm.git;branch=release_50;protocol=http
            file://0001-llvm-TargetLibraryInfo-Undefine-libc-functions-if-th.patch \
            file://0002-llvm-allow-env-override-of-exe-path.patch \
           "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 S = "${WORKDIR}/git"
 
 LLVM_INSTALL_DIR = "${WORKDIR}/llvm-install"
meta/recipes-devtools/mmc/mmc-utils_git.bb +1 -1
index 50acdb1cc2a..efaabc11482 100644
@@ -9,7 +9,7 @@ SRCREV = "37c86e60c0442fef570b75cd81aeb1db4d0cbafd"
 PV = "0.1"
 
 SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${SRCBRANCH}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-devtools/prelink/prelink_git.bb +1 -2
index 570ef36a3cc..cc93bcc384f 100644
@@ -32,8 +32,7 @@ SRC_URI = "git://git.yoctoproject.org/prelink-cross.git;branch=cross_prelink \
            file://prelink.cron.daily \
            file://prelink.default \
 	   file://macros.prelink"
-UPSTREAM_CHECK_GITTAGREGEX = "upstream has no usable tags"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 TARGET_OS_ORIG := "${TARGET_OS}"
 OVERRIDES_append = ":${TARGET_OS_ORIG}"
meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb +1 -1
index 0f991706c1e..a8baca51e3f 100644
@@ -16,7 +16,7 @@ SRC_URI = "git://github.com/plougher/squashfs-tools.git;protocol=https \
            file://squashfs-tools-4.3-sysmacros.patch;striplevel=2 \
            file://fix-compat.patch \
 "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 SRC_URI[lzma.md5sum] = "29d5ffd03a5a3e51aef6a74e9eafb759"
 SRC_URI[lzma.sha256sum] = "c935fd04dd8e0e8c688a3078f3675d699679a90be81c12686837e0880aa0fa1e"
 
meta/recipes-extended/go-examples/go-helloworld_0.1.bb +1 -1
index 6d6789ae852..ab70ea98a32 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
 
 SRC_URI = "git://${GO_IMPORT}"
 SRCREV = "46695d81d1fae905a270fb7db8a4d11a334562fe"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 GO_IMPORT = "github.com/golang/example"
 GO_INSTALL = "${GO_IMPORT}/hello"
meta/recipes-graphics/fstests/fstests_git.bb +1 -1
index 9e09cd2685b..69f217830af 100644
@@ -8,7 +8,7 @@ SRCREV = "e5939ff608b95cdd4d0ab0e1935781ab9a276ac0"
 PV = "0.1+git${SRCPV}"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 LIC_FILES_CHKSUM = "file://test-pango-gdk.c;endline=24;md5=1ee74ec851ecda57eb7ac6cc180f7655"
 
meta/recipes-graphics/kmscube/kmscube_git.bb +1 -1
index cab68fffb43..4265f8a8dc1 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://kmscube.c;beginline=1;endline=23;md5=8b309d4ee67b7315
 
 SRCREV = "0d8de4ce3a03f36af1817f9b0586d132ad2c5d2e"
 SRC_URI = "git://anongit.freedesktop.org/mesa/kmscube;branch=master;protocol=git"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-graphics/piglit/piglit_git.bb +1 -1
index d274a8fbd56..bbe9a88969e 100644
@@ -6,7 +6,7 @@ SRC_URI = "git://anongit.freedesktop.org/piglit \
            file://0001-cmake-install-bash-completions-in-the-right-place.patch \
            file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \
            "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 # From 2017-07-03
 SRCREV = "c8f4fd9eeb298a2ef0855927f22634f794ef3eff"
meta/recipes-graphics/vulkan/vulkan-demos_git.bb +1 -1
index 0b8943508b8..5fc9c2dba75 100644
@@ -10,7 +10,7 @@ SRC_URI = "git://github.com/SaschaWillems/Vulkan.git \
            file://0001-Don-t-build-demos-with-questionably-licensed-data.patch \
            file://0001-Fix-build-on-x86.patch \
 "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 SRCREV = "18df00c7b4677b0889486e16977857aa987947e2"
 UPSTREAM_CHECK_GITTAGREGEX = "These are not the releases you're looking for"
 S = "${WORKDIR}/git"
meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_git.bb +1 -1
index 733ebce7450..a4ab7f6eb81 100644
@@ -11,7 +11,7 @@ SRCREV = "23c8af5ba4a1b7efbaf0bbca59a65ff7e10a1a06"
 PV = "0.1.1+git${SRCPV}"
 
 SRC_URI = "git://git.yoctoproject.org/${BPN};branch=master"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-graphics/xorg-lib/libxcalibrate_git.bb +1 -1
index 7c7fa3ddb3c..0fe65318bea 100644
@@ -16,7 +16,7 @@ PV = "0.0+git${SRCPV}"
 
 SRC_URI = "git://anongit.freedesktop.org/git/xorg/lib/libXCalibrate \
            file://fix-xcb.patch"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-graphics/xorg-proto/calibrateproto_git.bb +1 -1
index 3a989262c1d..eb4b4224cae 100644
@@ -17,5 +17,5 @@ PR = "r2"
 SRC_URI = "git://anongit.freedesktop.org/git/xorg/proto/calibrateproto \
            file://fix.patch;apply=yes"
 S = "${WORKDIR}/git"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
meta/recipes-graphics/xvideo-tests/xvideo-tests_git.bb +1 -1
index 2667dd899d9..1d275a0042c 100644
@@ -8,7 +8,7 @@ SRCREV = "7d38b881e99eb74169d292b40f7164e461a65092"
 PV = "0.1+git${SRCPV}"
 
 SRC_URI = "git://git.yoctoproject.org/test-xvideo"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-kernel/linux-firmware/linux-firmware_git.bb +1 -1
index 0338ba8ac21..532f01ea2f7 100644
@@ -189,7 +189,7 @@ SRC_URI += "https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/linux-firmware.
 
 SRC_URI[iwlwifi-19.md5sum] = "132fbaee36beec5e98714f0bd66f7a1d"
 SRC_URI[iwlwifi-19.sha256sum] = "2034470df64d323b827c4f2d4d0d55be2846b7360179b5574aa28ff77b6c9471"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-multimedia/gstreamer/gst-player_git.bb +1 -1
index 4fe8fdef4a2..ee11e2ba10d 100644
@@ -9,7 +9,7 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
 
 SRCREV = "ee3c226c82767a089743e4e06058743e67f73cdb"
 PV = "0.0.1+git${SRCPV}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 S = "${WORKDIR}/git"
 
meta/recipes-multimedia/x264/x264_git.bb +1 -1
index c5476c7a9b3..bc9775ab2a1 100644
@@ -12,7 +12,7 @@ SRC_URI = "git://github.com/mirror/x264;branch=stable \
            file://don-t-default-to-cortex-a9-with-neon.patch \
            file://Fix-X32-build-by-disabling-asm.patch \
            "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
 SRCREV = "2b741f81e51f92d053d87a49f59ff1026553a0f6"
 
meta/recipes-sato/puzzles/puzzles_git.bb +1 -1
index decd2a8b300..6148e40adaa 100644
@@ -16,7 +16,7 @@ SRC_URI = "git://git.tartarus.org/simon/puzzles.git \
            file://0001-Clarify-conditions-to-avoid-compiler-errors.patch \
            file://0001-Use-Wno-error-format-overflow-if-the-compiler-suppor.patch \
            "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 SRCREV = "8dfe5cec31e784e4ece2955ecc8cc35ee7e8fbb3"
 PE = "1"
 PV = "0.0+git${SRCPV}"
Signature · 1 line
2.14.2
#2 lore raw

Re: [PATCH 2/2] oe-core: take UPSTREAM_CHECK_COMMITS into use where possible

Quoted 2 lines · Alexander Kanavin

This greatly reduces the amount of recipes for which upstream version check fails: from about 30 to about 8.

Has anyone looked into piggy-backing off:
https://release-monitoring.org/
Currently 15791 projects are being monitored by Anitya.
https://github.com/release-monitoring/anitya
I *suspect* this is a Redhat backed project so it's likely to remain active and up to date.

Hmmm, I just tried a few of the packages listed below and only 2 of 8 were tracked packages but this is an outliers list so maybe that's a sign that the r-m.org site is doing better than our tracker.

Let's see:
coreutils - yes
linux - yep :)
bc - yes
cups - yes
libpam - no
minicom - yes
lzo - yes

oe-core - no :(

Anyway, I just wanted to point out the project.

../Randy

Quoted 313 lines
---
  meta/recipes-core/dbus-wait/dbus-wait_git.bb                           | 2 +-
  meta/recipes-core/psplash/psplash_git.bb                               | 2 +-
  meta/recipes-core/update-rc.d/update-rc.d_0.7.bb                       | 2 +-
  meta/recipes-devtools/build-compare/build-compare_git.bb               | 2 +-
  meta/recipes-devtools/gnu-config/gnu-config_git.bb                     | 2 +-
  meta/recipes-devtools/llvm/llvm_git.bb                                 | 2 +-
  meta/recipes-devtools/mmc/mmc-utils_git.bb                             | 2 +-
  meta/recipes-devtools/prelink/prelink_git.bb                           | 3 +--
  meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb             | 2 +-
  meta/recipes-extended/go-examples/go-helloworld_0.1.bb                 | 2 +-
  meta/recipes-graphics/fstests/fstests_git.bb                           | 2 +-
  meta/recipes-graphics/kmscube/kmscube_git.bb                           | 2 +-
  meta/recipes-graphics/piglit/piglit_git.bb                             | 2 +-
  meta/recipes-graphics/vulkan/vulkan-demos_git.bb                       | 2 +-
  .../xcursor-transparent-theme/xcursor-transparent-theme_git.bb         | 2 +-
  meta/recipes-graphics/xorg-lib/libxcalibrate_git.bb                    | 2 +-
  meta/recipes-graphics/xorg-proto/calibrateproto_git.bb                 | 2 +-
  meta/recipes-graphics/xvideo-tests/xvideo-tests_git.bb                 | 2 +-
  meta/recipes-kernel/linux-firmware/linux-firmware_git.bb               | 2 +-
  meta/recipes-multimedia/gstreamer/gst-player_git.bb                    | 2 +-
  meta/recipes-multimedia/x264/x264_git.bb                               | 2 +-
  meta/recipes-sato/puzzles/puzzles_git.bb                               | 2 +-
  22 files changed, 22 insertions(+), 23 deletions(-)
meta/recipes-core/dbus-wait/dbus-wait_git.bb +1 -1
index 4afb90c20a5..c24295b5370 100644
@@ -11,7 +11,7 @@ PV = "0.1+git${SRCPV}"
  PR = "r2"
 
  SRC_URI = "git://git.yoctoproject.org/${BPN}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-core/psplash/psplash_git.bb +1 -1
index 3b7f818fc56..aab2c0360de 100644
@@ -12,7 +12,7 @@ PR = "r15"
  SRC_URI = "git://git.yoctoproject.org/${BPN} \
             file://psplash-init \
             ${SPLASH_IMAGES}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
 
meta/recipes-core/update-rc.d/update-rc.d_0.7.bb +1 -1
index 6fc6f6e1abe..76d4312d881 100644
@@ -16,7 +16,7 @@ SRC_URI = "git://github.com/philb/update-rc.d.git \
             file://check-if-symlinks-are-valid.patch \
             file://fix-to-handle-priority-numbers-correctly.patch \
            "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-devtools/build-compare/build-compare_git.bb +1 -1
index 84d04cfa0d3..efcf6b6dd3c 100644
@@ -22,7 +22,7 @@ SRC_URI = "git://github.com/openSUSE/build-compare.git \
  SRCREV = "c5352c054c6ef15735da31b76d6d88620f4aff0a"
  PE = "1"
  PV = "2015.02.10+git${SRCPV}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-devtools/gnu-config/gnu-config_git.bb +1 -1
index 4fded60f197..8de81381276 100644
@@ -14,7 +14,7 @@ PV = "20150728+git${SRCPV}"
  SRC_URI = "git://git.savannah.gnu.org/config.git \
             file://gnu-configize.in"
  S = "${WORKDIR}/git"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  CLEANBROKEN = "1"
 
meta/recipes-devtools/llvm/llvm_git.bb +1 -1
index f06fa49ae58..de57dd16147 100644
@@ -26,7 +26,7 @@ SRC_URI = "git://github.com/llvm-mirror/llvm.git;branch=release_50;protocol=http
             file://0001-llvm-TargetLibraryInfo-Undefine-libc-functions-if-th.patch \
             file://0002-llvm-allow-env-override-of-exe-path.patch \
            "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
  S = "${WORKDIR}/git"
 
  LLVM_INSTALL_DIR = "${WORKDIR}/llvm-install"
meta/recipes-devtools/mmc/mmc-utils_git.bb +1 -1
index 50acdb1cc2a..efaabc11482 100644
@@ -9,7 +9,7 @@ SRCREV = "37c86e60c0442fef570b75cd81aeb1db4d0cbafd"
  PV = "0.1"
 
  SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc-utils.git;branch=${SRCBRANCH}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-devtools/prelink/prelink_git.bb +1 -2
index 570ef36a3cc..cc93bcc384f 100644
@@ -32,8 +32,7 @@ SRC_URI = "git://git.yoctoproject.org/prelink-cross.git;branch=cross_prelink \
             file://prelink.cron.daily \
             file://prelink.default \
  	   file://macros.prelink"
-UPSTREAM_CHECK_GITTAGREGEX = "upstream has no usable tags"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  TARGET_OS_ORIG := "${TARGET_OS}"
  OVERRIDES_append = ":${TARGET_OS_ORIG}"
meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb +1 -1
index 0f991706c1e..a8baca51e3f 100644
@@ -16,7 +16,7 @@ SRC_URI = "git://github.com/plougher/squashfs-tools.git;protocol=https \
             file://squashfs-tools-4.3-sysmacros.patch;striplevel=2 \
             file://fix-compat.patch \
  "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
  SRC_URI[lzma.md5sum] = "29d5ffd03a5a3e51aef6a74e9eafb759"
  SRC_URI[lzma.sha256sum] = "c935fd04dd8e0e8c688a3078f3675d699679a90be81c12686837e0880aa0fa1e"
 
meta/recipes-extended/go-examples/go-helloworld_0.1.bb +1 -1
index 6d6789ae852..ab70ea98a32 100644
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
 
  SRC_URI = "git://${GO_IMPORT}"
  SRCREV = "46695d81d1fae905a270fb7db8a4d11a334562fe"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  GO_IMPORT = "github.com/golang/example"
  GO_INSTALL = "${GO_IMPORT}/hello"
meta/recipes-graphics/fstests/fstests_git.bb +1 -1
index 9e09cd2685b..69f217830af 100644
@@ -8,7 +8,7 @@ SRCREV = "e5939ff608b95cdd4d0ab0e1935781ab9a276ac0"
  PV = "0.1+git${SRCPV}"
 
  SRC_URI = "git://git.yoctoproject.org/${BPN}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  LIC_FILES_CHKSUM = "file://test-pango-gdk.c;endline=24;md5=1ee74ec851ecda57eb7ac6cc180f7655"
 
meta/recipes-graphics/kmscube/kmscube_git.bb +1 -1
index cab68fffb43..4265f8a8dc1 100644
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://kmscube.c;beginline=1;endline=23;md5=8b309d4ee67b7315
 
  SRCREV = "0d8de4ce3a03f36af1817f9b0586d132ad2c5d2e"
  SRC_URI = "git://anongit.freedesktop.org/mesa/kmscube;branch=master;protocol=git"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-graphics/piglit/piglit_git.bb +1 -1
index d274a8fbd56..bbe9a88969e 100644
@@ -6,7 +6,7 @@ SRC_URI = "git://anongit.freedesktop.org/piglit \
             file://0001-cmake-install-bash-completions-in-the-right-place.patch \
             file://0001-tests-Use-FE_UPWARD-only-if-its-defined-in-fenv.h.patch \
             "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  # From 2017-07-03
  SRCREV = "c8f4fd9eeb298a2ef0855927f22634f794ef3eff"
meta/recipes-graphics/vulkan/vulkan-demos_git.bb +1 -1
index 0b8943508b8..5fc9c2dba75 100644
@@ -10,7 +10,7 @@ SRC_URI = "git://github.com/SaschaWillems/Vulkan.git \
             file://0001-Don-t-build-demos-with-questionably-licensed-data.patch \
             file://0001-Fix-build-on-x86.patch \
  "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
  SRCREV = "18df00c7b4677b0889486e16977857aa987947e2"
  UPSTREAM_CHECK_GITTAGREGEX = "These are not the releases you're looking for"
  S = "${WORKDIR}/git"
meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_git.bb +1 -1
index 733ebce7450..a4ab7f6eb81 100644
@@ -11,7 +11,7 @@ SRCREV = "23c8af5ba4a1b7efbaf0bbca59a65ff7e10a1a06"
  PV = "0.1.1+git${SRCPV}"
 
  SRC_URI = "git://git.yoctoproject.org/${BPN};branch=master"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-graphics/xorg-lib/libxcalibrate_git.bb +1 -1
index 7c7fa3ddb3c..0fe65318bea 100644
@@ -16,7 +16,7 @@ PV = "0.0+git${SRCPV}"
 
  SRC_URI = "git://anongit.freedesktop.org/git/xorg/lib/libXCalibrate \
             file://fix-xcb.patch"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-graphics/xorg-proto/calibrateproto_git.bb +1 -1
index 3a989262c1d..eb4b4224cae 100644
@@ -17,5 +17,5 @@ PR = "r2"
  SRC_URI = "git://anongit.freedesktop.org/git/xorg/proto/calibrateproto \
             file://fix.patch;apply=yes"
  S = "${WORKDIR}/git"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
meta/recipes-graphics/xvideo-tests/xvideo-tests_git.bb +1 -1
index 2667dd899d9..1d275a0042c 100644
@@ -8,7 +8,7 @@ SRCREV = "7d38b881e99eb74169d292b40f7164e461a65092"
  PV = "0.1+git${SRCPV}"
 
  SRC_URI = "git://git.yoctoproject.org/test-xvideo"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-kernel/linux-firmware/linux-firmware_git.bb +1 -1
index 0338ba8ac21..532f01ea2f7 100644
@@ -189,7 +189,7 @@ SRC_URI += "https://git.kernel.org/cgit/linux/kernel/git/iwlwifi/linux-firmware.
 
  SRC_URI[iwlwifi-19.md5sum] = "132fbaee36beec5e98714f0bd66f7a1d"
  SRC_URI[iwlwifi-19.sha256sum] = "2034470df64d323b827c4f2d4d0d55be2846b7360179b5574aa28ff77b6c9471"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-multimedia/gstreamer/gst-player_git.bb +1 -1
index 4fe8fdef4a2..ee11e2ba10d 100644
@@ -9,7 +9,7 @@ SRC_URI = "git://github.com/sdroege/gst-player.git \
 
  SRCREV = "ee3c226c82767a089743e4e06058743e67f73cdb"
  PV = "0.0.1+git${SRCPV}"
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  S = "${WORKDIR}/git"
 
meta/recipes-multimedia/x264/x264_git.bb +1 -1
index c5476c7a9b3..bc9775ab2a1 100644
@@ -12,7 +12,7 @@ SRC_URI = "git://github.com/mirror/x264;branch=stable \
             file://don-t-default-to-cortex-a9-with-neon.patch \
             file://Fix-X32-build-by-disabling-asm.patch \
             "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
 
  SRCREV = "2b741f81e51f92d053d87a49f59ff1026553a0f6"
 
meta/recipes-sato/puzzles/puzzles_git.bb +1 -1
index decd2a8b300..6148e40adaa 100644
@@ -16,7 +16,7 @@ SRC_URI = "git://git.tartarus.org/simon/puzzles.git \
             file://0001-Clarify-conditions-to-avoid-compiler-errors.patch \
             file://0001-Use-Wno-error-format-overflow-if-the-compiler-suppor.patch \
             "
-UPSTREAM_VERSION_UNKNOWN = "1"
+UPSTREAM_CHECK_COMMITS = "1"
  SRCREV = "8dfe5cec31e784e4ece2955ecc8cc35ee7e8fbb3"
  PE = "1"
  PV = "0.0+git${SRCPV}"
Signature · 2 lines
# Randy MacLeod.  WR Linux
# Wind River an Intel Company
#3 lore raw

Re: [PATCH 2/2] oe-core: take UPSTREAM_CHECK_COMMITS into use where possible

Quoted 11 lines · Randy MacLeod
Quoted 2 lines · Alexander Kanavin

This greatly reduces the amount of recipes for which upstream version check fails: from about 30 to about 8.

Has anyone looked into piggy-backing off:
   https://release-monitoring.org/
Currently 15791 projects are being monitored by Anitya.
   https://github.com/release-monitoring/anitya
I *suspect* this is a Redhat backed project so it's likely to remain active and up to date.

Quoted 4 lines

Hmmm, I just tried a few of the packages listed below and only 2 of 8 were tracked packages but this is an outliers list so maybe that's a sign that the r-m.org site is doing better than our tracker.

Their data is not of sufficient quality unfortunately. For Python they report 3.7.0 as the latest version even though it won't be released until june 2018. Python 2.x is neglected altogether. Latest 3.6 version is 3.6.3 released a month ago, but they report only 3.6.2.

Similar issues with webkitgtk: they report 2.19.1 (a pre-release), but not 2.18.2 (actual latest release).

Then there's the question of who maintains the mapping of their database to our package names.

Our tracker has over 98% accuracy, while this one failed both of the randomly chosen samples ;)

Alex

#4 lore raw

Re: [PATCH 2/2] oe-core: take UPSTREAM_CHECK_COMMITS into use where possible

Quoted 9 lines · Alexander Kanavin

Their data is not of sufficient quality unfortunately. For Python they report 3.7.0 as the latest version even though it won't be released until june 2018. Python 2.x is neglected altogether. Latest 3.6 version is 3.6.3 released a month ago, but they report only 3.6.2.

Similar issues with webkitgtk: they report 2.19.1 (a pre-release), but not 2.18.2 (actual latest release).

Then there's the question of who maintains the mapping of their database to our package names.

Our tracker has over 98% accuracy, while this one failed both of the randomly chosen samples ;)

Alex

Huh, accurate data, aren't you picky! ;-)
Thanks for following up.

Signature · 2 lines
# Randy MacLeod.  WR Linux
# Wind River an Intel Company
#5 lore raw

✗ patchtest: failure for "distrodata.bbclass: make upstr..." and 1 more

In reply to Alexander Kanavin

== Series Details ==

Series: "distrodata.bbclass: make upstr..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/9566/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 3b413a8057)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#6 lore raw

Re: ✗ patchtest: failure for "distrodata.bbclass: make upstr..." and 1 more

Quoted 3 lines · Patchwork
* Issue             Series does not apply on top of target branch [test_series_merge_on_head]
   Suggested fix    Rebase your series on top of targeted branch
   Targeted branch  master (currently at 3b413a8057)

This is because the patches need to be applied on top of the earlier 50-piece patchset of mine.

Alex