Skip to contentSkip to conversation

Btrfs: use cached state when dirtying pages during buffered write

PATCH In review [email protected] 2 participants 2 messages Oct 31, 2017 – Nov 6, 2017 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Btrfs: use cached state when dirtying pages during buffered write

From: Filipe Manana <[email protected]>

During a buffered IO write, we can have an extent state that we got when we locked the range (if the range starts at an offset lower than eof), so always pass it to btrfs_dirty_pages() so that setting the delalloc bit in the range does not need to do a full search in the inode's io tree, saving time and reducing the amount of time we hold the io tree's lock.

---
 fs/btrfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/file.c +1 -1
index e0d15c0d1641..aaab1838cece 100644
@@ -1755,7 +1755,7 @@ static noinline ssize_t __btrfs_buffered_write(struct file *file,
 
 		if (copied > 0)
 			ret = btrfs_dirty_pages(inode, pages, dirty_pages,
-						pos, copied, NULL);
+						pos, copied, &cached_state);
 		if (need_unlock)
 			unlock_extent_cached(&BTRFS_I(inode)->io_tree,
 					     lockstart, lockend, &cached_state,
Signature · 1 line
2.11.0
Reviewed-by on v1 1/2
#1 lore raw
Quoted 9 lines · On Tue, Oct 31, 2017 at 06:55:40PM +0000, [email protected] wrote:

From: Filipe Manana <[email protected]>

During a buffered IO write, we can have an extent state that we got when we locked the range (if the range starts at an offset lower than eof), so always pass it to btrfs_dirty_pages() so that setting the delalloc bit in the range does not need to do a full search in the inode's io tree, saving time and reducing the amount of time we hold the io tree's lock.