btt_check_bitmap: initialize rc
PATCH 1/1 btt_check_bitmap: initialize rc
It may be possible that rc is never set before returning from the function. nfree would have to be zero, and the bitmap would have to be full. Fix it.
ndctl/check.c +1 -2
@@ -508,7 +508,7 @@ static int btt_check_bitmap(struct arena_info *a) {unsigned long *bm;u32 i, btt_mapping; -int rc; +int rc =BTT_BITMAP_ERROR ; bm =bitmap_alloc (a->internal_nlba);if (bm ==NULL )
@@ -521,7 +521,6 @@ static int btt_check_bitmap(struct arena_info *a)info (a->bttc,"arena %d: internal block %#x is referenced by two map entries\n" , a->num, btt_mapping); - rc =BTT_BITMAP_ERROR ; goto out; }bitmap_set (bm, btt_mapping,1 );
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 5 lines · Jeff Moyer
It may be possible that rc is never set before returning from the function. nfree would have to be zero, and the bitmap would have to be full. Fix it.
Signed-off-by Jeff Moyer <[email protected]>
Ah so it shouldn't ever happen in practice, but I can see how a static checker may complain about it. The patch looks good to me.
Quoted 22 lines
ndctl/check.c +1
-2@@ -508,7 +508,7 @@ static int btt_check_bitmap(struct arena_info *a) {unsigned long *bm;u32 i, btt_mapping; -int rc; +int rc =BTT_BITMAP_ERROR ; bm =bitmap_alloc (a->internal_nlba);if (bm ==NULL )@@ -521,7 +521,6 @@ static int btt_check_bitmap(struct arena_info *a)info (a->bttc,"arena %d: internal block %#x is referenced by two map entries\n" , a->num, btt_mapping); - rc =BTT_BITMAP_ERROR ; goto out; }bitmap_set (bm, btt_mapping,1 );
Quoted 4 lines
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm