Skip to contentSkip to conversation

net: vrf: correct FRA_L3MDEV encode type

PATCH In review Jeff Barnhill 2 participants 2 messages Nov 1, 2017

Subsystems (3)
Networking Network drivers VRF
lore
Share & tools
lore

Jeff Barnhill

author
#0 lore raw

PATCH 1/1 net: vrf: correct FRA_L3MDEV encode type

FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On big endian architecture, this results in the l3mdev entry not being added to the FIB rules.

Fixes 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")
---
 drivers/net/vrf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/vrf.c +1 -1
index 9b243e6f3008..7dc3bcac3506 100644
@@ -1165,7 +1165,7 @@ static int vrf_fib_rule(const struct net_device *dev, __u8 family, bool add_it)
 	frh->family = family;
 	frh->action = FR_ACT_TO_TBL;
 
-	if (nla_put_u32(skb, FRA_L3MDEV, 1))
+	if (nla_put_u8(skb, FRA_L3MDEV, 1))
 		goto nla_put_failure;
 
 	if (nla_put_u32(skb, FRA_PRIORITY, FIB_RULE_PREF))
Signature · 1 line
2.14.1
maintainer
#1 lore raw

From: Jeff Barnhill <[email protected]>
Date: Wed, 1 Nov 2017 01:24:14 +0000

Quoted 5 lines

FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On big endian architecture, this results in the l3mdev entry not being added to the FIB rules.

Fixes 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")

Please resubmit this with a proper "Signed-off-by: " tag, thank you.