Skip to contentSkip to conversation

musl: Update to 1.1.18

PATCH In review Khem Raj 4 participants 12 messages Nov 2, 2017 – Nov 3, 2017

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH v3 1/1 musl: Update to 1.1.18

Rich Felker (10):
fix use of memset without declaration in sched.h cpu set macros fix access by setjmp and longjmp to __hwcap on arm built as thumb2 for executing init array functions, use function type with prototype fix read-after-free type error in pthread_detach
fix incorrect base name offset from nftw when pathname ends in slash(es) in dns parsing callback, enforce MAXADDRS to preclude overflow release 1.1.17
fix regression in glob with literal . or .. path component fix build regression on ARM for ISA levels less than v5 release 1.1.18

Szabolcs Nagy (2):
powerpc{64}: fix MAP_NORESERVE and MAP_LOCKED in mman.h
math: rewrite fma with mostly int arithmetics

Will Dietz (1):
posix_spawn: use larger stack to cover worst-case in execvpe

---
Changes since v2: Move to 1.1.18 release

 meta/recipes-core/musl/musl_git.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/musl/musl_git.bb +2 -2
index bd7573e0f3..932c9a27a0 100644
@@ -3,9 +3,9 @@
 
 require musl.inc
 
-SRCREV = "da438ee1fc516c41ba1790cef7be551a9e244397"
+SRCREV = "eb03bde2f24582874cb72b56c7811bf51da0c817"
 
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"
 
 # mirror is at git://github.com/kraj/musl.git
 
Signature · 1 line
2.15.0
#1 lore raw

meta/recipes-core/musl/musl_git.bb line 8

Quoted 3 lines · Khem Raj

Changes since v2: Move to 1.1.18 release

meta/recipes-core/musl/musl_git.bb +1 -1
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"

Can you drop this, and simply rename the recipe to musl_1.1.18.bb please?

Alex

#2 lore raw
Quoted 8 lines · Alexander Kanavin

meta/recipes-core/musl/musl_git.bb line 8

Quoted 3 lines · Khem Raj

Changes since v2: Move to 1.1.18 release

meta/recipes-core/musl/musl_git.bb +1 -1
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"

Can you drop this, and simply rename the recipe to musl_1.1.18.bb please?

Why? keeping it on _git makes sense to me.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw
Quoted 4 lines · Otavio Salvador
Quoted 2 lines · Alexander Kanavin

On 11/02/2017 07:39 AM, Khem Raj wrote:

Quoted 8 lines
Quoted 6 lines

meta/recipes-core/musl/musl_git.bb line 8

Quoted 3 lines

Changes since v2: Move to 1.1.18 release

meta/recipes-core/musl/musl_git.bb +1 -1
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"

Can you drop this, and simply rename the recipe to musl_1.1.18.bb please?

Why? keeping it on _git makes sense to me.

Only if it's a random development revision (e.g. 1.1.18 plus a bunch of commits) - if the version taken is a pristine tagged release, it should be indicated as such, regardless of whether it's taken from a tarball or a git checkout.

Alex

author
#4 lore raw
Quoted 5 lines · Alexander Kanavin
Quoted 4 lines · Otavio Salvador
Quoted 2 lines · Alexander Kanavin

On 11/02/2017 07:39 AM, Khem Raj wrote:

Quoted 10 lines
Quoted 6 lines
Quoted 6 lines

meta/recipes-core/musl/musl_git.bb line 8

Quoted 3 lines

Changes since v2: Move to 1.1.18 release

meta/recipes-core/musl/musl_git.bb +1 -1
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"

Can you drop this, and simply rename the recipe to musl_1.1.18.bb

please?

Quoted 2 lines

Why? keeping it on _git makes sense to me.

We always use a given srcrev always this time
It just happens to match with release

Quoted 8 lines

Only if it's a random development revision (e.g. 1.1.18 plus a bunch of commits) - if the version taken is a pristine tagged release, it should be indicated as such, regardless of whether it's taken from a tarball or a git checkout.

Alex

#5 lore raw
Quoted 8 lines · Khem Raj

>> Can you drop this, and simply rename the recipe to
musl_1.1.18.bb <http://musl_1.1.18.bb> please?
>
> Why? keeping it on _git makes sense to me.

We always use a given srcrev always this time
It just happens to match with release

But why the need to pick mid-development commits, rather than stick with tagged releases?

Alex

author
#6 lore raw
Quoted 8 lines · Alexander Kanavin
Quoted 6 lines · Khem Raj

>> Can you drop this, and simply rename the recipe to
musl_1.1.18.bb <http://musl_1.1.18.bb> please?
>
> Why? keeping it on _git makes sense to me.

Quoted 6 lines
Quoted 2 lines

We always use a given srcrev always this time
It just happens to match with release

But why the need to pick mid-development commits, rather than stick with tagged releases?

We do not carry any patches and musl releases aren't frequent. It has served us well
since we have been able to get regression fixed upstream as they happened with musl on OE
I wish every project was usable in this fashion.

Quoted 2 lines

Alex

#7 lore raw
In reply to Alexander Kanavin
Quoted 16 lines · Alexander Kanavin
Quoted 15 lines · Otavio Salvador
Quoted 10 lines · Alexander Kanavin

meta/recipes-core/musl/musl_git.bb line 8

Quoted 3 lines · Khem Raj

Changes since v2: Move to 1.1.18 release

meta/recipes-core/musl/musl_git.bb +1 -1
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"

Can you drop this, and simply rename the recipe to musl_1.1.18.bb please?

Quoted 7 lines
Quoted 1 line

Why? keeping it on _git makes sense to me.

Only if it's a random development revision (e.g. 1.1.18 plus a bunch of commits) - if the version taken is a pristine tagged release, it should be indicated as such, regardless of whether it's taken from a tarball or a git checkout.

I agree partially; if it points to a tag it can be said in a comment ... using SRCPV for this kind of recipe makes sense as it allows for easy tracking of the revision in use.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#8 lore raw
Quoted 3 lines · Otavio Salvador

I agree partially; if it points to a tag it can be said in a comment ... using SRCPV for this kind of recipe makes sense as it allows for easy tracking of the revision in use.

But you can use SRCREV for that. Why the need specifically for SRCPV?

Alex

#9 lore raw
In reply to Otavio Salvador
Quoted 10 lines · Otavio Salvador
Quoted 7 lines · Alexander Kanavin

meta/recipes-core/musl/musl_git.bb line 8

Quoted 3 lines · Khem Raj

Changes since v2: Move to 1.1.18 release

meta/recipes-core/musl/musl_git.bb +1 -1
-PV = "1.1.16+git${SRCPV}"
+PV = "1.1.18+git${SRCPV}"

Can you drop this, and simply rename the recipe to musl_1.1.18.bb please?

Why? keeping it on _git makes sense to me.

SRCPV causes package versioning havoc. You can not tell what version 1.1.8+git(hash)  or 1.1.8+git(hash) is the latest on a system. Can your package manage figure that out?

- Armin

Quoted 1 line
#10 lore raw
Quoted 3 lines · On 11/03/2017 05:08 PM, akuster808 wrote:

SRCPV causes package versioning havoc. You can not tell what version 1.1.8+git(hash)  or 1.1.8+git(hash) is the latest on a system. Can your package manage figure that out?

I thought the entire point of SRCPV is to provide something that is guaranteed to increase over time? It makes sense when taking random revisions from git, but when git is used only for tagged releases, it's just annoying visual clutter.

Alex

#11 lore raw
Quoted 10 lines · Alexander Kanavin
Quoted 3 lines · On 11/03/2017 05:08 PM, akuster808 wrote:

SRCPV causes package versioning havoc. You can not tell what version 1.1.8+git(hash) or 1.1.8+git(hash) is the latest on a system. Can your package manage figure that out?

I thought the entire point of SRCPV is to provide something that is guaranteed to increase over time? It makes sense when taking random revisions from git, but when git is used only for tagged releases, it's just annoying visual clutter.

Honestly, the recipe name should interfere with this. In fact using git for a git-based recipe makes more sense to me.

Anyway, as Khem mentioned, musl often points to non-tag revision when bug fixes are made so I think there is no point in keeping this discussion going.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750