Skip to contentSkip to conversation

ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

PATCH New Marco Franchi 4 participants 6 messages Oct 26, 2017 – Nov 16, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Marco Franchi

author
#0 lore raw

PATCH v5 1/1 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node and, consequently, includes a mdio node into the fec node, with the 'address-cells' and 'size-cells' to avoid these other following warnings:

Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0

Signed-off-by Marco Franchi <[email protected]>

---
Change since v4:
-pass the 'address-cells' and 'size-cells' values using a mdio node -change message log

 arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx53-tx53.dtsi +10 -4
index 71b58b6..a22e461 100644
@@ -225,10 +225,16 @@
 	mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
 	status = "okay";
 
-	phy0: ethernet-phy at 0 {
-		interrupt-parent = <&gpio2>;
-		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
-		device_type = "ethernet-phy";
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy0: ethernet-phy at 0 {
+			reg = <0>;
+			interrupt-parent = <&gpio2>;
+			interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+			device_type = "ethernet-phy";
+		};
 	};
 };
Signature · 1 line
2.7.4
reviewer
#1 lore raw

PATCH v5 1/1 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

Quoted 8 lines · Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node and, consequently, includes a mdio node into the fec node, with the 'address-cells' and 'size-cells' to avoid these other following warnings:

Quoted 5 lines

Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0

Signed-off-by Marco Franchi <[email protected]>

Lothar, could you please test it?

Quoted 35 lines

---
Change since v4:

(quoted diff) +0 -2
-pass the 'address-cells' and 'size-cells' values using a mdio node
-change message log
 arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx53-tx53.dtsi +10 -5
index 71b58b6..a22e461 100644
@@ -225,10 +225,16 @@
        mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
        status = "okay";
 
-       phy0: ethernet-phy at 0 {
-               interrupt-parent = <&gpio2>;
-               interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
-               device_type = "ethernet-phy";
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               phy0: ethernet-phy at 0 {
+                       reg = <0>;
+                       interrupt-parent = <&gpio2>;
+                       interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+                       device_type = "ethernet-phy";
+               };
        };
 };
 
--

2.7.4

#2 lore raw

PATCH v5 1/1 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

Hi,

Quoted 49 lines · On Thu, 26 Oct 2017 16:10:54 -0200 Fabio Estevam wrote:
Quoted 8 lines · Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node and, consequently, includes a mdio node into the fec node, with the 'address-cells' and 'size-cells' to avoid these other following warnings:

Quoted 5 lines

Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0

Signed-off-by Marco Franchi <[email protected]>

Lothar, could you please test it?

Quoted 32 lines

---
Change since v4:

(quoted diff) +0 -2
-pass the 'address-cells' and 'size-cells' values using a mdio node
-change message log
 arch/arm/boot/dts/imx53-tx53.dtsi | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
arch/arm/boot/dts/imx53-tx53.dtsi +10 -4
index 71b58b6..a22e461 100644
@@ -225,10 +225,16 @@
        mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
        status = "okay";
 
-       phy0: ethernet-phy at 0 {
-               interrupt-parent = <&gpio2>;
-               interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
-               device_type = "ethernet-phy";
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               phy0: ethernet-phy at 0 {
+                       reg = <0>;
+                       interrupt-parent = <&gpio2>;
+                       interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
+                       device_type = "ethernet-phy";
+               };
        };
 };
Quoted 4 lines
Quoted 3 lines

--
2.7.4

Tested-by <[email protected]>
Acked-by <[email protected]>

Lothar Wa?mann

#4 lore raw

PATCH v5 1/1 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

Hi,

Quoted 7 lines · On Thu, 2 Nov 2017 11:38:49 -0200 Fabio Estevam wrote:

Hi Lothar,

Quoted 2 lines · Lothar Wa?mann
Tested-by <[email protected]>
Acked-by <[email protected]>
Quoted 8 lines

Thanks for testing and acking.

It seems you missed to add your name into the tags and what you meant to say was:

Tested-by Lothar Wa?mann <[email protected]>
Acked-by Lothar Wa?mann <[email protected]>

Yes, of course. It was too early in the morning...

Lothar Wa?mann

Applied
#5 lore raw

PATCH v5 1/1 ARM: dts: imx53-tx53: Fix 'ethernet-phy@0' node with unit name and no reg property

In reply to Marco Franchi
Quoted 8 lines · Marco Franchi

The following build warning is seen with W=1:

Warning (unit_address_vs_reg): Node /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has a unit name, but no reg property

Fix this warning by adding reg property from such node and, consequently, includes a mdio node into the fec node, with the 'address-cells' and 'size-cells' to avoid these other following warnings:

Quoted 5 lines

Warning (reg_format): "reg" property in /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/aips at 60000000/ethernet at 63fec000/ethernet-phy at 0

Signed-off-by Marco Franchi <[email protected]>

Applied, thanks.