Skip to contentSkip to conversation

phy: rcar-gen3-usb2: select USB_COMMON

PATCH In review Arnd Bergmann 2 participants 2 messages Nov 2, 2017 – Nov 6, 2017 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: rcar-gen3-usb2: select USB_COMMON

When USB is disabled, we get a link error for this driver because of the added OTG support

drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
phy-rcar-gen3-usb2.c:(.text+0x250): undefined reference to `of_usb_get_dr_mode_by_phy'

Other phy drivers select USB_COMMON for this, so let's do the same here.

Fixes 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode")
---
 drivers/phy/renesas/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/phy/renesas/Kconfig +2 -0
index cb09245e9b4c..c845facacb06 100644
@@ -12,7 +12,9 @@ config PHY_RCAR_GEN3_USB2
 	tristate "Renesas R-Car generation 3 USB 2.0 PHY driver"
 	depends on ARCH_RENESAS
 	depends on EXTCON
+	depends on USB_SUPPORT
 	select GENERIC_PHY
+	select USB_COMMON
 	help
 	  Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs.
 
Signature · 1 line
2.9.0
Acked-by on v1 1/1
#1 lore raw

Hi Arnd,

Quoted 5 lines

From: Arnd Bergmann, Sent: Thursday, November 2, 2017 8:57 PM

When USB is disabled, we get a link error for this driver because of the added OTG support

Quoted 8 lines

drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
phy-rcar-gen3-usb2.c:(.text+0x250): undefined reference to `of_usb_get_dr_mode_by_phy'

Other phy drivers select USB_COMMON for this, so let's do the same here.

Fixes 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode")

Thank you for the patch!

Best regards,
Yoshihiro Shimoda