package: add python-raven
PATCH 1/2 package: add python-raven
--- package/Config.in | 1 + package/python-raven/Config.in | 6 ++++++ package/python-raven/python-raven.hash | 3 +++ package/python-raven/python-raven.mk | 14 ++++++++++++++ 4 files changed, 24 insertions(+) create mode 100644 package/python-raven/Config.in create mode 100644 package/python-raven/python-raven.hash create mode 100644 package/python-raven/python-raven.mk
package/Config.in +1 -0
@@ -875,6 +875,7 @@ menu "External python modules" source "package/python-pyxb/Config.in" source "package/python-pyyaml/Config.in" source "package/python-pyzmq/Config.in" + source "package/python-raven/Config.in" source "package/python-requests/Config.in" source "package/python-requests-toolbelt/Config.in" source "package/python-rpi-gpio/Config.in"
package/python-raven/Config.in new file +6 -0
@@ -0,0 +1,6 @@ +config BR2_PACKAGE_PYTHON_RAVEN + bool "python-raven" + help + Raven is a client for Sentry (https://getsentry.com). + + https://github.com/getsentry/raven-python
package/python-raven/python-raven.hash new file +3 -0
@@ -0,0 +1,3 @@ +# md5 from https://pypi.python.org/pypi/raven/json, sha256 locally computed +md5 a08d910e05a228d55cb3388910930d66 raven-6.2.1.tar.gz +sha256 c0a30bcc3e3206059f79656d80362ce080b1c991c95d867edce559a7294570fe raven-6.2.1.tar.gz
package/python-raven/python-raven.mk new file +14 -0
@@ -0,0 +1,14 @@ +################################################################################ +# +# python-raven +# +################################################################################ + +PYTHON_RAVEN_VERSION = 6.2.1 +PYTHON_RAVEN_SOURCE = raven-$(PYTHON_RAVEN_VERSION).tar.gz +PYTHON_RAVEN_SITE = https://pypi.python.org/packages/c1/97/38e74c7521737c965281b43440b274955e211b1d5319c256d8525d9d2cad +PYTHON_RAVEN_SETUP_TYPE = setuptools +PYTHON_RAVEN_LICENSE = BSD-3-Clause +PYTHON_RAVEN_LICENSE_FILES = LICENSE + +$(eval $(python-package))
Signature · 1 line
2.15.0
PATCH 2/2 DEVELOPERS: add myself as maintainer for python-raven
--- DEVELOPERS | 3 +++ 1 file changed, 3 insertions(+)
DEVELOPERS +3 -0
@@ -779,6 +779,9 @@ F: package/pdbg/ F: board/qemu/ppc64le-pseries/ F: configs/qemu_ppc64le_pseries_defconfig +N: Joseph Kogut <[email protected]> +F: package/python-raven/ + N: Johan Derycke <[email protected]> F: package/python-libconfig/
Signature · 1 line
2.15.0
PATCH 1/2 package: add python-raven
In reply to Joseph KogutHello,
Thanks for this new contribution! Looks pretty good, just a few minor nits or questions.
First, the title of the commit should be:
python-raven: new package
(We like to have consistent naming for commit titles, as it allows to more easily grep through the Git history).
Quoted 7 lines · Joseph Kogut
Signed-off-by Joseph Kogut <[email protected]>--- package/Config.in | 1 + package/python-raven/Config.in | 6 ++++++ package/python-raven/python-raven.hash | 3 +++ package/python-raven/python-raven.mk | 14 ++++++++++++++ 4 files changed, 24 insertions(+)
Please include the change to the DEVELOPERS file in the same patch, no need to make it a separate patch.
package/python-raven/Config.in line 2
Quoted 8 lines
package/python-raven/Config.in new file +2
-0@@ -0,0 +1,6 @@ +config BR2_PACKAGE_PYTHON_RAVEN + bool "python-raven"
It really doesn't have *any* runtime dependency on other Python modules? I.e if you build just python-raven and the minimal python interpreter, it works?
I.e, if you build:
BR2_PACKAGE_PYTHON=y
BR2_PACKAGE_PYTHON_RAVEN=y
does it build and run on the target?
package/python-raven/Config.in line 3
Quoted 1 line
package/python-raven/Config.in new file +1
-0+PYTHON_RAVEN_VERSION = 6.2.1
There is a 6.3.0 version available, any reason not to use this one ?
package/python-raven/Config.in
Quoted 5 lines
package/python-raven/Config.in new file +5
-0+PYTHON_RAVEN_SOURCE = raven-$(PYTHON_RAVEN_VERSION).tar.gz +PYTHON_RAVEN_SITE = https://pypi.python.org/packages/c1/97/38e74c7521737c965281b43440b274955e211b1d5319c256d8525d9d2cad +PYTHON_RAVEN_SETUP_TYPE = setuptools +PYTHON_RAVEN_LICENSE = BSD-3-Clause +PYTHON_RAVEN_LICENSE_FILES = LICENSE
Other than that looks good. Could you respin an updated version that takes into account those comments?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/2 package: add python-raven
Thomas,
Thanks for the feedback,
Quoted 1 line
Please include the change to the DEVELOPERS file in the same patch, no
need to make it a separate patch.
The manual states at the end of section 21.5.1:
Quoted 3 lines
If you are interested in getting notified of build failures and of further changes in the packages you added or modified, please add yourself to the DEVELOPERS file. This should be done in a separate patch of the series.
Did I misunderstand this section, or should the documentation be updated?
Quoted 1 line
It really doesn't have *any* runtime dependency on other Python
modules? I.e if you build just python-raven and the minimal python interpreter, it works?
Now that you mention it, it doesn't have any external requirements, but I'm unsure as to whether or not it requires any optional core modules. I would assume that it needs urllib at least. I'll test it and find out.
Quoted 1 line
Could you respin an updated version that
takes into account those comments?
Absolutely, thanks for taking the time to review this.
PATCH 1/2 package: add python-raven
Hello,
Quoted 5 lines · Joseph Kogut
Quoted 3 lines
If you are interested in getting notified of build failures and of further changes in the packages you added or modified, please add yourself to the DEVELOPERS file. This should be done in a separate patch of the series.
Did I misunderstand this section, or should the documentation be updated?
The documentation should be updated. Back when we initially introduced the DEVELOPERS file, we indeed thought that having a separate patch for the DEVELOPERS file change was best, but we then changed our mind. I thought we had updated our documentation, but apparently not. Do you think you could send a patch fixing this?
Quoted 8 lines
Quoted 1 line
It really doesn't have *any* runtime dependency on other Python
modules? I.e if you build just python-raven and the minimal python interpreter, it works?
Now that you mention it, it doesn't have any external requirements, but I'm unsure as to whether or not it requires any optional core modules. I would assume that it needs urllib at least. I'll test it and find out.
Enable just BR2_PACKAGE_PYTHON=y and BR2_PACKAGE_PYTHON_RAVEN=y, build this, boot, and check that python-raven works correctly on the target. That's the only way to be sure :)
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com